Focus the compose field after closing modals #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonals
reviewed
Mar 11, 2021
| @@ -62,6 +70,11 @@ class ReportActionCompose extends React.Component { | |||
| if (this.props.comment && prevProps.comment === '' && prevProps.comment !== this.props.comment) { | |||
| this.comment = this.props.comment; | |||
| } | |||
|
|
|||
| // When any modal goes from visible to hidden, bring focus to the compose field | |||
| if (prevProps.modal.isVisible === true && this.props.modal.isVisible === false) { | |||
There was a problem hiding this comment.
NAB. We can just do if (prevProps.modal.isVisible && !this.props.modal.isVisible) here, right?
Gonals
reviewed
Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I added a global state for tracking if modals are open or closed, then connected that state to the compose field so it gets focus when modals are closed.
Fixed Issues
Fixes https://github.com//issues/1513 Fixes https://github.com/Expensify/Expensify/issues/154180Tests
Tested On
iOS(n/a because the field does not get focus by design)Android(n/a because the field does not get focus by design)Screenshots
Web
Not really any screenshots necessary
Mobile Web
Not really any screenshots necessary
Desktop
Not really any screenshots necessary
iOS
Not really any screenshots necessary
Android
Not really any screenshots necessary