[Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command #16926

mountiny · 2023-04-04T17:27:15Z

Details

Adding OpenMoneyRequestsReportPage read command call to pull transaction data. This is not used anywhere in the product yet.

Related Web-E PR https://github.com/Expensify/Web-Expensify/pull/36959

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270585

Tests

Manually call this Report.openMoneyRequestsReportPage with valid iouReportID
Verify you get the expected return onyx data
Thats transaction data keyed by transactionID in the transactions_ onyx collection key

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

No visible changes in the app so nothing to show here.

Response from a command:

{
   "onyxData":[
      {
         "onyxMethod":"set",
         "key":"report_5265731642757761",
         "value":{
            "reportID":"5265731642757761",
            "type":"iou",
            "ownerEmail":"[email protected]",
            "managerEmail":"[email protected]",
            "currency":"CZK",
            "chatReportID":"5860324700845728",
            "state":"SUBMITTED",
            "cachedTotal":"(K\u010d392.05)",
            "total":39205,
            "stateNum":1,
            "submitterPayPalMeAddress":"",
            "hasOutstandingIOU":true
         }
      },
      {
         "onyxMethod":"mergecollection",
         "key":"transactions_",
         "value":{
            "transactions_5265731642757761":{
               "3601095477076285295":{
                  "amount":-1000,
                  "comment":{
                     "comment":"test"
                  },
                  "created":"2023-04-14 07:37:24",
                  "currency":"GBP",
                  "modifiedAmount":0,
                  "modifiedCreated":"",
                  "modifiedCurrency":"",
                  "transactionID":"3601095477076285295"
               },
               "6288687046925990472":{
                  "amount":10000,
                  "comment":{
                     "comment":""
                  },
                  "created":"2023-01-03 13:08:25",
                  "currency":"AED",
                  "modifiedAmount":0,
                  "modifiedCreated":"",
                  "modifiedCurrency":"",
                  "transactionID":"6288687046925990472"
               },
               "2060282402996207705":{
                  "amount":10000,
                  "comment":{
                     "comment":""
                  },
                  "created":"2023-01-03 13:08:22",
                  "currency":"CZK",
                  "modifiedAmount":0,
                  "modifiedCreated":"",
                  "modifiedCurrency":"",
                  "transactionID":"2060282402996207705"
               }
            }
         }
      }
   ],
   "jsonCode":200,
   "requestID":"uoUAKk"
}

Screenshot from db

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

mountiny · 2023-04-14T07:18:48Z

src/ONYXKEYS.js

+        DOWNLOAD: 'download_',
+        POLICY: 'policy_',
+        POLICY_MEMBER_LIST: 'policyMemberList_',
        REPORT: 'report_',
        REPORT_ACTIONS: 'reportActions_',
+        REPORT_ACTIONS_DRAFTS: 'reportActionsDrafts_',
        REPORT_DRAFT_COMMENT: 'reportDraftComment_',
        REPORT_DRAFT_COMMENT_NUMBER_OF_LINES: 'reportDraftCommentNumberOfLines_',
-        REPORT_ACTIONS_DRAFTS: 'reportActionsDrafts_',
-        REPORT_USER_IS_TYPING: 'reportUserIsTyping_',
-        POLICY: 'policy_',
        REPORT_IS_COMPOSER_FULL_SIZE: 'reportIsComposerFullSize_',
-        POLICY_MEMBER_LIST: 'policyMemberList_',
-        DOWNLOAD: 'download_',
+        REPORT_USER_IS_TYPING: 'reportUserIsTyping_',
+        TRANSACTION: 'transactions_',


Reshuffled this so its in alphabetcal order.

MelvinBot · 2023-04-14T07:35:01Z

@aimane-chnaif @marcaaron One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-04-14T07:56:24Z

@mountiny does this require C+ review?

aimane-chnaif · 2023-04-14T07:56:42Z

oh sorry, I noticed you removed me already 🙂

mountiny · 2023-04-14T07:58:03Z

I dont think this will require C+ review. Thank you Aimane!

mountiny · 2023-04-14T08:04:47Z

@luacmartins Added screenshots of the tested command and the response, its looking good.

Given the command is not called I think we dont have to hold on the Web-E PR

luacmartins

LGTM!

luacmartins · 2023-04-14T16:18:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcaaron · 2023-04-14T19:23:11Z

👀 ing at this

marcaaron · 2023-04-14T19:26:50Z

src/libs/actions/Report.js

+                onyxMethod: CONST.ONYX.METHOD.MERGE,
+                key: ONYXKEYS.IOU,
+                value: {
+                    loading: true,


NAB, I don't think it needs to be done now. But anyone else think it's weird that we have an IOU key that only exists to set a loading: Boolean state?

Yea, this was pretty confusing to me. I don't think we should tackle it as part of this PR, but this is definitely something that we should consider refactoring.

Yes, I felt the same but I just wanted to keep the scope simple and mimic what we had for the OpenPaymentsDetails page.

marcaaron · 2023-04-14T19:33:12Z

Thinking through the above comment some more...

Tracking the loading state of something like a blocking "read" command could maybe look different if we can reimagine how it might work with hooks.

const {loading, errors} = useAction(Report.openMoneyRequestsReportPage)

not really sure how that implementation would work, but just thinking out loud on it. I find it slightly confusing to connect which actions are triggering which loading states or errors sometimes.

OSBotify · 2023-04-14T20:48:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-18T04:39:39Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-18T06:09:15Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-19T17:22:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add a new transaction collection onyx key

25378fe

mountiny self-assigned this Apr 4, 2023

luacmartins self-requested a review April 11, 2023 18:13

mountiny added 2 commits April 12, 2023 17:10

Merge branch 'main' into vit-OpenMultipleMoneyRequestsPaymentPage

398600c

Update the onyx key and add IOU action api method

f1d8b2d

mountiny changed the title ~~[Manual Requests] Add OpenMultipleMoneyRequestsDetailsPage command~~ [Manual Requests] Add OpenMoneyRequestsReportPage command Apr 14, 2023

mountiny commented Apr 14, 2023

View reviewed changes

mountiny marked this pull request as ready for review April 14, 2023 07:34

mountiny requested a review from a team as a code owner April 14, 2023 07:34

melvin-bot bot requested review from aimane-chnaif and marcaaron and removed request for a team April 14, 2023 07:34

mountiny removed the request for review from aimane-chnaif April 14, 2023 07:48

mountiny changed the title ~~[Manual Requests] Add OpenMoneyRequestsReportPage command~~ [WIP] [Manual Requests] Add OpenMoneyRequestsReportPage command Apr 14, 2023

mountiny changed the title ~~[WIP] [Manual Requests] Add OpenMoneyRequestsReportPage command~~ [Manual Requests] Add OpenMoneyRequestsReportPage command Apr 14, 2023

luacmartins changed the title ~~[Manual Requests] Add OpenMoneyRequestsReportPage command~~ [Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command Apr 14, 2023

luacmartins approved these changes Apr 14, 2023

View reviewed changes

marcaaron approved these changes Apr 14, 2023

View reviewed changes

marcaaron merged commit bcdf4a3 into main Apr 14, 2023

marcaaron deleted the vit-OpenMultipleMoneyRequestsPaymentPage branch April 14, 2023 20:41

OSBotify mentioned this pull request Apr 17, 2023

Deploy Checklist: New Expensify 2023-04-17 #17546

Closed

53 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command #16926

[Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command #16926

mountiny commented Apr 4, 2023 •

edited

Loading

mountiny Apr 14, 2023

MelvinBot commented Apr 14, 2023

aimane-chnaif commented Apr 14, 2023

aimane-chnaif commented Apr 14, 2023

mountiny commented Apr 14, 2023 •

edited

Loading

mountiny commented Apr 14, 2023 •

edited

Loading

luacmartins left a comment

luacmartins commented Apr 14, 2023 •

edited

Loading

marcaaron commented Apr 14, 2023 •

edited

Loading

marcaaron Apr 14, 2023

luacmartins Apr 14, 2023

mountiny Apr 14, 2023

marcaaron commented Apr 14, 2023

OSBotify commented Apr 14, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 19, 2023

[Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command #16926

[Manual Requests] [No QA] Add OpenMoneyRequestsReportPage command #16926

Conversation

mountiny commented Apr 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mountiny Apr 14, 2023

Choose a reason for hiding this comment

MelvinBot commented Apr 14, 2023

aimane-chnaif commented Apr 14, 2023

aimane-chnaif commented Apr 14, 2023

mountiny commented Apr 14, 2023 • edited Loading

mountiny commented Apr 14, 2023 • edited Loading

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Apr 14, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcaaron commented Apr 14, 2023 • edited Loading

marcaaron Apr 14, 2023

Choose a reason for hiding this comment

luacmartins Apr 14, 2023

Choose a reason for hiding this comment

mountiny Apr 14, 2023

Choose a reason for hiding this comment

marcaaron commented Apr 14, 2023

OSBotify commented Apr 14, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 19, 2023

mountiny commented Apr 4, 2023 •

edited

Loading

mountiny commented Apr 14, 2023 •

edited

Loading

mountiny commented Apr 14, 2023 •

edited

Loading

luacmartins commented Apr 14, 2023 •

edited

Loading

marcaaron commented Apr 14, 2023 •

edited

Loading