Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use push to page for report settings #16910

Merged
merged 47 commits into from
May 17, 2023
Merged
Changes from 2 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
467e981
Navigate back after changing the name
Gonals Apr 4, 2023
f9a98c7
remove unneded import
Gonals Apr 4, 2023
5e35c84
Merge branch 'main' into alberto-naviOut
Gonals Apr 5, 2023
09a03b5
remove navigation back
Gonals Apr 5, 2023
2cb9424
create new RoomNamePage component
Gonals Apr 5, 2023
fd706e6
actually add the page
Gonals Apr 5, 2023
e5b37e7
actually add them
Gonals Apr 5, 2023
512e839
remove unneeded imports
Gonals Apr 5, 2023
642b698
cleanup component
Gonals Apr 5, 2023
05ca854
more cleanup
Gonals Apr 5, 2023
faac28e
add route
Gonals Apr 5, 2023
891b87f
get right props
Gonals Apr 5, 2023
6ec699c
add validation
Gonals Apr 5, 2023
a7f795d
changing branch
Gonals Apr 10, 2023
72b095e
Merge branch 'main' into alberto-naviOut
Gonals Apr 10, 2023
362a51c
Add prefix handling
Gonals Apr 11, 2023
a4d6f8b
save and return correctly for name
Gonals Apr 11, 2023
7cc104c
Create NotificationPreferencesPage
Gonals Apr 11, 2023
88ee4e0
add route
Gonals Apr 11, 2023
2e41ae7
changing branch
Gonals Apr 12, 2023
d8eeb49
add icons
Gonals Apr 15, 2023
77b9bce
Remove form, push to page for report settings
neil-marcellini Apr 18, 2023
0773f90
Remove unused code after refactor
neil-marcellini Apr 18, 2023
f31f124
Translate and capitalize notification preference
neil-marcellini Apr 18, 2023
223d1fa
Refactor notif pref page to functional component
neil-marcellini Apr 26, 2023
bd116ee
Store notificationPreferences separately for page
neil-marcellini Apr 26, 2023
3c96c2e
Update notif pref from option selection
neil-marcellini Apr 26, 2023
75614a3
Update prop type comment
neil-marcellini Apr 26, 2023
63e3b04
Update notification pref and navigate
neil-marcellini Apr 26, 2023
df4947c
Immediately key is always
neil-marcellini Apr 26, 2023
2b12c20
Convert RoomNamePage to functional component
neil-marcellini Apr 27, 2023
2b5e277
Update policy room and navigate in one action
neil-marcellini Apr 27, 2023
cb2d057
Dismiss keyboard after submitting on pushed page
neil-marcellini Apr 27, 2023
1c8d75e
Auto focus room name input
neil-marcellini Apr 27, 2023
23d17cd
Remove unused onyx form key
neil-marcellini Apr 27, 2023
37bcfa7
Merge branch 'main' into alberto-naviOut
neil-marcellini Apr 27, 2023
2d9d5fe
Match existing room name validation
neil-marcellini Apr 27, 2023
29c4293
Fix a bunch of misc errors
neil-marcellini Apr 27, 2023
01c6a3d
Prevent saving unchanged report notif pref
neil-marcellini Apr 27, 2023
df86d8c
Fix linter
neil-marcellini Apr 27, 2023
a303cc4
Fix empty room name validation
neil-marcellini May 1, 2023
6b843a1
Merge branch 'main' into alberto-naviOut
neil-marcellini May 16, 2023
bc6fe65
Clean up spacing and wrappers per feedback
neil-marcellini May 17, 2023
f4a4e62
Pretty pretty
neil-marcellini May 17, 2023
f54cf5f
Use sentence case
neil-marcellini May 17, 2023
b1e63d6
Prevent navigate back loop after direct url access
neil-marcellini May 17, 2023
73fd848
Merge branch 'main' into alberto-naviOut
neil-marcellini May 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/pages/ReportSettingsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ class ReportSettingsPage extends Component {
return;
}
Report.updatePolicyRoomName(this.props.report, values.newRoomName);
Navigation.goBack();
}

/**
Expand Down