Remove incorrect `this` from replaceEmojis function #16902

Beamanator · 2023-04-04T09:20:53Z

Details

Fixed Issues

$ #16896

Tests

Launch the app
Open any chat
Send a message that includes emojis
Edit the message with the emojis. Try to add new emojis like :100: (you won't see auto-complete but you will have to type the 2nd : to finish the emoji replacement

Verify that no errors appear in the JS console

Offline tests

Same as above, nothing special needed here

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-04.at.11.16.42.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-04-04.at.11.32.39.AM.mov

Mobile Web - Safari

Screen.Recording.2023-04-04.at.1.08.16.PM.mov

Desktop

Screen.Recording.2023-04-04.at.11.23.06.AM.mov

iOS

Screen.Recording.2023-04-04.at.1.06.21.PM.mov

Android

Screen.Recording.2023-04-04.at.11.30.37.AM.mov

MelvinBot · 2023-04-04T09:21:36Z

@Santhosh-Sellavel @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator · 2023-04-04T10:19:29Z

@Santhosh-Sellavel are you free to test this soon? It's fixing a deploy blocker. If not I may ask internally 👍

Santhosh-Sellavel · 2023-04-04T10:58:31Z

Yes will get to it shortly.

Beamanator · 2023-04-04T11:09:11Z

Videos finally all updated 🙏

Santhosh-Sellavel · 2023-04-04T11:49:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Desktop & Web

Screen.Recording.2023-04-04.at.5.11.39.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-04-04.at.5.16.02.PM.mov

iOS & Android

Screen.Recording.2023-04-04.at.5.14.01.PM.mov

Santhosh-Sellavel

LGTM, tests well!

OSBotify · 2023-04-04T12:16:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2023-04-04T12:24:45Z

@cristipaval @Beamanator this should have been CPed to staging, should it not?

Beamanator · 2023-04-04T12:48:31Z

@mountiny frick, i always forget that label 🙃

Beamanator · 2023-04-04T12:49:01Z

What do we do now?? 😅

mountiny · 2023-04-04T12:53:03Z

I can do this, you can just trigger the CP staging manually just wanted to confirm

Beamanator · 2023-04-04T12:53:19Z

Okkk phew thanks 😅 👍

mountiny · 2023-04-04T12:54:45Z

https://stackoverflowteams.com/c/expensify/questions/10366/10367#10367 for context.

Scheduled it

Remove incorrect `this` from replaceEmojis function (cherry picked from commit b302017)

…-16902 🍒 Cherry pick PR #16902 to staging 🍒

OSBotify · 2023-04-04T14:10:27Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.2.94-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

s77rt · 2023-04-04T15:29:24Z

src/libs/EmojiUtils.js

+ * @param {Number} preferredSkinToneIndex
+ * @returns {String}
+ */
+const getEmojiCodeWithSkinColor = (item, preferredSkinToneIndex) => {


Any reason we moved the function here?

Yeahhh just cuz the linter was upset that we were calling a function before it was declared

You should be able to see the error here: https://github.com/Expensify/App/actions/runs/4606109496/jobs/8138999140

thienlnam · 2023-04-04T23:14:38Z

Passes QA!

OSBotify · 2023-04-05T02:28:17Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:34:13Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:51:58Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

This this doesn't belong here here

3ee7b49

Beamanator requested a review from a team as a code owner April 4, 2023 09:20

Beamanator self-assigned this Apr 4, 2023

melvin-bot bot requested review from PauloGasparSv and Santhosh-Sellavel and removed request for a team April 4, 2023 09:21

Move fn above where it's used

cfe0a24

cristipaval approved these changes Apr 4, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Apr 4, 2023

View reviewed changes

cristipaval merged commit b302017 into main Apr 4, 2023

cristipaval deleted the beaman-fixEmojiReplace branch April 4, 2023 12:13

OSBotify pushed a commit that referenced this pull request Apr 4, 2023

Merge pull request #16902 from Expensify/beaman-fixEmojiReplace

c2a18aa

Remove incorrect `this` from replaceEmojis function (cherry picked from commit b302017)

OSBotify mentioned this pull request Apr 4, 2023

🍒 Cherry pick PR #16902 to staging 🍒 #16907

Merged

OSBotify added a commit that referenced this pull request Apr 4, 2023

Merge pull request #16907 from Expensify/mountiny-cherry-pick-staging…

24ec4e0

…-16902 🍒 Cherry pick PR #16902 to staging 🍒

s77rt reviewed Apr 4, 2023

View reviewed changes

OSBotify mentioned this pull request Apr 4, 2023

Deploy Checklist: New Expensify 2023-04-03 #16880

Closed

21 tasks

thienlnam mentioned this pull request Apr 4, 2023

[HOLD for payment 2023-04-12] Web - Chat - User can't type second ":" to finish emoji input in edit mode #16896

Closed

6 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove incorrect `this` from replaceEmojis function #16902

Remove incorrect `this` from replaceEmojis function #16902

Beamanator commented Apr 4, 2023 •

edited

Loading

MelvinBot commented Apr 4, 2023

Beamanator commented Apr 4, 2023

Santhosh-Sellavel commented Apr 4, 2023

Beamanator commented Apr 4, 2023

Santhosh-Sellavel commented Apr 4, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

OSBotify commented Apr 4, 2023

mountiny commented Apr 4, 2023

Beamanator commented Apr 4, 2023

Beamanator commented Apr 4, 2023

mountiny commented Apr 4, 2023

Beamanator commented Apr 4, 2023

mountiny commented Apr 4, 2023 •

edited

Loading

OSBotify commented Apr 4, 2023

s77rt Apr 4, 2023 •

edited

Loading

Beamanator Apr 4, 2023

Beamanator Apr 4, 2023

s77rt Apr 4, 2023

thienlnam commented Apr 4, 2023

OSBotify commented Apr 5, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Remove incorrect this from replaceEmojis function #16902

Remove incorrect this from replaceEmojis function #16902

Conversation

Beamanator commented Apr 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 4, 2023

Beamanator commented Apr 4, 2023

Santhosh-Sellavel commented Apr 4, 2023

Beamanator commented Apr 4, 2023

Santhosh-Sellavel commented Apr 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 4, 2023

mountiny commented Apr 4, 2023

Beamanator commented Apr 4, 2023

Beamanator commented Apr 4, 2023

mountiny commented Apr 4, 2023

Beamanator commented Apr 4, 2023

mountiny commented Apr 4, 2023 • edited Loading

OSBotify commented Apr 4, 2023

s77rt Apr 4, 2023 • edited Loading

Choose a reason for hiding this comment

Beamanator Apr 4, 2023

Choose a reason for hiding this comment

Beamanator Apr 4, 2023

Choose a reason for hiding this comment

s77rt Apr 4, 2023

Choose a reason for hiding this comment

thienlnam commented Apr 4, 2023

OSBotify commented Apr 5, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Remove incorrect `this` from replaceEmojis function #16902

Remove incorrect `this` from replaceEmojis function #16902

Beamanator commented Apr 4, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 4, 2023 •

edited

Loading

mountiny commented Apr 4, 2023 •

edited

Loading

s77rt Apr 4, 2023 •

edited

Loading