-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IOUModal to MoneyRequestModal #16679
Merged
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2dda81f
Migrate the new modal props / HOC
thienlnam 6408554
add the class functions
thienlnam 4cf8420
migrate this.step
thienlnam 3b228b3
add refs for previous values
thienlnam 6f1af21
refactor the useEffect
thienlnam 1d5d5bc
add seperate component for header
thienlnam a447ee3
update all instances of this
thienlnam c2aa299
remove seperate header for now
thienlnam d8dd2d8
fix function declarations
thienlnam 60cf4f8
Comment updates
thienlnam 9f1a746
Update method for openMoneyRequestModalPage
thienlnam e0aaee7
Update usages of IOUModal Component
thienlnam 3cce255
update the api command that is called
thienlnam e810c37
Merge branch 'main' into jack-refactorIOUModal
thienlnam 81380cc
review comments / kill currency update
thienlnam 6424dd2
update routes / useEffect cleanup
thienlnam 07b1fd8
clean up comments
thienlnam 592f083
add new header component
thienlnam 1d916df
clean up method to use new component
thienlnam d4dd9d8
remove IOU Modal
thienlnam 78c23ad
comment update
thienlnam d82d777
Merge branch 'main' into jack-refactorIOUModal
thienlnam edd210c
Add initial mount details
thienlnam faf4cb0
review comments
thienlnam c9af57d
remove lint
thienlnam 1a8df6f
review. comments / update functions to useCallback
thienlnam 0ac8c49
update some functions to memo
thienlnam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
import React from 'react'; | ||
import IOUModal from './IOUModal'; | ||
import MoneyRequestModal from './MoneyRequestModal'; | ||
|
||
// eslint-disable-next-line react/jsx-props-no-spreading | ||
const IOUBillPage = props => <IOUModal {...props} hasMultipleParticipants />; | ||
const IOUBillPage = props => <MoneyRequestModal {...props} hasMultipleParticipants />; | ||
IOUBillPage.displayName = 'IOUBillPage'; | ||
export default IOUBillPage; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍