[NoQA] fix: do not use last actor details for LHN if last action is for closing chat #16606

BeeMargarida · 2023-03-28T10:34:18Z

Details

This a regression related to #15711. When a workspace is deleted, the preview message of the workspace channels (like #admin) appear with an incorrect message.

This PR contains a fix that only gets the last action details if the action is not related to opening or closing the chat. There are other type of actions here.

Fixed Issues

$ #15711
#15711 (comment)

Tests

No specific tests, this is a refactor of how the last message is shown in the LHN. General regression tests in this area should confirm all works fine.

Verify that no errors appear in the JS console

Offline tests

Not applicable

QA Steps

No specific tests, this is a refactor of how the last message is shown in the LHN. General regression tests in this area should confirm all works fine.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…ing chat

ArekChr

LGTM:)

MelvinBot · 2023-03-28T11:23:47Z

@mountiny @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Thanks, looks good, but wondering if it would be a bit cleaner with less variables, but not a blocker. @parasharrajat will you be able to test and review this one?

parasharrajat · 2023-03-28T14:56:15Z

Yes. I will do that.

BeeMargarida · 2023-03-29T10:54:19Z

wondering if it would be a bit cleaner with less variables, but not a blocker.

Updated!

parasharrajat · 2023-03-29T13:45:54Z

I will be back from the dentist in 1 hour and pick this up first.

mountiny

Looking good to me, gonna wait for Rajat's testing before merging.

Thanks @BeeMargarida great job 🎉

parasharrajat · 2023-03-29T16:26:19Z

Just back home. Gonna look into this asap.

mountiny · 2023-03-29T16:32:04Z

I hope no painful issues with your teeth 🦷

parasharrajat · 2023-03-29T16:41:51Z

No, It is running treatment.

parasharrajat · 2023-03-29T18:43:06Z

Strange, @mountiny I am not seeing the archived message in he ReportFooter on localhost.

This is staging

is it same for you?

parasharrajat · 2023-03-29T21:55:19Z

So there is a hidden action that is never shown to the user but can be present.

App/tests/unit/ReportActionsUtilsTest.js

Line 153 in 8a15103

actionName: 'REIMBURSED',

I think the best way to handle this would be the same way we display messages. report actions are filtered before being shown to the UI. So I think we should apply the same filters.

First the last action should not be deprecated.

App/src/libs/ReportActionsUtils.js

Line 193 in 8a15103

const filteredReportActions = filterOutDeprecatedReportActions(reportActions);
It should be one of the types present on the CONST.REPORT.ACTIONS.TYPE. Tests show that there can be an action of type REIMBURSED outside this list.
It should not be created and Closed.
It should not be deleted.

There are a few other types referring to CONST that I don't know how to handle because I don't have access to such chats.

Point 4 reminds me that It poses a challenge for us to get the correct user data from the last report actions. Deleted comments are not removed from report actions collections. So it is possible that the lastReportAction in the collection can be a deleted message. Thus we will show the wrong username with the last message. Even if we check whether the lastReportAction actor is the same as the last message actor, we won't be able to get the correct actor info.

Steps

On a room report.
Send a message from Account B.
Now log in with Account A.
Send a new message from Account A.
Delete the recent comment from Account A.
Force the lastActorDetails to be null to test this PR. https://github.com/Expensify/App/pull/16606/files#diff-164819655552b8656799f246055951a2c8af7509d3b15063fddd328e358299bbR253

Thus this approach is not foolproof.

If we patch our solution with the following then it might work.

Instead of directly getting the lastReportAction, we somehow keep track of the filtered list or get the last action by filtering the report actions list. Then if we follow the same filtering used for the last message calculation, then the last action will always be the same as the last message in the report. This might need backend inspection to determine how the last message is calculated. I was only able to find its calculation for Comment action on front end.

mountiny · 2023-03-30T01:28:52Z

regarding your concern, I think it might be because this is not synced up with main @BeeMargarida should be working in main

BeeMargarida · 2023-03-30T08:32:07Z

I am not seeing the archived message in he ReportFooter on localhost.

This looks fixed after the merge with main.

So, just to make sure I understood correctly, there's a mismatch between the last message we are showing and the last report action (which we use to get the last message user info). When we delete a message, it seems like there is no action for a comment deletion, only for ADDCOMMENT, so if no other action happened and no personal details exist, it will show the last message actor (the one that was deleted) as the author of the last shown message (even if they are not the same).

This problem does not happen in the other place where the last action is being used because it's related to the archive reason of a chat, so no other actions occur after that.

keep track of the filtered list or get the last action by filtering the report actions list. Then if we follow the same filtering used for the last message calculation, then the last action will always be the same as the last message in the report. This might need backend inspection to determine how the last message is calculated

We have access to the action list, since the last action is calculated from that. We could check if the lastReportAction actor email (actorEmail) is the same as the one we are showing as the last message (report.lastActorEmail). If not, we can then filter the all the actions for the one that matches. Is it possible to get an ideia of how this is done on the backend?

However, I'm not sure if this solution is better than just fetch the personal details of the user if we don't have them. Is this also a possible solution?

mountiny · 2023-03-30T12:04:50Z

@BeeMargarida @parasharrajat we can also just add a new filed to this onyx Selector

App/src/libs/SidebarUtils.js

Lines 55 to 67 in f327eb0

    
           const lastReportActions = {}; 
        
           const reportActions = {}; 
        
           Onyx.connect({ 
        
               key: ONYXKEYS.COLLECTION.REPORT_ACTIONS, 
        
               callback: (actions, key) => { 
        
                   if (!key || !actions) { 
        
                       return; 
        
                   } 
        
                   const reportID = CollectionUtils.extractCollectionItemID(key); 
        
                   lastReportActions[reportID] = _.last(_.toArray(actions)); 
        
                   reportActions[key] = actions; 
        
               }, 
        
           });

and pull only the last action of the types we accept

BeeMargarida · 2023-03-30T13:39:56Z

and pull only the last action of the types we accept

I may have misunderstood, but I think it won't solve the delete comment problem. Suppose we use this approach and save in a new field called lastFilteredReportAction the last action only with type ADDCOMMENT. Using the same scenario:

User 1 writes to chat
We have the lastFilteredReportAction with the correct info
User 1 deletes the last comment
The lastFilteredReportAction will have outdated info of the comment deleted. There's no action for comment deleted.

In this case, the only solution I'm seeing is the one mentioned before of filtering the report actions for the one that matches the last message sent.

mountiny · 2023-03-30T15:15:19Z

@BeeMargarida I am sorry, myabe we could bring this to the open source channel and describe the problem we are having right now summarized with steps to reproduce for example. I am not sure if I am following. If user writes a message and then deletes it, we will just show in LHN whatever was there before they sent the message as that will be the state fo the reportActions too.

BeeMargarida · 2023-03-30T16:03:42Z

If user writes a message and then deletes it, we will just show in LHN whatever was there before they sent the message as that will be the state fo the reportActions too.

But are the deleted comments removed from the reportActions? Because the problem that I think is happening is that the reportActions, and subsequently the last report action, will point to that last deleted comment instead of the previous message.

mountiny · 2023-03-31T10:33:22Z

But are the deleted comments removed from the reportActions? Because the problem that I think is happening is that the reportActions, and subsequently the last report action, will point to that last deleted comment instead of the previous message.

They are removed, at least when online and we succeed

App/src/libs/actions/Report.js

Lines 739 to 750 in 618d14e

    
           const successData = [ 
        
               { 
        
                   onyxMethod: CONST.ONYX.METHOD.MERGE, 
        
                   key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, 
        
                   value: { 
        
                       [reportActionID]: { 
        
                           pendingAction: null, 
        
                           previousMessage: null, 
        
                       }, 
        
                   }, 
        
               }, 
        
           ];

if its offline and we remove it optimistically, its still there until we get response from backend

BeeMargarida · 2023-03-31T14:55:27Z

They are removed, at least when online and we succeed

if its offline and we remove it optimistically, its still there until we get response from backend

Hum, I'll investigate this more. Monday I hope to have a better understanding and an updated proposal

parasharrajat · 2023-04-06T17:38:52Z

Why is it showing no Activity for archived rooms which has a chat history? Is this expected? this is the same for staging.

I noticed a thing when there was an unread message on the room and the workspace got deleted, this archived room was still showing the last message with the user displayName until I clicked it. Then it started to show no activity. is this Expected? @mountiny

parasharrajat · 2023-04-06T21:24:40Z

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat · 2023-04-07T00:21:52Z

Although solution looks like it works for the cases where reportAction is loaded in the Onyx it is still not an optimal solution. One of the reasons could be #16606 (comment).

I am fine closing this PR with this solution but a better approach might be to get the data of actors from the backend whose info is not present in Onyx when a message is received from such an actor. I am not sure how we relate contacts with an account. But the same can be used to add an actor's data to a user's personal details store.

The logic could be:

When a new message is received, Check if the user's personal details exist in the local Onyx database. If not make a call to store that actor's contact in the current user's account and also sync it in Onyx.
We can use push. When a new message is created on the report, in the backend push the info of that actor to all users' accounts and then send minimal info necessary to show that actor in UI via a separate subscription. This will keep the message's subscription healthy and fast.

If this is confusing and seems like I don't know what I am talking here, then please ignore 😄 .

parasharrajat · 2023-04-10T16:25:26Z

Awaiting your thoughts.

mountiny · 2023-04-11T12:25:55Z

Thanks! @parasharrajat

I am not really on board for making more API calls to get the details of the person. I think that could get quite messay and for now there is not much ROI for doing this.

I think that the No Activity yet if there is a comment in the report is an issue though. @BeeMargarida Would you be able to address that?

BeeMargarida · 2023-04-11T13:16:03Z

I think that the No Activity yet if there is a comment in the report is an issue though. @BeeMargarida Would you be able to address that?

Yap, investigating that now

BeeMargarida · 2023-04-11T14:03:06Z

I noticed a thing when there was an unread message on the room and the workspace got deleted, this archived room was still showing the last message with the user displayName until I clicked it. Then it started to show no activity.

@parasharrajat Can you still replicate the issue? I've pulled from main and tried replicating that behaviour but it seems like it's working fine. For the users of a workspace chat not admin, the channels disappear once the workspace is deleted, not sure if that is what is expected.

output_1.mp4

parasharrajat · 2023-04-11T14:38:18Z

Gonna recheck in a minute. Unfortunately, I tried yesterday but couldn't see any archived rooms not sure why.

mountiny · 2023-04-11T15:54:34Z

I tested locally now and I can still reproduce although its a weird behaviour, it shows the last message for a bit and then changes to No Activity yet, maybe checking the logic for when that is shown could help us figure out why

BeeMargarida · 2023-04-12T08:33:41Z

Sorry for causing this back and forth, but I'm not able to reproduce. I've tested both in the branch and in main, and the behaviour after the steps (unread messages in chat -> delete workspace) are the same in both. What steps are you doing, exactly?

There are two weird behaviours happening in both branches:

When opening an #announce archived chat, it disappears forever (can't even find it at the end of all the chats)
The workspace chat shows the This workspace chat is no longer active because <chat name> is no longer an active workspace. message instead of the last one written. Don't know if this is expected behaviour.

This branch

output.mp4

Main

output_1.mp4

mountiny · 2023-04-12T12:21:55Z

Wow ok thats super weird behaviour, there might have been some regression or whatnot.

parasharrajat · 2023-04-12T12:51:09Z

I agree that I am no more able to see the archived workspaces in my account so couldn't test. For this bug to reproduce, we need to have an old archived room in which a guide messages you. Because these guides are random thus their info is not saved in your data.

@mountiny Should we go ahead and merge this PR?

mountiny

@BeeMargarida One change requested.

I could not reproduce the issues locally. I think we can go ahead and merge and actually have a discussion in Slack about whats the expected out come of the preview text if we have a closed/ archived chat and handle it then based on what we agree on

src/libs/SidebarUtils.js

BeeMargarida · 2023-04-12T13:35:56Z

@mountiny Updated!

mountiny · 2023-04-12T13:36:38Z

@parasharrajat noticed there is no reviewer checklist, can you please run though that?

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @mountiny

🎀 👀 🎀 C+ reviewed

mountiny · 2023-04-12T14:10:50Z

I gave this another test based on the QA steps and I think this does not really work and the reason is that the lastMessageText is not populated for archived reports

App/src/libs/SidebarUtils.js

Line 250 in 1df7d58

    
           lastMessageTextFromReport = Str.htmlDecode(report ? report.lastMessageText : '');

which then leads to the no activity yet being shown

App/src/libs/SidebarUtils.js

Line 278 in 1df7d58

    
           result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

I will update the steps here, I think this is worthy refactor but the steps would fail QA.

In the follow up discussion we should agree what we want to show (the last message of user or the closed action text)?

mountiny

Thanks for the persistance here

OSBotify · 2023-04-12T14:19:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-13T03:43:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-17T22:58:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2023-09-04T15:19:33Z

src/libs/SidebarUtils.js

+        // The report is only visible if it is the last action not deleted that
+        // does not match a closed or created state.
+        const reportActionsForDisplay = _.filter(actionsArray, (reportAction, actionKey) => (ReportActionsUtils.shouldReportActionBeVisible(reportAction, actionKey)
+            && (reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED)));


Neither a regression nor in the scope of this PR, but we should also filter delete pending action items to correctly get the last visible item.

#24231

fix: do not use last actor details for LHN if last action is for clos…

03e830e

…ing chat

ArekChr previously approved these changes Mar 28, 2023

View reviewed changes

BeeMargarida marked this pull request as ready for review March 28, 2023 11:23

BeeMargarida requested a review from a team as a code owner March 28, 2023 11:23

melvin-bot bot requested review from mountiny and parasharrajat and removed request for a team March 28, 2023 11:23

mountiny assigned BeeMargarida Mar 28, 2023

mountiny reviewed Mar 28, 2023

View reviewed changes

refactor: use less variables

d6c5515

BeeMargarida dismissed ArekChr’s stale review via d6c5515 March 29, 2023 10:53

mountiny previously approved these changes Mar 29, 2023

View reviewed changes

Merge branch 'main' into fix/15711-preview-lhn-closed-chat

74ac25f

Merge branch 'main' into fix/15711-preview-lhn-closed-chat

eca4722

mountiny reviewed Apr 12, 2023

View reviewed changes

src/libs/SidebarUtils.js Outdated Show resolved Hide resolved

fix: use report instead of result

096bb5a

BeeMargarida dismissed mountiny’s stale review via 096bb5a April 12, 2023 13:27

parasharrajat approved these changes Apr 12, 2023

View reviewed changes

mountiny changed the title ~~fix: do not use last actor details for LHN if last action is for closing chat~~ [NoQA] fix: do not use last actor details for LHN if last action is for closing chat Apr 12, 2023

mountiny approved these changes Apr 12, 2023

View reviewed changes

mountiny merged commit 2d0ef06 into Expensify:main Apr 12, 2023

OSBotify mentioned this pull request Apr 13, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

MelvinBot mentioned this pull request Apr 17, 2023

[HOLD for payment 2023-04-24] Show message sender name in the LHN #15711

Closed

6 tasks

DanutGavrus mentioned this pull request Aug 15, 2023

[HOLD for payment 2023-09-06] [$1000] After deleting the last thread message, the 'completed task' message briefly appears in English instead of Spanish #24231

Closed

6 tasks

parasharrajat reviewed Sep 4, 2023

View reviewed changes

[NoQA] fix: do not use last actor details for LHN if last action is for closing chat #16606

[NoQA] fix: do not use last actor details for LHN if last action is for closing chat #16606

Conversation

BeeMargarida commented Mar 28, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ArekChr left a comment • edited Loading

Choose a reason for hiding this comment

MelvinBot commented Mar 28, 2023

mountiny left a comment

Choose a reason for hiding this comment

parasharrajat commented Mar 28, 2023

BeeMargarida commented Mar 29, 2023

parasharrajat commented Mar 29, 2023

mountiny left a comment

Choose a reason for hiding this comment

parasharrajat commented Mar 29, 2023

mountiny commented Mar 29, 2023

parasharrajat commented Mar 29, 2023

parasharrajat commented Mar 29, 2023 • edited Loading

parasharrajat commented Mar 29, 2023 • edited Loading

mountiny commented Mar 30, 2023

BeeMargarida commented Mar 30, 2023

mountiny commented Mar 30, 2023

BeeMargarida commented Mar 30, 2023

mountiny commented Mar 30, 2023

BeeMargarida commented Mar 30, 2023

mountiny commented Mar 31, 2023

BeeMargarida commented Mar 31, 2023 • edited Loading

parasharrajat commented Apr 6, 2023 • edited Loading

parasharrajat commented Apr 6, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented Apr 7, 2023 • edited Loading

parasharrajat commented Apr 10, 2023 • edited Loading

mountiny commented Apr 11, 2023

BeeMargarida commented Apr 11, 2023 • edited Loading

BeeMargarida commented Apr 11, 2023 • edited Loading

parasharrajat commented Apr 11, 2023

mountiny commented Apr 11, 2023

BeeMargarida commented Apr 12, 2023 • edited Loading

mountiny commented Apr 12, 2023

parasharrajat commented Apr 12, 2023

mountiny left a comment

Choose a reason for hiding this comment

BeeMargarida commented Apr 12, 2023

mountiny commented Apr 12, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

mountiny commented Apr 12, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 12, 2023

OSBotify commented Apr 13, 2023

OSBotify commented Apr 17, 2023

parasharrajat Sep 4, 2023

Choose a reason for hiding this comment

BeeMargarida commented Mar 28, 2023 •

edited by mountiny

Loading

ArekChr left a comment •

edited

Loading

parasharrajat commented Mar 29, 2023 •

edited

Loading

parasharrajat commented Mar 29, 2023 •

edited

Loading

BeeMargarida commented Mar 31, 2023 •

edited

Loading

parasharrajat commented Apr 6, 2023 •

edited

Loading

parasharrajat commented Apr 6, 2023 •

edited

Loading

parasharrajat commented Apr 7, 2023 •

edited

Loading

parasharrajat commented Apr 10, 2023 •

edited

Loading

BeeMargarida commented Apr 11, 2023 •

edited

Loading

BeeMargarida commented Apr 11, 2023 •

edited

Loading

BeeMargarida commented Apr 12, 2023 •

edited

Loading