Fix version pull request job #1597
Conversation
| create_pull_request: | ||
| runs-on: ubuntu-latest | ||
| needs: version | ||
| steps: | ||
| - uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Do we need the entire repo or just the branch? https://github.com/actions/checkout#checkout-a-different-branch
There was a problem hiding this comment.
I'm not sure, we might only need the feature branch and master
There was a problem hiding this comment.
I think since we probably need those two branches, the simplest for now is just to fetch everything. We can optimize for speed later by doing something more custom like one of the solutions or proposals from actions/checkout#214
There was a problem hiding this comment.
Let's fetch all for now 👍
|
@AndrewGable looks like this was merged without passing tests. Please add a note explaining why this was done or remove the |
|
Merged to fix deploys |
Details
Fixing these failures.
Fixed Issues
https://github.com/Expensify/Expensify/issues/155197
Tests
Tested On