Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[No QA] Filter out reportActionID-keyed Onyx updates" #14484

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Revert "[No QA] Filter out reportActionID-keyed Onyx updates" #14484

merged 1 commit into from
Jan 23, 2023

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jan 23, 2023 •
edited by iwiznia
Loading

@roryabraham roryabraham requested a review from a team as a code owner January 23, 2023 21:51
@roryabraham roryabraham self-assigned this Jan 23, 2023
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team January 23, 2023 21:52
@melvin-bot
Copy link

melvin-bot bot commented Jan 23, 2023

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chiragsalian
chiragsalian approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging since its straight revert

@chiragsalian chiragsalian merged commit 40e4baf into main Jan 23, 2023
@chiragsalian chiragsalian deleted the revert-14455-Rory-PickyReportActionsOnyxUpdates branch January 23, 2023 21:55
@melvin-bot melvin-bot bot added the Emergency label Jan 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 23, 2023

@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@chiragsalian
Copy link
Contributor

Not emergency, merged since its a straight revert.

OSBotify pushed a commit that referenced this pull request Jan 23, 2023
@chiragsalian @OSBotify
Merge pull request #14484 from Expensify/revert-14455-Rory-PickyRepor…
d699153 
…tActionsOnyxUpdates

Revert "[No QA] Filter out reportActionID-keyed Onyx updates"

(cherry picked from commit 40e4baf)
@OSBotify OSBotify mentioned this pull request Jan 23, 2023
Merged
OSBotify added a commit that referenced this pull request Jan 23, 2023
@OSBotify
Merge pull request #14486 from Expensify/OSBotify-cherry-pick-staging…
54630d9 
…-14484

🍒 Cherry pick PR #14484 to staging 🍒
@OSBotify OSBotify mentioned this pull request Jan 23, 2023
Closed
17 tasks
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Duration
App start TTI 664.700 ms → 684.019 ms (+19.319 ms, +2.9%)
Open Search Page TTI 604.614 ms → 617.435 ms (+12.822 ms, +2.1%)
App start runJsBundle 180.125 ms → 182.531 ms (+2.406 ms, +1.3%)
App start regularAppStart 0.020 ms → 0.015 ms (-0.005 ms, -24.6%) 🟢
App start nativeLaunch 21.034 ms → 20.733 ms (-0.301 ms, -1.4%)
Show details
Name Duration
App start TTI Baseline
Mean: 664.700 ms
Stdev: 24.291 ms (3.7%)
Runs: 605.5991620002314 629.24045499973 630.8699949998409 637.3247920004651 640.6247250000015 641.6795739997178 646.6071730004624 647.8679039999843 648.7076530000195 651.0460090003908 653.1295999996364 654.8356429999694 658.6110239997506 658.8576269997284 661.660229999572 663.6312030004337 664.4018620001152 666.9074790002778 673.4458210002631 674.7856379998848 674.8635809998959 677.7254370003939 679.4439519997686 679.6917369998991 684.4918689997867 688.4407430002466 689.0995270004496 702.7017059996724 703.6486039999872 703.7586639998481 711.9884700002149

Current
Mean: 684.019 ms
Stdev: 26.250 ms (3.8%)
Runs: 639.6974480003119 648.8438120000064 649.1844039997086 649.1881609996781 656.3800889998674 657.5247929999605 662.6998349996284 664.2260640002787 664.5785579998046 665.6290619997308 668.1109260004014 669.146538999863 674.1660430002958 678.3275650003925 679.491941999644 679.6359000001103 680.29494599998 680.2998470002785 685.8496789997444 691.858203000389 693.421377999708 697.3197250002995 697.3308140002191 699.4101560004056 701.5490769995376 702.2679620003328 702.3397380001843 718.5754509996623 719.2916679996997 734.5214139996096 735.0036289999261 742.4418190000579
Open Search Page TTI Baseline
Mean: 604.614 ms
Stdev: 22.947 ms (3.8%)
Runs: 567.606119999662 569.9239099994302 571.9012039992958 572.291137999855 580.699137000367 584.7884929999709 585.541016000323 588.191570000723 589.284994000569 590.229085999541 591.8708499995992 593.3518070001155 594.1104739997536 595.3898120000958 596.4632160002366 601.2002769997343 602.1632079994306 607.1457520006225 608.3916020002216 613.5628660004586 614.0534260002896 616.488078000024 618.5489499997348 619.443726000376 623.6474199993536 624.359822999686 625.7685960000381 626.2064209999517 628.2762460000813 628.440266999416 653.4131680000573 664.8876550002024

Current
Mean: 617.435 ms
Stdev: 23.554 ms (3.8%)
Runs: 569.5773930000141 580.9026290001348 585.23852599971 588.1139730000868 591.0614430001006 592.7930910000578 598.0635179998353 602.5126949995756 603.7321780007333 604.5339759998024 605.6670330008492 606.7962649995461 607.0032150000334 609.3959149997681 615.9923499999568 616.7111819991842 619.3002530001104 620.7530519999564 621.2907719993964 622.3664560001343 625.2890629991889 625.3920899992809 625.4064539996907 627.7571620000526 636.7403159998357 636.8704029992223 637.9233809998259 644.0333659993485 648.3803709996864 653.4268800001591 661.659953000024 673.2448330000043
App start runJsBundle Baseline
Mean: 180.125 ms
Stdev: 14.968 ms (8.3%)
Runs: 157 160 161 162 165 165 168 169 169 170 171 173 173 174 174 175 176 176 177 181 182 187 192 194 195 198 198 201 203 203 204 211

Current
Mean: 182.531 ms
Stdev: 18.016 ms (9.9%)
Runs: 155 158 159 160 163 164 166 167 170 171 175 175 175 176 177 177 177 179 179 182 189 193 196 196 200 201 203 206 208 208 209 227
App start regularAppStart Baseline
Mean: 0.020 ms
Stdev: 0.001 ms (7.2%)
Runs: 0.017780999653041363 0.017862999811768532 0.018024999648332596 0.018066000193357468 0.018106999807059765 0.018717999570071697 0.0188400000333786 0.018920999951660633 0.01896199956536293 0.01896199956536293 0.01928700041025877 0.019368999637663364 0.019491000100970268 0.019531000405550003 0.01961199939250946 0.01969399955123663 0.019694000482559204 0.019694000482559204 0.019775000400841236 0.020100999623537064 0.020223000086843967 0.020426999777555466 0.020711000077426434 0.02075199969112873 0.020914999768137932 0.0210359999909997 0.021810000762343407 0.022420000284910202 0.02250200044363737 0.023721999488770962

Current
Mean: 0.015 ms
Stdev: 0.001 ms (4.6%)
Runs: 0.013591000810265541 0.013956999406218529 0.013997000642120838 0.014161000028252602 0.014282000251114368 0.01448499970138073 0.014485999941825867 0.014525999315083027 0.014526999555528164 0.014566999860107899 0.014566999860107899 0.014607999473810196 0.014689000323414803 0.014689000323414803 0.0147299999371171 0.014812000095844269 0.014973999932408333 0.015014000236988068 0.015137000009417534 0.015178000554442406 0.015217999927699566 0.015298999845981598 0.015421000309288502 0.015583999454975128 0.015584999695420265 0.015665999613702297 0.01574699953198433 0.016153999604284763 0.016193999908864498 0.016521000303328037
App start nativeLaunch Baseline
Mean: 21.034 ms
Stdev: 1.564 ms (7.4%)
Runs: 19 19 19 19 19 19 19 20 20 20 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 23 23 24 25

Current
Mean: 20.733 ms
Stdev: 1.731 ms (8.3%)
Runs: 18 19 19 19 19 19 19 19 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 22 22 23 23 23 24 26

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 1.2.58-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.2.58-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jan 25, 2023
Closed
19 tasks
@roryabraham roryabraham mentioned this pull request Jan 25, 2023
Closed
@OSBotify OSBotify mentioned this pull request May 2, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Jun 15, 2023
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

@amyevans amyevans Awaiting requested review from amyevans

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @chiragsalian @OSBotify