Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
react-native-reanimated
the the latest available RCSome of us are currently running into a
[!] Invalid `RNReanimated.podspec` file: undefined method `exists?' for File:Class.
error when runningpod install
, which seems to have been fixed in software-mansion/react-native-reanimated#3919.Fixed Issues
No open issue that I know of, this was brought up in our internal Slack here.
Tests
npm i
, thenpod install
in theios/
dirOn all platforms:
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Mobile Web - Chrome
Screen.Recording.2023-01-11.at.6.43.50.PM.mov
Mobile Web - Safari
Screen.Recording.2023-01-11.at.6.36.23.PM.mov
Desktop
Screen.Recording.2023-01-11.at.6.38.57.PM.mov
iOS
Screen.Recording.2023-01-11.at.6.35.27.PM.mov
Android