Keep input cursor in place when toggling password checkbox #13187

esh-g · 2022-11-30T13:45:13Z

Details

Added a checkbox native file that takes care of the events onMouseDown and onPress which seem to be causing this issue.

Fixed Issues

$ #12018
PROPOSAL: #12018 (comment)

Tests

Click on the password text input to bring it into focus
Enter some text
Press the show/hide button
The cursor stays in the same place
Repeat step 4 with the cursor in a few different places (beginning and middle of password)

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click on the password text input to bring it into focus
Enter some text
Press the show/hide button
The cursor stays in the same place
Repeat step 4 with the cursor in a few different places (beginning and middle of password)

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots/Videos

Web

Chrome-arm64.mov

Mobile Web - Chrome

Chrome-mobile.mp4

Web - Safari

Safari.mov

Desktop

desktop.mov

iOS

iOS.mov

Android

Android.mov

Signed-off-by: someone-here <[email protected]>

melvin-bot · 2022-11-30T13:45:17Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2022-11-30T13:45:20Z

@Julesssss @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/Checkbox/BaseCheckbox.js

src/components/Checkbox/index.js

src/components/Checkbox/index.native.js

src/components/Checkbox/BaseCheckbox.js

esh-g · 2022-11-30T15:12:37Z

I think the linter issue went away because now we are no longer using inline functions...

Added docstring Co-authored-by: Eugene <[email protected]>

MouseDown doc string Co-authored-by: Eugene <[email protected]>

Removed unused line Co-authored-by: Eugene <[email protected]>

src/components/Checkbox/BaseCheckbox.js

esh-g · 2022-11-30T15:49:17Z

Fixed the formatting now. 0 lint errors

esh-g · 2022-11-30T16:13:34Z

Is this working as expected?

eVoloshchak · 2022-11-30T18:46:44Z

src/components/TextInput/BaseTextInput.js

@@ -291,8 +295,7 @@ class BaseTextInput extends Component {
                                    {this.props.secureTextEntry && (
                                        <Checkbox
                                            style={styles.secureInputShowPasswordButton}
-                                            onPress={this.togglePasswordVisibility}
-                                            onMouseDown={e => e.preventDefault()}
+                                            onMouseDown={this.togglePasswordVisibility}


This can't be working since there is no onPress handler

Screen.Recording.2022-11-30.at.20.45.29.mov

It just does nothing on native and mWeb
Please test all the platforms every time you open a new PR

In the handler for native(checkbox.native.js), it automatically adds the onPress if it is not present. Or at least it used to....

eVoloshchak · 2022-11-30T18:47:56Z

src/components/Checkbox/BaseCheckbox.js

+    if (!props.onMouseDown && !props.onPress) {
+        return;
+    }
+    return new Error(`One of "onMouseDown" or "onPress" must be provided in ${componentName}`);


There is propTypes error on application start

Android also or iOS only?

And does it work despite the warning?

Android also or iOS only?

All of the platforms

And does it work despite the warning?

No, take a look at this comment

please test everything before opening a PR

Actually, when I did the change during the PR, that is when this bug was introduced. I tested it thoroughly before submitting. In the requiredPropCheck function, the conditions were negated by mistake which caused it to show the error even when the props were set. But anyway, I fixed it and also changed the position of the props spreading to be more reliable. Do you want me to send the videos for any platform again?

Do you want me to send the videos for any platform again?

No, just verify that it is working

esh-g · 2022-11-30T19:20:22Z

Now, finally it is fixed but I had to disable the eslint warning that forced me to make the breaking change before....
Really grateful for your patience...

esh-g · 2022-11-30T19:27:26Z

When testing for mWeb, please make sure that chrome it updated to the latest version 107 because there might be some internal issues in versions below 102/103

src/components/Checkbox/BaseCheckbox.js

Co-authored-by: Eugene <[email protected]>

eVoloshchak · 2022-12-01T14:51:34Z

Screen.Recording.2022-12-01.at.16.50.25.mov

Bug in Chrome mWeb

esh-g · 2022-12-01T14:52:31Z

Please check the chrome version #13187 (comment)

eVoloshchak · 2022-12-01T15:11:26Z

Please check the chrome version #13187 (comment)

You are correct, thank you

eVoloshchak · 2022-12-01T15:11:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-12-01.at.16.34.37.mov

Mobile Web - Chrome

22-12-01-17-04-03.mp4

Mobile Web - Safari

Screen.Recording.2022-12-01.at.16.36.50.mov

Desktop

Screen.Recording.2022-12-01.at.16.48.18.mov

iOS

Screen.Recording.2022-12-01.at.16.35.34.mov

Android

22-12-01-17-08-26.mp4

eVoloshchak

Looks good and tests well
cc: @Julesssss

esh-g · 2022-12-01T17:05:35Z

Is this PR now ready to merge?

Julesssss

Testing well for me on all platforms. Thanks for your patience with these PRs.

OSBotify · 2022-12-01T17:16:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

esh-g · 2022-12-01T17:47:25Z

@Julesssss and @eVoloshchak I want to thank you for being patient with me as I am new to this and you really helped me learn a lot about open-source and best practices for contributing.

eVoloshchak · 2022-12-01T17:49:11Z

@Julesssss and @eVoloshchak I want to thank you for being patient with me as I am new to this and you really helped me learn a lot about open-source and best practices for contributing.

Thank you for saying this!
And thank you for contributing and making the app better :)

esh-g · 2022-12-01T17:54:42Z

And for this job, where can I apply to the upwork posting?

eVoloshchak · 2022-12-01T18:09:47Z

And for this job, where can I apply to the upwork posting?

https://www.upwork.com/jobs/~017777eb694223c27d

esh-g · 2022-12-01T18:13:01Z

Oh, this is the same one as before. I have already sent a proposal to this job and updated the price as well.

parasharrajat · 2022-12-02T11:53:13Z

Can we please fix the PR title to indicate the solved issue or summary of code changes?

@eVoloshchak Please make sure you check that.

cc: @Julesssss

parasharrajat · 2022-12-02T11:58:23Z

src/components/Checkbox/BaseCheckbox.js

+import Icon from '../Icon';
+import * as Expensicons from '../Icon/Expensicons';
+
+// eslint-disable-next-line rulesdir/prefer-early-return


This should have been avoided. Please do not disable Linter warnings unless that is the only option.

e.g.

Here we have to disable the rule. because we want to pass all the generic/default props through.

<BaseCheckbox // eslint-disable-next-line react/jsx-props-no-spreading {...props} onMouseDown={props.onMouseDown ? props.onMouseDown : props.onPress} />

OSBotify · 2022-12-02T19:44:06Z

🚀 Deployed to staging by @Julesssss in version: 1.2.36-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-12-08T02:04:09Z

🚀 Deployed to production by @francoisl in version: 1.2.36-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

esh-g added 4 commits November 30, 2022 19:11

Native checkbox

fe8e232

Signed-off-by: someone-here <[email protected]>

Native checkbox

29c66cb

Signed-off-by: someone-here <[email protected]>

Fixed Styling and signed

96c6f0f

Signed-off-by: someone-here <[email protected]>

Refactored checkbox propType

3146d1d

Signed-off-by: someone-here <[email protected]>

esh-g requested a review from a team as a code owner November 30, 2022 13:45

melvin-bot bot requested review from eVoloshchak and Julesssss and removed request for a team November 30, 2022 13:45

esh-g mentioned this pull request Nov 30, 2022

Password toggle cursor state #13103

Closed

98 tasks

eVoloshchak suggested changes Nov 30, 2022

View reviewed changes

src/components/Checkbox/BaseCheckbox.js Show resolved Hide resolved

src/components/Checkbox/BaseCheckbox.js Show resolved Hide resolved

src/components/Checkbox/index.js Outdated Show resolved Hide resolved

src/components/Checkbox/index.native.js Outdated Show resolved Hide resolved

eVoloshchak suggested changes Nov 30, 2022

View reviewed changes

src/components/Checkbox/BaseCheckbox.js Show resolved Hide resolved

esh-g and others added 4 commits November 30, 2022 20:43

Update src/components/Checkbox/BaseCheckbox.js

d97a350

Added docstring Co-authored-by: Eugene <[email protected]>

Update src/components/Checkbox/BaseCheckbox.js

209a08d

MouseDown doc string Co-authored-by: Eugene <[email protected]>

Update src/components/Checkbox/index.js

ce2ca75

Removed unused line Co-authored-by: Eugene <[email protected]>

Update src/components/Checkbox/index.native.js

295f5d2

Removed unused line Co-authored-by: Eugene <[email protected]>

Julesssss reviewed Nov 30, 2022

View reviewed changes

src/components/Checkbox/BaseCheckbox.js Outdated Show resolved Hide resolved

Fixed formatting

d3c5858

eVoloshchak suggested changes Nov 30, 2022

View reviewed changes

Fixed Props

08c2282

eVoloshchak suggested changes Dec 1, 2022

View reviewed changes

src/components/Checkbox/BaseCheckbox.js Outdated Show resolved Hide resolved

src/components/Checkbox/BaseCheckbox.js Outdated Show resolved Hide resolved

esh-g and others added 2 commits December 1, 2022 20:13

Update src/components/Checkbox/BaseCheckbox.js

08a3600

Co-authored-by: Eugene <[email protected]>

Update src/components/Checkbox/BaseCheckbox.js

726708d

Co-authored-by: Eugene <[email protected]>

eVoloshchak approved these changes Dec 1, 2022

View reviewed changes

Julesssss assigned esh-g Dec 1, 2022

Julesssss approved these changes Dec 1, 2022

View reviewed changes

Julesssss merged commit ca5241d into Expensify:main Dec 1, 2022

parasharrajat reviewed Dec 2, 2022

View reviewed changes

Julesssss changed the title ~~Someone here password cursor state~~ Keep input cursor in place when toggling password checkbox Dec 2, 2022

This was referenced Dec 2, 2022

[HOLD for regression test steps] Checkbox is unchecked when selected #13269

Closed

Revert PR 13187 to resolve checkbox bug #13271

Merged

OSBotify mentioned this pull request Dec 2, 2022

Deploy Checklist: New Expensify 2022-12-02 #13283

Closed

38 tasks

kbecciv mentioned this pull request Dec 3, 2022

Login - Clicking the eye icon moves the cursor to the beginning #13308

Closed

melvin-bot bot mentioned this pull request Dec 8, 2022

[HOLD for payment 2022-12-15] [$500] Login - Clicking the eye icon moves the cursor to the beginning #12018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keep input cursor in place when toggling password checkbox #13187

Keep input cursor in place when toggling password checkbox #13187

esh-g commented Nov 30, 2022 •

edited by Julesssss

Loading

melvin-bot bot commented Nov 30, 2022

melvin-bot bot commented Nov 30, 2022

esh-g commented Nov 30, 2022 •

edited

Loading

esh-g commented Nov 30, 2022

esh-g commented Nov 30, 2022

eVoloshchak Nov 30, 2022

esh-g Nov 30, 2022

eVoloshchak Nov 30, 2022

esh-g Nov 30, 2022 •

edited

Loading

esh-g Nov 30, 2022

eVoloshchak Nov 30, 2022

eVoloshchak Nov 30, 2022

esh-g Nov 30, 2022

eVoloshchak Nov 30, 2022

esh-g commented Nov 30, 2022 •

edited

Loading

esh-g commented Nov 30, 2022

eVoloshchak commented Dec 1, 2022

esh-g commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

eVoloshchak left a comment

esh-g commented Dec 1, 2022

Julesssss left a comment

OSBotify commented Dec 1, 2022

esh-g commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

esh-g commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

esh-g commented Dec 1, 2022

parasharrajat commented Dec 2, 2022

parasharrajat Dec 2, 2022

OSBotify commented Dec 2, 2022

OSBotify commented Dec 8, 2022

Keep input cursor in place when toggling password checkbox #13187

Keep input cursor in place when toggling password checkbox #13187

Conversation

esh-g commented Nov 30, 2022 • edited by Julesssss Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Nov 30, 2022

melvin-bot bot commented Nov 30, 2022

esh-g commented Nov 30, 2022 • edited Loading

esh-g commented Nov 30, 2022

esh-g commented Nov 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

esh-g Nov 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

esh-g commented Nov 30, 2022 • edited Loading

esh-g commented Nov 30, 2022

eVoloshchak commented Dec 1, 2022

esh-g commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

esh-g commented Dec 1, 2022

Julesssss left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 1, 2022

esh-g commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

esh-g commented Dec 1, 2022

eVoloshchak commented Dec 1, 2022

esh-g commented Dec 1, 2022

parasharrajat commented Dec 2, 2022

Choose a reason for hiding this comment

OSBotify commented Dec 2, 2022

OSBotify commented Dec 8, 2022

esh-g commented Nov 30, 2022 •

edited by Julesssss

Loading

esh-g commented Nov 30, 2022 •

edited

Loading

esh-g Nov 30, 2022 •

edited

Loading

esh-g commented Nov 30, 2022 •

edited

Loading