Allow uploading attachments of any file type #11313

youssef-lr · 2022-09-27T02:30:06Z

Details

Fixed Issues

$ #11189

Tests & QA

Must be tested with https://github.com/Expensify/Web-Expensify/pull/35274.

Test uploading of files that are outside of this list: jpg, jpeg, png, gif, pdf, html, txt, rtf, doc, docx, htm, tiff, tif, xml, mp3, mp4, mov
Test uploading a .heic image. (Google heic sample image)
Make sure files are uploaded properly.

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Screenshots

Web

Screen.Recording.2022-10-24.at.17.51.48.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

parasharrajat · 2022-10-24T17:40:48Z

Please let me know when ready for review. It seems you are still making changes.

youssef-lr · 2022-10-24T17:44:12Z

@parasharrajat this can only be tested internally, as it required a branch from a private repo to be checked out first.

parasharrajat · 2022-10-24T17:45:04Z

Ok. Can you please unassign me? Thanks.

jasperhuangg · 2022-10-24T20:04:56Z

Commented on the Web-E PR, tested and works well though!

jasperhuangg

@youssef-lr I'm approving but also putting this PR on HOLD for the Web-E one

jasperhuangg · 2022-10-24T20:06:48Z

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

jasperhuangg · 2022-10-26T00:21:17Z

Just merged and approved https://github.com/Expensify/Web-Expensify/pull/35274, once that's on prod will circle back here!

melvin-bot · 2022-11-01T20:30:45Z

@youssef-lr looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

youssef-lr · 2022-11-01T20:31:39Z

Checklists are OK.

OSBotify · 2022-11-01T20:36:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-02T20:21:27Z

🚀 Deployed to staging by @youssef-lr in version: 1.2.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Justicea83 · 2022-11-04T12:17:45Z

Desktop working as expected.

Justicea83 · 2022-11-04T12:21:10Z

Tested well on Web

Julesssss · 2022-11-04T12:44:14Z

This is not working on native apps. Myself and @Justicea83 see the same error when uploading from native Android and iOS. I was thinking about not reverting, but this current behaviour is worse than the current behaviour on prod -- which shows a nice error message (see below)

I'm going to revert this PR

Staging

Android

iOS

Production

Julesssss · 2022-11-04T12:45:51Z

Hey @jasperhuangg @youssef-lr it looks like this wasn't tested on Android or iOS, did we miss this? Or did we just forget to upload the screenshots?

youssef-lr · 2022-11-04T12:50:36Z

@Julesssss do you mind sending me the PDF file that's not working? I'm able to upload PDFs in IOS native.

Edit: Just saw that i's not a PDF document but the error says it's not a valid PDF.

Julesssss · 2022-11-04T13:02:19Z

Hey @youssef-lr , the issue occurs when uploading non-pdf files. We used a .heic image, but annoyingly Github doesn't accept it as a valid filetype 😆

I'll send it to you on NewDot

OSBotify · 2022-11-04T17:11:50Z

🚀 Deployed to production by @Julesssss in version: 1.2.23-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

youssef-lr added 3 commits September 27, 2022 03:29

Allow uploading attachments of any file type

bc25b95

Fix linting

2593644

Merge branch 'main' into youssef_upload_any_filetype

13995ad

youssef-lr marked this pull request as ready for review October 24, 2022 16:53

youssef-lr requested a review from a team as a code owner October 24, 2022 16:53

youssef-lr self-assigned this Oct 24, 2022

youssef-lr removed the request for review from a team October 24, 2022 16:53

melvin-bot bot requested review from eVoloshchak and jasperhuangg October 24, 2022 16:53

youssef-lr requested review from a team and removed request for eVoloshchak and jasperhuangg October 24, 2022 16:53

melvin-bot bot requested review from jasperhuangg and parasharrajat and removed request for a team October 24, 2022 16:54

jasperhuangg changed the title ~~Allow uploading attachments of any file type~~ [HOLD Web-Expensify#35274] Allow uploading attachments of any file type Oct 24, 2022

jasperhuangg approved these changes Oct 24, 2022

View reviewed changes

youssef-lr removed the request for review from parasharrajat October 26, 2022 14:34

JmillsExpensify mentioned this pull request Nov 1, 2022

[HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] [Feature] Support all file types for attachments #11189

Closed

youssef-lr changed the title ~~[HOLD Web-Expensify#35274] Allow uploading attachments of any file type~~ Allow uploading attachments of any file type Nov 1, 2022

youssef-lr merged commit c0aa086 into main Nov 1, 2022

youssef-lr deleted the youssef_upload_any_filetype branch November 1, 2022 20:30

melvin-bot bot added the Emergency label Nov 1, 2022

OSBotify mentioned this pull request Nov 2, 2022

Deploy Checklist: New Expensify 2022-11-02 #12397

Closed

44 tasks

kavimuru mentioned this pull request Nov 4, 2022

[HOLD #11189] Chat - Unable to upload all file types #12459

Closed

roryabraham removed the Emergency label Nov 4, 2022

Julesssss mentioned this pull request Nov 4, 2022

Revert PR 11313 #12466

Closed

youssef-lr mentioned this pull request Nov 4, 2022

Revert "Allow uploading attachments of any file type" #12467

Closed

Julesssss mentioned this pull request Nov 4, 2022

Revert PR11313 #12468

Merged

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow uploading attachments of any file type #11313

Allow uploading attachments of any file type #11313

youssef-lr commented Sep 27, 2022 •

edited

Loading

parasharrajat commented Oct 24, 2022 •

edited

Loading

youssef-lr commented Oct 24, 2022

parasharrajat commented Oct 24, 2022 •

edited

Loading

jasperhuangg commented Oct 24, 2022

jasperhuangg left a comment

jasperhuangg commented Oct 24, 2022

jasperhuangg commented Oct 26, 2022

melvin-bot bot commented Nov 1, 2022

youssef-lr commented Nov 1, 2022

OSBotify commented Nov 1, 2022

OSBotify commented Nov 2, 2022

Justicea83 commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Julesssss commented Nov 4, 2022

Julesssss commented Nov 4, 2022

youssef-lr commented Nov 4, 2022 •

edited

Loading

Julesssss commented Nov 4, 2022 •

edited

Loading

OSBotify commented Nov 4, 2022

Allow uploading attachments of any file type #11313

Allow uploading attachments of any file type #11313

Conversation

youssef-lr commented Sep 27, 2022 • edited Loading

Details

Fixed Issues

Tests & QA

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

parasharrajat commented Oct 24, 2022 • edited Loading

youssef-lr commented Oct 24, 2022

parasharrajat commented Oct 24, 2022 • edited Loading

jasperhuangg commented Oct 24, 2022

jasperhuangg left a comment

Choose a reason for hiding this comment

jasperhuangg commented Oct 24, 2022

jasperhuangg commented Oct 26, 2022

melvin-bot bot commented Nov 1, 2022

youssef-lr commented Nov 1, 2022

OSBotify commented Nov 1, 2022

OSBotify commented Nov 2, 2022

Justicea83 commented Nov 4, 2022

Justicea83 commented Nov 4, 2022

Julesssss commented Nov 4, 2022

Staging

Production

Julesssss commented Nov 4, 2022

youssef-lr commented Nov 4, 2022 • edited Loading

Julesssss commented Nov 4, 2022 • edited Loading

OSBotify commented Nov 4, 2022

youssef-lr commented Sep 27, 2022 •

edited

Loading

parasharrajat commented Oct 24, 2022 •

edited

Loading

parasharrajat commented Oct 24, 2022 •

edited

Loading

youssef-lr commented Nov 4, 2022 •

edited

Loading

Julesssss commented Nov 4, 2022 •

edited

Loading