Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Stg] Remove LayoutAnimation from KeyboardSpacer #10546

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Aug 24, 2022

Details

LayoutAnimation in KeyboardSpacer is clashing with the one from KeyboardAvoidingView

Fixed Issues

$ #10520 (comment)

Tests

  1. Create an account
  2. Add two payment methods
  3. Open Settings -> Payments
  4. Click on the non-default payment method.
  5. Press Make default
  6. Close the password form
  7. Go back to the Settings page.
  8. The Settings page should look normal.
  • Verify that no errors appear in the JS console

Screenshots

Android

Before:

BEFORE.mov

After:

AFTER.mov

@roryabraham roryabraham self-assigned this Aug 24, 2022
@roryabraham roryabraham requested a review from a team as a code owner August 24, 2022 19:11
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from johnmlee101 and removed request for a team August 24, 2022 19:11
@roryabraham roryabraham merged commit df44a2f into main Aug 24, 2022
@roryabraham roryabraham deleted the Rory-FixPaymentsPageBug branch August 24, 2022 19:23
OSBotify pushed a commit that referenced this pull request Aug 24, 2022
OSBotify added a commit that referenced this pull request Aug 24, 2022
@mvtglobally
Copy link

@roryabraham we are not seeing set a default button. Accounts are added from OldDot due to NewDot being behind PROD KYC wall. Should we log this as an issue or you can QA internally?

Recording.1620.mp4

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.89-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@mvtglobally
Copy link

We got it to work with Expensifail account, but now team is seeing a different error.

Recording.1622.mp4

@techievivek
Copy link
Contributor

@roryabraham Could this new issue of the keyboard automatically being dismissed when clicked on the eye icon could be related to this PR?

@dhairyasenjaliya
Copy link
Contributor

dhairyasenjaliya commented Aug 25, 2022

@techievivek currently keyboard space is only configured to the native platform so no changes into the web for this PR
also, I did take a quick look at that issue, it seems the issue is globally rather than the payments page

@roryabraham
Copy link
Contributor Author

@mvtglobally that new error is definitely unrelated to this PR

@Julesssss
Copy link
Contributor

Julesssss commented Aug 25, 2022

Confirmed fixed on Android v1.1.89-3

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants