-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Stg] Remove LayoutAnimation from KeyboardSpacer #10546
Conversation
|
(cherry picked from commit df44a2f)
…-10546 🍒 Cherry pick PR #10546 to staging 🍒
@roryabraham we are not seeing set a default button. Accounts are added from OldDot due to NewDot being behind PROD KYC wall. Should we log this as an issue or you can QA internally? Recording.1620.mp4 |
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.89-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
We got it to work with Expensifail account, but now team is seeing a different error. Recording.1622.mp4 |
@roryabraham Could this new issue of the keyboard automatically being dismissed when clicked on the eye icon could be related to this PR? |
@techievivek currently keyboard space is only configured to the native platform so no changes into the web for this PR |
@mvtglobally that new error is definitely unrelated to this PR |
Confirmed fixed on Android |
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
LayoutAnimation in KeyboardSpacer is clashing with the one from KeyboardAvoidingView
Fixed Issues
$ #10520 (comment)
Tests
Settings
->Payments
Make default
Screenshots
Android
Before:
BEFORE.mov
After:
AFTER.mov