Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Not auto scrolled when send another chat after reload from last chat #55780

Closed
1 of 8 tasks
m-natarajan opened this issue Jan 27, 2025 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jan 27, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.89-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @wildan-m
Slack conversation (hyperlinked to channel name): open_source

Action Performed:

  1. Copy link to the last chat
  2. Paste link in browser tab
  3. Send new message

Expected Result:

Message auto scrolled to last message

Actual Result:

Not auto scrolled when send another chat after reload from last chat
Note: This could be because of the PR as per the slack chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Kapture.2025-01-24.at.09.53.27.mp4
Recording.928.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify
@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 27, 2025
Copy link

melvin-bot bot commented Jan 27, 2025

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 27, 2025

Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 27, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 27, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@amyevans
Copy link
Contributor

I can reproduce. Looks like it's coming from this PR: #54071

IMO the behavior here is worse than the behavior it was intending to correct, so I'm inclined to revert the PR, especially since I think we are nearing being ready for a deploy otherwise.

cc @rinej @hoangzinh

@amyevans
Copy link
Contributor

Following the convo on #55693 though, maybe we can fix it with a CP

@mountiny
Copy link
Contributor

@amyevans we are very close to deploy, so I think if you confirmed the revert fixes it, we could go with that 🙌

@hoangzinh
Copy link
Contributor

Revert the PR seems to fix this issue

Screen.Recording.2025-01-27.at.22.09.21.mov

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Jan 27, 2025
@amyevans
Copy link
Contributor

Revert PR is here: #55790

There was a small merge conflict though so I'd just like to be cautious with testing

@amyevans
Copy link
Contributor

Retested on staging web and looked good so I'll close this out

@amyevans amyevans removed the DeployBlockerCash This issue or pull request should block deployment label Jan 27, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 28, 2025
@melvin-bot melvin-bot bot changed the title Not auto scrolled when send another chat after reload from last chat [HOLD for payment 2025-02-04] Not auto scrolled when send another chat after reload from last chat Jan 28, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 28, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

  • @wildan-m requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jan 28, 2025

@amyevans @jliexpensify @amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@jliexpensify
Copy link
Contributor

@wildan-m to confirm, do you require payment for this issue? I don't see you assigned so I'm assuming this is incorrect.

@wildan-m
Copy link
Contributor

@jliexpensify I just reported it without completing any work.

@jliexpensify
Copy link
Contributor

Cool, thanks for clarifying - I thought so! Since we don't pay for reporting bonuses anymore, there's no payment needed here.

@wildan-m
Copy link
Contributor

@jliexpensify what about identifying the offending PR? just want to confirm 😸

@jliexpensify
Copy link
Contributor

I am pretty sure we don't pay for this but am asking here!

@jliexpensify
Copy link
Contributor

@wildan-m just got confirmation that we don't pay for any sort of reporting/identification - sorry!

@wildan-m
Copy link
Contributor

@jliexpensify Thank you for clarifying, I appreciate it.

@jliexpensify
Copy link
Contributor

No worries, and sorry again!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 29, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-04] Not auto scrolled when send another chat after reload from last chat [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Not auto scrolled when send another chat after reload from last chat Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @wildan-m requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Jan 29, 2025

@amyevans @jliexpensify @amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants