-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Not auto scrolled when send another chat after reload from last chat #55780
Comments
Triggered auto assignment to @jliexpensify ( |
Triggered auto assignment to @amyevans ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
I can reproduce. Looks like it's coming from this PR: #54071 IMO the behavior here is worse than the behavior it was intending to correct, so I'm inclined to revert the PR, especially since I think we are nearing being ready for a deploy otherwise. cc @rinej @hoangzinh |
Following the convo on #55693 though, maybe we can fix it with a CP |
@amyevans we are very close to deploy, so I think if you confirmed the revert fixes it, we could go with that 🙌 |
Revert the PR seems to fix this issue Screen.Recording.2025-01-27.at.22.09.21.mov |
Revert PR is here: #55790 There was a small merge conflict though so I'd just like to be cautious with testing |
Retested on staging web and looked good so I'll close this out |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-04. 🎊 For reference, here are some details about the assignees on this issue:
|
@amyevans @jliexpensify @amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@jliexpensify I just reported it without completing any work. |
Cool, thanks for clarifying - I thought so! Since we don't pay for reporting bonuses anymore, there's no payment needed here. |
@jliexpensify what about identifying the offending PR? just want to confirm 😸 |
I am pretty sure we don't pay for this but am asking here! |
@wildan-m just got confirmation that we don't pay for any sort of reporting/identification - sorry! |
@jliexpensify Thank you for clarifying, I appreciate it. |
No worries, and sorry again! |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-02-05. 🎊 For reference, here are some details about the assignees on this issue:
|
@amyevans @jliexpensify @amyevans The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.89-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @wildan-m
Slack conversation (hyperlinked to channel name): open_source
Action Performed:
Expected Result:
Message auto scrolled to last message
Actual Result:
Not auto scrolled when send another chat after reload from last chat
Note: This could be because of the PR as per the slack chat
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Kapture.2025-01-24.at.09.53.27.mp4
Recording.928.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @jliexpensifyThe text was updated successfully, but these errors were encountered: