[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Desktop - App auto relogins after signing out

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Other

Action Performed:

1. Launch New Expensify desktop app.
2. Log out if logged in.
3. Log in to New Expensify on Chrome.
4. After login, refresh the page on Chrome.
   5.Click Open New Expensify.
5. On desktop app, sign out.

Expected Result:

App will open login page after sign out.

Actual Result:

App auto relogins with the same account and user cannot sign out.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6722224_1737670524844.20250124_061149.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021883976990346427036
• Upwork Job ID: 1883976990346427036
• Last Price Increase: 2025-01-27

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[AndrewGable]

Not seeing any recent PRs or commits that stick out for the sign out button

[AndrewGable]

@mitarachim - If you do not click "Open In New Expensify", what link does it bring you to?

[AndrewGable]

Hmm I am having a hard time reproducing this, can you try @isabelastisser ?

Google.Chrome.2025-01-24.at.11.35.22.mp4

[mountiny]

Asked QA to check this https://expensify.slack.com/archives/C9YU7BX5M/p1737978192639509?thread_ts=1737977508.343799&cid=C9YU7BX5M

[izarutskaya]

Issue is still reproducible

-8214185883373436546v9.0.89-5.mp4

[AndrewGable]

Ok I can reproduce now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021883976990346427036

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[AndrewGable]

@yuwenmemon bisected this to

dea4b7cae217fad607b00d6963ad43fd659c625e is the first bad commit
commit dea4b7cae217fad607b00d6963ad43fd659c625e
Author: Wojciech Boman <[email protected]>
Date:   Tue Jan 21 14:49:22 2025 +0100

    Add hooks for lastOpenedPublicRoomID and initialLastUpdateIDAppliedToClient in AuthScreens

 src/libs/Navigation/AppNavigator/AuthScreens.tsx | 56 ++++++++++++++++--------
 1 file changed, 38 insertions(+), 18 deletions(-)

From this PR: #55528

I am working on the revert now.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Merge pull request #55528 from software-mansion-labs/use-onyx/auth-screens #55815

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment through NewDot Manual Requests

[melvin-bot]

@ahmedGaber93 @isabelastisser @ahmedGaber93 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[isabelastisser]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Merge pull request #55528 from software-mansion-labs/use-onyx/auth-screens #55815

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment through NewDot Manual Requests

[melvin-bot]

@ahmedGaber93 @isabelastisser @ahmedGaber93 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @ahmedGaber93 owed $250 via NewDot

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1883976990346427036/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

@AndrewGable, can you confirm if @ahmedGaber93 needs payment here? I reviewed the issue, and it looks like you and Yuwen worked on the PR without an external contributor.

[ahmedGaber93]

@isabelastisser No payment for me here, It just a revert PR that doesn't require C+ review. And I think the new PR #55966 that re-applying the revert should be handed by the original issue #49103

[isabelastisser]

Thanks for the context, @ahmedGaber93! Closing this.