[HOLD for payment 2025-02-06] [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$100] Migrate AuthScreens to useOnyx

[roryabraham]

Currently Held on #51942

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1725973460005309?thread_ts=1725905735.105989&cid=C01GTK53T8Q

Migrate src/libs/Navigation/AppNavigator/AuthScreens.tsx to use useOnyx instead of withOnyx.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834281376353079480
• Upwork Job ID: 1834281376353079480
• Last Price Increase: 2024-09-12
• Automatic offers:
• c3024 | Reviewer | 103949192
• BhuvaneshPatil | Contributor | 103949194

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834281376353079480

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Upwork job price has been updated to $100

[BhuvaneshPatil]

Dibs

[BhuvaneshPatil]

Do we need to submit proposal?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate AuthScreens to useOnyx

What is the root cause of that problem?

This is an improvement

What changes do you think we should make in order to solve the problem?

Remove the withOnyx here and use useOnyx hook. Also remove the type props here

const [session] = useOnyx(ONYXKEYS.SESSION);
const [lastOpenedPublicRoomID] = useOnyx(ONYXKEYS.LAST_OPENED_PUBLIC_ROOM_ID);
const [initialLastUpdateIDAppliedToClient] = useOnyx(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT);

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Line 570 in 7748eff

export default withOnyx<AuthScreensProps, AuthScreensProps>({

What alternative solutions did you explore? (Optional)

[zanyrenney]

@roryabraham @c3024 want to take a look at the proposals here please?

[c3024]

It is a simple enough task. I think it is fine to give it to @BhuvaneshPatil if he has not been assigned any other useOnyx migration. Otherwise @nkdengineer can be assigned.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[BhuvaneshPatil]

Thanks @c3024 ,
I am not assigned to any migration task

[roryabraham]

Both @BhuvaneshPatil and @nkdengineer are now assigned to one other migration each, so I'm going to treat this one on a first-come-first-serve and give it to @BhuvaneshPatil

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @BhuvaneshPatil 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[BhuvaneshPatil]

@c3024 Raised the PR

• chore: migrate AuthScreens from withOnyx to useOnyx #49185

[melvin-bot]

@BhuvaneshPatil, @roryabraham, @zanyrenney, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

assigning this issue to @deetergp since he's been reviewing the PR(s)

[roryabraham]

latest PR was merged then reverted just a few minutes ago

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate AuthScreens to useOnyx #55528

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @BhuvaneshPatil requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

@c3024 @zanyrenney @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[deetergp]

Melvin is incorrect as the last PR for this has been reverted, so it is not ready for payment.

@blazejkustra @WojtekBoman @c3024 Do we have a plan for re-implementing this without causing a regression?

[blazejkustra]

I think @WojtekBoman is working on a fix, hopefully he will leave an update tomorrow 🙌

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate AuthScreens to useOnyx #55528

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

• @BhuvaneshPatil requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

@c3024 @zanyrenney @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[WojtekBoman]

Melvin is incorrect as the last PR for this has been reverted, so it is not ready for payment.

@blazejkustra @WojtekBoman @c3024 Do we have a plan for re-implementing this without causing a regression?

I created a draft PR fixing this issue. It seems to work fine, but I know there are more sign in flows that should be checked thoroughly before I make it ready for review. Can we trigger builds for this PR and ask QA testers to check it?

Screen.Recording.2025-01-29.at.17.16.54.mov

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate AuthScreens to useOnyx #55528

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

• @BhuvaneshPatil requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

@c3024 @zanyrenney @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[zanyrenney]

tomorrow!

@c3024 please complete the checklist.

[c3024]

@zanyrenney

The PR was reverted. A new PR #55966 is under works.