Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace chat - There is no Track expense option in the workspace chat. #55673

Closed
4 of 8 tasks
IuliiaHerets opened this issue Jan 23, 2025 · 5 comments
Closed
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 23, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #54534
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Other

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Create a workspace
  3. Go to the workspace chat
  4. Click on the plus button in the compose box

Expected Result:

There should be a Track expense option when clicking the plus button in the compose box of the workspace chat.

Actual Result:

There is no Track Expense option when clicking the plus button in the compose box.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6722173_1737666678910.bandicam_2025-01-23_23-16-42-849.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @grgia
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@FitseTLT
Copy link
Contributor

@grgia So what was the plan to replace track expense for workspace? I think your input is needed for this issue. Thx

@maddylewis
Copy link
Contributor

@grgia - just assigning you temporarily to address @FitseTLT's question here - #55673 (comment)

if this can be assigned to someone else or worked on a contributor, let me know and I'll do the things 👍

@grgia
Copy link
Contributor

grgia commented Jan 24, 2025

NAB, this is intended. Closing

@grgia grgia closed this as completed Jan 24, 2025
@FitseTLT
Copy link
Contributor

In that case @grgia we need to clean up these lines of code

[CONST.IOU.TYPE.TRACK]: {
icon: getIconForAction(CONST.IOU.TYPE.CREATE),
text: translate('iou.createExpense'),
onSelected: () => selectOption(() => startMoneyRequest(CONST.IOU.TYPE.TRACK, report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)), true),
},

as they are duplicate with this one
[CONST.IOU.TYPE.SUBMIT]: {
icon: getIconForAction(CONST.IOU.TYPE.CREATE),
text: translate('iou.createExpense'),
onSelected: () => selectOption(() => startMoneyRequest(CONST.IOU.TYPE.SUBMIT, report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID)), true),
},

they were only needed for the case we allowed track menu for workspaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants