[HOLD for payment 2025-02-04]App Crash at Start of Session for New User – JavaScript Errors Observed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): quality

Action Performed:

1. Go to expensify.com
2. Choose 1-10 company
3. Add email and sign in

Expected Result:

The app should initialize smoothly for new users without any crashes or critical errors.

Actual Result:

The app crashes at the start of the session

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

[Onyx] Warning: Trying to apply "merge" with array type to non-array type in the key "nvp_private_blockedFromConcierge"
[Onyx] Warning: Trying to apply "merge" with array type to non-array type in the key "private_personalDetails"
"Error: 'report_153180287332610' key can't be changed to 'report_'. useOnyx() only supports dynamic keys if they are both collection member keys from the same collection e.g. from 'collection_id1' to 'collection_id2'.,Error: 'report_153180287332610' key can't be changed to 'report_'. useOnyx() only supports dynamic keys if they are both collection member keys from the same collection e.g. from 'collection_id1' to 'collection_id2'.\n at https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2969363/n at rs (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2860051)/n at Bl (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2879996)/n at https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2878773/n at yl (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2878833)/n at sl (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2872649)/n at Hi (https://new.expensify.com/vendo..."
"Error: 'report_153180287332610' key can't be changed to 'report_'. useOnyx() only supports dynamic keys if they are both collection member keys from the same collection e.g. from 'collection_id1' to 'collection_id2'.,Error: 'report_153180287332610' key can't be changed to 'report_'. useOnyx() only supports dynamic keys if they are both collection member keys from the same collection e.g. from 'collection_id1' to 'collection_id2'.\n at https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2969363/n at rs (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2860051)/n at Bl (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2879996)/n at https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2878773/n at yl (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2878833)/n at sl (https://new.expensify.com/vendors-c5d98afe914055e55e41.bundle.js:2:2872649)/n at Hi (https://new.expensify.com/vendo..."

Full story Link

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @thienlnam

[melvin-bot]

Triggered auto assignment to @thienlnam (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[puneetlath]

@mountiny @VickyStash and @fabioh8010 have been discussing the solution to this in Slack.

[mountiny]

@VickyStash did you manage to find any spot where the report key might be wrong?

[VickyStash]

@VickyStash did you manage to find any spot where the report key might be wrong?

Unfortunately, no luck.
I have some capacity today, so I can take another look. Maybe I'll be able to find the spot or at least several potential places where something could go wrong.

[VickyStash]

I still haven't defined any specific spot, but here is the sum up of what we have as for now:

1. The crash was caused by Error: 'report_153180287332610' key can't be changed to 'report_'. useOnyx() only supports dynamic keys if they are both collection member keys from the same collection e.g. from 'collection_id1' to 'collection_id2'. This is a standard error triggered inside useOnyx hook in case the key passed to the hook was dynamically changed from item to collection key. 153180287332610 - Concierge report ID.

2. That means, that during data loading the valid repordID disappears. According to fullstory, it can be something received from GetMissingOnyxMessages. The thing is that even if we add a check to escape a crash due to the useOnyx error, we still potentially have invalid data.

3. My flow in the app, even on the prod, is a little bit different than the reporter had. For example - after setup, the list of important tasks to help get your team’s expenses under control is posted inside Concierge chat for me. For the user, reported the bug it was inside #admins chat. Is it possible for me to have a similar setup as the user had?

[mountiny]

For 3 - you need to use email without + in it. If you add + its going to concierge and not to admins as its testing email most likely (we might remove this fork, but its there now)

[melvin-bot]

@thienlnam, @michaelkwardrop Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[VickyStash]

For 3 - you need to use email without + in it. If you add + its going to concierge and not to admins as its testing email most likely (we might remove this fork, but its there now)

That truly helped to follow the correct flow, thank you! But still, I havent' found any issues during the testing.

Maybe we can take a step back, and try to know why empty array values were pushed to the user (nvp_private_blockedFromConcierge and private_personalDetails ) and why it's not when I do testing on my side.

I see there was a discussion in the slack in November and even a fix PR was merged by you @mountiny, but it looks like it's still there, do you have an idea why?
Note: when I test from my end, for me it returns as {}, which is not causing any errors.
Maybe if we know the difference we will get a step closer to the solution.

It looks like for the user the crash was potentially caused by the results of GetMissingOnyxMessages, overall it's strange that it was triggered in the start of the session. @mountiny is there a chance to know what was returned to the user with this call?

[VickyStash]

Today I've investigated all of the potential places that could lead to the crash on the app side in the mentioned flow.

I've defined two spots.

1. ReportActionItemMessage

It calls useOnyx hook with reportID property.

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 40 in 55decc7

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

reportID is passed from PureReportActionItem, where it's defined as

App/src/pages/home/report/PureReportActionItem.tsx

Line 299 in 55decc7

const reportID = report?.reportID ?? '';

Which potentially can cause the crash.

2. ReportActionItemCreated

It calls useOnyx hook with reportID property.

App/src/pages/home/report/ReportActionItemCreated.tsx

Line 32 in 55decc7

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

reportID is passed from ReportActionItemContentCreated

App/src/pages/home/report/ReportActionItemContentCreated.tsx

Line 190 in 55decc7

reportID={report.reportID}

to ReportActionItemContentCreated it's passed from PureReportActionItem, where the defaulting value is empty string

App/src/pages/home/report/PureReportActionItem.tsx

Line 510 in 55decc7

report: {...report, reportID: report?.reportID ?? ''},

Which potentially can cause the crash.

---

So both cases are related to the PureReportActionItem component, which defaults reportIDs to the empty strings and that can cause the crash.
But it should be updated as part of the defaulting IDs issue. @kubabutkiewicz has already started to work on this file!

[VickyStash]

I'm going to be OOO Jan 22 - 26 ❄️

[mountiny]

Thank you! The array was fixed in the flows at the time hut seems like its coming from somewhere else now, going to try to poke around to see if anyone can help us identify the flow this stems from. Its hard without reproduction steps

@kubabutkiewicz can you please prioritize fixing the places @VickyStash found that might cause this crash?

[kubabutkiewicz]

@mountiny Yes sure, I am currently testing changes so PR will be available to check soon!

[michaelkwardrop]

Let me know if I can do anything useful wrt reproduction, but it seems like y'all got it.

[melvin-bot]

@thienlnam, @michaelkwardrop Eep! 4 days overdue now. Issues have feelings too...

[mountiny]

@kubabutkiewicz how is it looking?

[VickyStash]

The PR with PureReportActionItem component updates is prepared for the final review, it looks like it should be merged really soon.

[kubabutkiewicz]

@mountiny @VickyStash the PR was just merged 😄

[melvin-bot]

@thienlnam, @michaelkwardrop Still overdue 6 days?! Let's take care of this!

[thienlnam]

Should be on production, pending 7 day regression for C+ payment

[melvin-bot]

@thienlnam @michaelkwardrop this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[michaelkwardrop]

@thienlnam who is the C+ that needs payment here?

[thienlnam]

@paultsimura for reviewing this PR, doesn't look like the automation worked here so I'll update it manually

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@thienlnam, @michaelkwardrop Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[paultsimura]

Payment "summary": #55357 (comment)

[michaelkwardrop]

Contributor+: @paultsimura  paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/106011831)

@paultsimura do we need a regression test for this?

[paultsimura]

Thanks @michaelkwardrop.
IMO we don't need a regression test here - the issue was caused by incorrect defaulting of the report IDs. We've removed the defaulting and now it's covered by an ESlint rule, so this shouldn't happen again.

[michaelkwardrop]

Paid, contract completed, job posted removed! Closing this out ✅