Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create expense - "Just track it (Don't submit it)" row is still shown in Create expense flow #54953

Closed
2 of 8 tasks
izarutskaya opened this issue Jan 8, 2025 · 10 comments
Closed
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53760
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sonoma 14.4.1
App Component: Chat Report View

Action Performed:

  1. Open the New expensify app
  2. Log into the app
  3. Click on the + button
  4. Select the Create expense option
  5. Choose the Manual expense
  6. Provide an expense value
  7. Navigate to the next step
  8. Make sure the Just track it (don't submit it) option row is not visible

Expected Result:

User expects not to see Just track it (Don't submit it) option

Actual Result:

Just track it (Don't submit it) option is shown

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6708738_1736309224876.PR_53760_Desktop.mp4

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@trjExpensify
Copy link
Contributor

@grgia @JKobrynski isn't this because we reverted the PR?

Copy link

melvin-bot bot commented Jan 14, 2025

@abekkala Eep! 4 days overdue now. Issues have feelings too...

@abekkala
Copy link
Contributor

@grgia @JKobrynski can you confirm? #54953 (comment)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 14, 2025
Copy link

melvin-bot bot commented Jan 20, 2025

@abekkala Huh... This is 4 days overdue. Who can take care of this?

@abekkala
Copy link
Contributor

checking with @grgia

@melvin-bot melvin-bot bot removed the Overdue label Jan 21, 2025
@grgia
Copy link
Contributor

grgia commented Jan 21, 2025

I'm pretty sure this was fixed. We can retest after #55016 hits staging

cc @JKobrynski

@grgia grgia self-assigned this Jan 21, 2025
Copy link

melvin-bot bot commented Jan 22, 2025

@abekkala @grgia this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@abekkala
Copy link
Contributor

note: not merged to staging yet.
keeping an eye then we can retest

@grgia
Copy link
Contributor

grgia commented Jan 24, 2025

Closing out, this isnt a bug

@grgia grgia closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants