[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [HOLD for payment 2025-01-15] [$500] We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over

[danielrvidal]

1. [email protected] started out as an Expensify Classic user
2. @puneetlath migrated the user
3. [email protected] signed into Expensify using HybridApp after migration
4. We load the correct "Travel and expense, at the speed of chat" modal - but you can hear the music start from the "Welcome to Expensify" modal/video in the background
5. When I click Let's go! the "Welcome to Expensify" modal loads. You can also see the background show "Hmm... it's not here"
6. Both the "Welcome to Expensify" modal should not load and the "Hmm... it's not here" should not show up. The reports page should be in the background so after I click Let's go it should take me to the reports page.

We're looking to have this fixed immediately so I'll ask someone from C+ to pick

Here is a video highlighting this:
https://github.com/user-attachments/assets/6ac89f14-ce77-48d5-a704-01071af27bf3

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[rayane-d]

PR merged 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over #54921

If no regressions arise, payment will be issued on 2025-01-15. 🎊

For reference, here are some details about the assignees on this issue:

• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

@sobitneupane @Christinadobrzyn @sobitneupane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[danielrvidal]

Hey team, it looks like the fix is still producing an issue. I put this in the thread but here are the steps:

1. I logged in using [email protected] and everything seemed to be working.

• I was on the latest hybridapp version v9.0.81-6

2. You can see me get through the “Let’s go” screen.
3. But then you can see me click into an expense at 0:52 and the app freezes.
4. I can’t get it to respond so I close it so I can open it again, thinking it’s likely just a normal bug.
5. The video ends because I think I closed my phone screen.

• When I logged back in, I saw the screenshot which shows the welcome screen is still in the flow.

ScreenRecording_01-07-2025.19-14-33_1.MP4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: We're playing and showing the "Welcome to Expensify" modal/video when newly migrated users come over #54921
• Get nudgeMigration timestamp from OldDot transition url #54972
• Fix: "Travel and expense" modal not showing for migrated users #55005

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

@allroundexperts / @rayane-djouah @Christinadobrzyn @allroundexperts / @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Get nudgeMigration timestamp from OldDot transition url #54972
• Fix: "Travel and expense" modal not showing for migrated users #55005

If no regressions arise, payment will be issued on 2025-01-18. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

@allroundexperts / @rayane-djouah @Christinadobrzyn @allroundexperts / @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Christinadobrzyn]

It looks like the payment date has been moved to Jan 18th.

It looks like there was a deploy blocker associated with this GH but I don't think that affects the price, correct?

Contributor: @rayane-djouah paid $500 via NewDot
Contributor+: @allroundexperts owed $500 via NewDot

[rayane-d]

It looks like there was a deploy blocker associated with this GH but I don't think that affects the price, correct?

Correct. @allroundexperts and I resolved the bug on staging with a follow-up PR

[rayane-d]

@Christinadobrzyn My eligibility for NewDot payments began on December 28th, and I was assigned to this GitHub issue on January 8th. I will request payment via NewDot once the onboarding process is completed.

[Christinadobrzyn]

ah thanks @rayane-djouah - sounds good! We have a few more day until payday.

[Christinadobrzyn]

waiting for payday - I'll keep this daily since it's close

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot (50% reduction due to regression)
• Reviewer: @rayane-djouah owed $250 via NewDot (50% reduction due to regression)

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Payday is here! Payment summary - #54915 (comment)

Ah wait, do we need a regression test @allroundexperts?

[rayane-d]

Regression Test Proposal

### Test 1 (Migrated account):

#### Precondition:
You need an account that is opened from oldot and which has some expenses:
1. Sign in to a new account on OldDot web (expensify.com).
2. Logout
3. Sign in again in the same account to validate it with a magic code
4. Create a workspace.
5. Create a report with expenses and submit it.
6. run this script in browse's console to to directly open New Expensify on signin and to migrate the account:

```
NVP.set('tryNewDot', {classicRedirect: {dismissed: false, completedHybridAppOnboarding: false}, nudgeMigration: {timestamp: '2024-01-07'}});
```

#### Test Steps:

1. Sign in to the same account on Oldot/HybridApp.
2. New Expensify will open
3. Verify that the "Welcome to Expensify" modal does not appear.
4. Confirm that the "Travel and expense, at the speed of chat" modal is displayed.
5. Ensure that there is no music playing.
6. Click "Let's go!" and verify:
- The "Welcome to Expensify" modal does not load.
- The "Hmm... it's not here" modal does not appear.
- The search page is displayed in the background and clicking "Let's go!" redirects you to the search page. 
7. Open the expenses.
8. Verify that you can open expenses and interact with the app without freezing or crashing.
9. Close the app and reopen it.
10. Verify that neither the "Welcome to Expensify" modal nor the "Travel and expense, at the speed of chat" modal appear.
11. Log out and log in again.
12. Verify that neither the "Welcome to Expensify" modal nor the "Travel and expense, at the speed of chat" modal appear.

### Test 2 (Unmigrated account):

#### Precondition:
You need an account that is opened from oldot and which has some expenses:
1. Sign in to a new account on OldDot web (expensify.com).
2. Logout
3. Sign in again in the same account to validate it with a magic code
4. Create a workspace.
5. Create a report with expenses and submit it.
6. run this script in browse's console to to directly open New Expensify on signin:

```
NVP.set('tryNewDot', {classicRedirect: {dismissed: false, completedHybridAppOnboarding: false}});
```

#### Test Steps:

1. Sign in to the same account on Oldot/HybridApp.
2. New Expensify will open
3. Verify that the "Welcome to Expensify" modal appears.
4. Confirm that the "Travel and expense, at the speed of chat" modal does not appear.
5. Click "Get Started!" and verify that the "Welcome to Expensify" modal disappears.

Do we agree 👍 or 👎

[rayane-d]

@Christinadobrzyn - @allroundexperts and I resolved the bug on staging with a follow-up PR. Therefore, I believe no regression penalty is applicable here, and we can close #55021 without payment.
The payment for this issue is $500.

[Christinadobrzyn]

Oh awesome, this makes sense, thanks @rayane-djouah!

Regression test here - https://github.com/Expensify/Expensify/issues/463325

I updated the payment summary based on the above comment.

[Christinadobrzyn]

Hey @rayane-djouah - The regression penalty still applies here, I was incorrect. This is not accurate - #54915 (comment)

Our rules are

If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

• payments will be issued 7 days after all regressions are fixed (ie: deployed to production)

• a 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue

So I'm going to add that 50% reduction for this issue to the payment section.

[puneetlath]

@Christinadobrzyn I don't think we should add the penalty here. I was pushing hard to get these PRs out and cherry picked, so we didn't take as long on testing/QA as normal. That's on me more than the contributors, so I don't think we should penalize them for it.

[garrettmknight]

$500 approved for @rayane-djouah