[HOLD for payment 2025-01-22] [$250] System message is shown in English

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.77-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Change the app language to Spanish
2. Create a new workspace
3. Go to more features -> enable Company Card
4. Upgrade this workspace to the Control Plan
5. Go to workspace admin room
6. Observe system messages

Expected Result:

System message is shown in Spanish

Actual Result:

System message is shown in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bug-resize.mp4

Recording.861.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021875253474674806164
• Upwork Job ID: 1875253474674806164
• Last Price Increase: 2025-01-03
• Automatic offers:
• nkdengineer | Contributor | 105614575

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2025-01-06 08:52:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message is shown in English

What is the root cause of that problem?

When we upgrade the workspace to the control plan, we don't add any report action to keep track of the change

What changes do you think we should make in order to solve the problem?

BE return action name is POLICYCHANGELOG_CORPORATE_UPGRADE

1. Create a new translation key for this action
2. Create a util function in ReportUtils like getCorporateUpgradeMessage and return translation
3. Use this function in some places below like we did with other actions

• Add a case for this action here for the alternative text in LHN

• Add a case in ReportActionItem here for the action in ReportScreen

• Add a case in here for the copy message

Note: we have a similar feature here is downgrade workspace we also need update system message

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

@zanyrenney I have the prior context on this bug so I can help take it as C+

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-20 14:04:17 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message is shown in English

What is the root cause of that problem?

We are not specially handling POLICYCHANGELOG_CORPORATE_UPGRADE type report action to provide translations so we are displaying the reportAction.message the BE returns

What changes do you think we should make in order to solve the problem?

We should add a translation to handle translation for POLICYCHANGELOG_CORPORATE_UPGRADE action types more of similar to CONST.REPORT.ACTIONS.TYPE.REJECTED and create a util that returns the translation like here
And then we should use this translation for:

1. For the alternative text in LHN here

2. Handle the case in PureReportActionItem here to display it

3. Handle the case in getReportName for chat thread header title here to align the thread header title with the report action content we are displaying in PureReportActionItem.

4. And finally in here for copy to clipboard

Note: On the PR phase we can also consider other related report actions like POLICYCHANGELOG_TEAM_DOWNGRADE too
We can also consider translating the Congrats ... whisper message too. Although it is ADDCOMMENT report action we can identify it via actorAccountID, whisperTo, and content of the message and display the translated copy instead 👍

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[zanyrenney]

Nice find, thanks!

[melvin-bot]

@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@zanyrenney Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@zanyrenney Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@zanyrenney 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@zanyrenney this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@zanyrenney 12 days overdue now... This issue's end is nigh!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021875253474674806164

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[zanyrenney]

thanks @dukenv0307

[dukenv0307]

Reviewing...

[nkdengineer]

updated proposal to add similar case

[FitseTLT]

Added Notes to handle a related POLICYCHANGELOG_TEAM_DOWNGRADE report actions on the PR phase which was recently added in ND in here after this issue was created.

[dukenv0307]

Thanks for all your proposals.

I think we should go with @nkdengineer's proposal since it's the first and addresses more cases.

🎀👀🎀 C+ reviewed

[FitseTLT]

Thanks for all your proposals.

I think we should go with @nkdengineer's proposal since it's the first and addresses more cases.

🎀👀🎀 C+ reviewed

@dukenv0307 The selected solution misses the getReportName case which would create a regression because the report action would be displayed translated but the thread header title untranslated. It is an important point missed.
cc @luacmartins

[luacmartins]

@dukenv0307 thoughts on the comment above?

[dukenv0307]

@luacmartins @FitseTLT I don't think getReportName really matters, I prefer the proposal because:

1. It's the first proposal to point out the correct idea and places to fix. For the case getReportName, we can address it in PR phase since it's not too hard to figure out
2. It fixes 1 more place that is related to this issue.

[FitseTLT]

1. It's the first proposal to point out the correct idea and places to fix. For the case getReportName, we can address it in PR phase since it's not too hard to figure out

I don't agree @dukenv0307 Here are some issues #37292 ,#34989, which can serve as a practical example, where we fixed regressions caused by missing translations in copy to clipboard just similar to points missed by the first proposal so there is no guarantee that it could easily be caught on PR phase.

2.It fixes 1 more place that is related to this issue.

The other point you are mentioning is in fact is not directly related to the issue in the OP and the feature of downgrading in ND is only introduced recently compared to the current issue and cannot be a main point to choose a proposal on this issue so I think that should be a point to be addressed in the PR phase.

cc @luacmartins

[dukenv0307]

@luacmartins What do you think?

[luacmartins]

The proposals are almost identical, the only difference is one place that needs to be updated. Given that, I think we should just go with the 1st proposal considering this part of the contributing guidelines given the difference is pretty small:

Note: Before submitting a proposal on an issue, be sure to read any other existing proposals. ALL NEW PROPOSALS MUST BE DIFFERENT FROM EXISTING PROPOSALS. The difference should be important, meaningful or considerable.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: System message is shown in English #54987

If no regressions arise, payment will be issued on 2025-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)
• @dukenv0307 requires payment through NewDot Manual Requests

[melvin-bot]

@dukenv0307 @zanyrenney @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/43822/files#r1917602936

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Change the app language to Spanish
2. Create a new workspace
3. Go to more features -> enable Company Card
4. Upgrade this workspace to the Control Plan
5. Go to workspace profile -> Downgrade this workspace
6. Go to workspace admin room
7. Observe system messages
8. Verify that: System message is shown in Spanish

Do we agree 👍 or 👎

[zanyrenney]

https://github.com/Expensify/Expensify/issues/463464

[zanyrenney]

Payment summary

@dukenv0307 requires payment through NewDot Manual Requests - please request $250 via ND requests.
@nkdengineer requires payment automatic offer (Contributor) - paid $250 via upwork.