[$250] Android - LHN flickers when scrolled down and switching between Search and Inbox #53605

lanitochka17 · 2024-12-04T21:24:20Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.71-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Launch ND or hybrid app
Scroll down LHN list
Tap Search
Tap Inbox

Expected Result:

LHN will not flicker when scrolled down and switching between Search and Inbox

Actual Result:

LHN flickers when scrolled down and switching between Search and Inbox

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6684654_1733343491984.Screen_Recording_20241205_041553_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021867321297737486613
Upwork Job ID: 1867321297737486613
Last Price Increase: 2025-01-09

Issue Owner

Current Issue Owner: @hungvu193

melvin-bot · 2024-12-04T21:24:30Z

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

truph01 · 2024-12-05T10:22:48Z

🚨 Edited by proposal-police: This proposal was edited at 2025-01-20 02:48:25 UTC.

🚨 Edited by proposal-police: This proposal was edited at 2024-12-27 11:25:11 UTC.

Edited by proposal-police: This proposal was edited at 2024-12-27 11:25:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN flickers when scrolled down and switching between Search and Inbox

What is the root cause of that problem?

We have logic to scroll to the previous scroll position in:

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 254 in 0ff0cdf

flashListRef.current.scrollToOffset({offset});

With a large list, during rapid scrolling, FlashList may encounter situations where it needs to render multiple items simultaneously to keep up with the fast-changing offsets, which can result in temporary blank spaces being visible.
As a result, we can see the LHN flickers when going back from inbox.

What changes do you think we should make in order to solve the problem?

When on the sidebar screen, store the index of the first visible item as firstVisibleItemIndex. If the user navigates to another screen and then returns to the sidebar, display a skeleton loader if the item corresponding to firstVisibleItemIndex has not been rendered. Detailed steps are provided below:

1. Store the index of the currently first visible item

In ScrollOffsetContextProvider, export two functions:

    // Saves the scroll offset of the first visible item for the given route.
    saveFirstVisibleIndex: (route: PlatformStackRouteProp<ParamListBase>, scrollOffset: number) => void;

    // Retrieves the previously saved scroll offset (first visible index) for the given route.
    getFirstVisibleIndex: (route: PlatformStackRouteProp<ParamListBase>) => number | undefined;

    const saveFirstVisibleIndex: ScrollOffsetContextValue['saveFirstVisibleIndex'] = useCallback((route, scrollOffset) => {
        firstVisibleIndexRef.current[getKey(route)] = scrollOffset;
    }, []);

    const getFirstVisibleIndex: ScrollOffsetContextValue['getFirstVisibleIndex'] = useCallback((route) => {
        if (!firstVisibleIndexRef.current) {
            return;
        }
        return firstVisibleIndexRef.current[getKey(route)];
    }, []);

via the contextValue.

In LHNOptionsList add a function:

    const handleViewableItemsChanged = ({viewableItems}) => {
        if (viewableItems.length > 0) {
            const currentIndex = viewableItems[0].index; // Get the first visible item
            saveFirstVisibleIndex(route, currentIndex); // Save the index
        }
    };

Update:

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 34 in e94df0f

const {saveScrollOffset, getScrollOffset} = useContext(ScrollOffsetContext);

    const {saveScrollOffset, getScrollOffset, getFirstVisibleIndex, saveFirstVisibleIndex} = useContext(ScrollOffsetContext);
    const firstVisibleItem = useRef(getFirstVisibleIndex(route));

2. Display a skeleton loader if the first visible item has not been rendered yet

In here introduce new state:

const [initialScrollIndexVisible, setInitialScrollIndexVisible] = useState(false);

Update the condition to display skeleton:

App/src/pages/home/sidebar/SidebarLinks.tsx

Line 96 in e94df0f

{!!isLoading && optionListItems?.length === 0 && (

                {(!initialScrollIndexVisible || (!!isLoading && optionListItems?.length === 0)) && (

3. Remove the skeleton loader once the first visible item is rendered

Update:

App/src/pages/home/sidebar/SidebarLinks.tsx

Line 87 in e94df0f

<LHNOptionsList

                    onInitialScrollIndexVisible={() => {
                        setInitialScrollIndexVisible(true);
                    }}

Function onInitialScrollIndexVisible will be triggered when the first visible item is rendered.

Update the onLayout function:

                    onLayout={() => {
                        onLayoutItem();
                        if (Math.abs(index - (firstVisibleItem.current ?? 0)) < 15) {
                            onInitialScrollIndexVisible?.();
                        }
                    }}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

We can utilize firstVisibleItem.current in the main solution and make the necessary updates:

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 270 in 0ff0cdf

<FlashList

                    initialScrollIndex={firstVisibleItem.current}

Remove the !initialScrollIndexVisible which is added in main solution from:

                {(!initialScrollIndexVisible || (!!isLoading && optionListItems?.length === 0)) && (

Result

Screen.Recording.2024-12-27.at.18.25.49.mov

saifelance · 2024-12-05T10:53:58Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem occurs when switching between the "Search" and "Inbox" tabs in the LHN (Left-Hand Navigation) while the list is scrolled down. The LHN flickers, creating a poor user experience.

LHN flickering occurs due to:

Re-rendering: FlashList unmounts/remounts when switching tabs due to optionMode or data changes.
Scroll Position Restoration: Inefficient handling of offsets causes layout jitter.
Layout Recalculation: Style updates during tab switches alter visible areas.
Key/Item Size Issues: Incorrect estimatedItemSize or key management disrupts rendering.
Transition Timing: Asynchronous updates or animations destabilize layout.

What is the root cause of that problem?

Preserve Scroll Position: Ensure efficient offset handling and avoid redundant renders.
Minimize Re-renders: Use React.memo, useCallback, and optimize extraData.
Optimize FlashList: Match estimatedItemSize with actual item heights; ensure consistent keys.
Debounce Updates: Batch layout changes to prevent disruptions.
Smooth Transitions: Add animations to reduce abrupt visual changes.
Debug Shifts: Investigate unnecessary style toggles.

What changes do you think we should make in order to solve the problem?

Updates

React.memo for Component Memoization
useCallback and useMemo for Optimization
Improved onScroll and onLayout
Updated Scroll-to-Top Logic
Updated Render Logic for Empty State
General Cleanup

App/src/components/LHNOptionsList/LHNOptionsList.tsx

import React, {useRef, useCallback, useEffect, useMemo} from 'react';
import {StyleSheet, View} from 'react-native';
import {FlashList} from '@shopify/flash-list';
import {useRoute} from '@react-navigation/native';
import {useOnyx} from 'react-native-onyx';
import OptionRowLHNData from './OptionRowLHNData'; // Assuming this is your custom component
import BlockingView from './BlockingView';
import TextBlock from './TextBlock';
import Icon from './Icon';
import useLocalize from '../hooks/useLocalize';
import useTheme from '../hooks/useTheme';
import useThemeStyles from '../hooks/useThemeStyles';
import useResponsiveLayout from '../hooks/useResponsiveLayout';
import usePrevious from '../hooks/usePrevious';
import * as CONST from '../constants';
import * as OptionsListUtils from '../utils/OptionsListUtils';
import * as ReportUtils from '../utils/ReportUtils';
import * as ReportActionsUtils from '../utils/ReportActionsUtils';
import * as DraftCommentUtils from '../utils/DraftCommentUtils';
import * as SidebarUtils from '../utils/SidebarUtils';
import {ScrollOffsetContext} from '../contexts/ScrollOffsetContext';

function LHNOptionsList({
    style,
    contentContainerStyles,
    data,
    onSelectRow,
    optionMode,
    shouldDisableFocusOptions = false,
    onFirstItemRendered = () => {},
}) {
    const {saveScrollOffset, getScrollOffset} = React.useContext(ScrollOffsetContext);
    const flashListRef = useRef(null);
    const route = useRoute();

    const [reports] = useOnyx(CONST.ONYXKEYS.COLLECTION.REPORT);
    const [reportActions] = useOnyx(CONST.ONYXKEYS.COLLECTION.REPORT_ACTIONS);
    const [policy] = useOnyx(CONST.ONYXKEYS.COLLECTION.POLICY);
    const [personalDetails] = useOnyx(CONST.ONYXKEYS.PERSONAL_DETAILS_LIST);
    const [transactions] = useOnyx(CONST.ONYXKEYS.COLLECTION.TRANSACTION);
    const [draftComments] = useOnyx(CONST.ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT);
    const [transactionViolations] = useOnyx(CONST.ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS);

    const theme = useTheme();
    const styles = useThemeStyles();
    const {translate, preferredLocale} = useLocalize();
    const {shouldUseNarrowLayout} = useResponsiveLayout();
    const shouldShowEmptyLHN = shouldUseNarrowLayout && data.length === 0;

    const onLayoutItem = useCallback(() => {
        onFirstItemRendered();
    }, [onFirstItemRendered]);

    const renderItem = useCallback(
        ({item: reportID}) => {
            const fullReport = reports?.[reportID];
            const policyData = policy?.[fullReport?.policyID];
            const lastMessageText = OptionsListUtils.getLastMessageTextForReport(fullReport, personalDetails, policyData);

            return (
                <OptionRowLHNData
                    reportID={reportID}
                    fullReport={fullReport}
                    policy={policyData}
                    personalDetails={personalDetails}
                    lastMessageText={lastMessageText}
                    onSelectRow={onSelectRow}
                    preferredLocale={preferredLocale}
                    hasDraftComment={DraftCommentUtils.isValidDraftComment(draftComments?.[reportID])}
                />
            );
        },
        [reports, policy, personalDetails, onSelectRow, preferredLocale, draftComments],
    );

    const extraData = useMemo(
        () => [reports, policy, personalDetails, data.length, draftComments, optionMode, preferredLocale],
        [reports, policy, personalDetails, data.length, draftComments, optionMode, preferredLocale],
    );

    const previousOptionMode = usePrevious(optionMode);

    useEffect(() => {
        if (previousOptionMode === optionMode || !flashListRef.current) {
            return;
        }
        flashListRef.current.scrollToOffset({offset: 0});
    }, [previousOptionMode, optionMode]);

    const onScroll = useCallback(
        (e) => {
            if (e.nativeEvent.layoutMeasurement.height > 0) {
                saveScrollOffset(route, e.nativeEvent.contentOffset.y);
            }
        },
        [route, saveScrollOffset],
    );

    const onLayout = useCallback(() => {
        const offset = getScrollOffset(route);
        if (offset && flashListRef.current) {
            requestAnimationFrame(() => {
                flashListRef.current.scrollToOffset({offset});
            });
        }
    }, [route, getScrollOffset]);

    return (
        <View style={[style ?? styles.flex1, shouldShowEmptyLHN ? styles.emptyLHNWrapper : undefined]}>
            {shouldShowEmptyLHN ? (
                <BlockingView
                    animation={CONST.LottieAnimations.Fireworks}
                    animationStyles={styles.emptyLHNAnimation}
                    title={translate('common.emptyLHN.title')}
                    shouldShowLink={false}
                />
            ) : (
                <FlashList
                    ref={flashListRef}
                    data={data}
                    renderItem={renderItem}
                    keyExtractor={(item) => item}
                    extraData={extraData}
                    onScroll={onScroll}
                    onLayout={onLayout}
                    estimatedItemSize={optionMode === CONST.OPTION_MODE.COMPACT ? CONST.variables.optionRowHeightCompact : CONST.variables.optionRowHeight}
                    showsVerticalScrollIndicator={false}
                    keyboardShouldPersistTaps="always"
                />
            )}
        </View>
    );
}

export default React.memo(LHNOptionsList);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Verify smooth scroll restoration during tab switches.
Test with long lists to ensure no flickers.
Validate transitions in both empty and populated LHN states.
Simulate rapid tab switching for stability.
Test across devices and orientations.
Check offset handling during mid-scroll tab switches.

What alternative solutions did you explore? (Optional)

Use a static LHN component to avoid unmounting.
Manage LHN state globally with Redux/Context for smoother transitions.
Leverage native optimizations for Android rendering.

slafortune · 2024-12-05T20:55:57Z

I am not able to reproduce this - reached out to C+ here

Screen_Recording_20241205_145204_New.Expensify.mp4

MelvinBot · 2024-12-05T20:56:08Z

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

truph01 · 2024-12-09T09:41:17Z

@slafortune You can try the below steps to reproduce the bug:

Open the ND app and log in using an account with more than 100 reports in the LHN.
Scroll to the bottom of the LHN list.
Tap on the Search option.
Tap on Inbox.

melvin-bot · 2024-12-09T09:47:28Z

@slafortune Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2024-12-11T09:18:13Z

@slafortune Eep! 4 days overdue now. Issues have feelings too...

slafortune · 2024-12-12T21:30:53Z

Alright - thank, I was able to recreate this now.

melvin-bot · 2024-12-12T21:31:07Z

Job added to Upwork: https://www.upwork.com/jobs/~021867321297737486613

melvin-bot · 2024-12-12T21:31:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

melvin-bot · 2024-12-16T09:36:43Z

@slafortune, @hungvu193 Whoops! This issue is 2 days overdue. Let's get this updated quick!

hungvu193 · 2024-12-16T09:46:28Z

Not overdue

hungvu193 · 2024-12-17T09:58:46Z

@truph01 Can you provide more details on your solution? Maybe a test branch so I can test it?

truph01 · 2024-12-17T10:29:06Z

@hungvu193 The test branch here

rezkiy37 · 2025-01-15T15:04:08Z

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

rezkiy37 · 2025-01-16T17:21:59Z

Working on the issue.

rezkiy37 · 2025-01-17T11:20:36Z

I can confirm the bug is replicable.

rezkiy37 · 2025-01-17T14:03:42Z

My investigations:

The bug happens only when the app scrolls LHN. If the LHN is on the top it works properly.
The project uses scrollToOffset of FlashList. It supports the animated param. It is false currently.

App/src/components/LHNOptionsList/LHNOptionsList.tsx

Line 254 in 71a892b

flashListRef.current.scrollToOffset({offset});
When I set the param to true, it works a bit smoother and there are no flickers. However, there is a blank area while rows are not rendered.

Video

Test.mp4

I am testing in dev mode so it is much slower than production for sure.
Going to build an APK.

rezkiy37 · 2025-01-17T16:36:18Z

There is a useful prop of FlashList - initialScrollIndex. I am testing to implement it.

truph01 · 2025-01-17T19:16:08Z

There is a useful prop of FlashList - initialScrollIndex. I am testing to implement it.

@rezkiy37 I’ve already tried using this prop, but occasionally an empty screen is displayed, as noted here. I’m not sure how you’re using it, but if you’ve encountered the same bug, we’re on the same page.

huult · 2025-01-18T03:54:24Z

#53605 (comment)

There is a useful prop of FlashList - initialScrollIndex. I am testing to implement it.

@rezkiy37 that is my suggestion

hungvu193 · 2025-01-20T02:16:26Z

Still in progress

truph01 · 2025-01-20T03:53:51Z

Proposal updated

I just restored the solution that I mistakenly removed (added to the What alternative solutions did you explore? (Optional) section)

rezkiy37 · 2025-01-20T09:30:48Z

I take your comments into account, appreciate it 🙂

rezkiy37 · 2025-01-20T16:43:41Z

I am preparing a proposal.

github-actions · 2025-01-20T17:18:08Z

⚠️ @rezkiy37 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

rezkiy37 · 2025-01-20T17:25:35Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem occurs when opening the "Inbox" tab during switching between the tabs. The LHN flickers. It rerenders. Moreover, it does not always restore the previous scroll position.

What is the root cause of that problem?

FlashList rerenders during scrolling to the previous position or even stays at the top.

What changes do you think we should make in order to solve the problem?

I am proposing to add one more important property to FlashList - estimatedListSize. It allows FlashList to avoid auto-measuring by setting static values. They say:

Estimated visible height and width of the list. It is not the scroll content size. Defining this prop will enable the list to be rendered immediately. Without it, the list first needs to measure its size, leading to a small delay during the first render.

const {windowHeight, windowWidth} = useWindowDimensions();
const listHeight = windowHeight - variables.bottomTabHeight;

....

<FlashList
  ...
  estimatedListSize={{
    height: listHeight,
    width: windowWidth,
  }}
/>

I can easily obtain the window dimensions and the defined tab height. I understand that the header height is dynamic, but I don’t see any issue if the list height is slightly larger than the actual. Considering that getting the header height could be an overhead, I believe this is a reasonable compromise.

Additionally, it resolves an issue related to restoring the previous scroll position. It now functions flawlessly.

I've attached a couple of videos to demonstrate the difference ⬇️

Video before

Before.mp4

Video after

After.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Verify that the previous scroll position has been restored properly during tab switches.
Test long and short lists.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

N/A

hungvu193 · 2025-01-22T07:19:36Z

Thanks for the update @rezkiy37, I'll take a look 👀

rezkiy37 · 2025-01-23T17:56:23Z

I've opened #55486 for review.

melvin-bot · 2025-01-28T09:08:46Z

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

rezkiy37 · 2025-01-28T12:03:50Z

#55486 (comment)

I am going to work on a follow-up to find a web solution.

rezkiy37 · 2025-02-04T13:23:16Z

Working on the issue today.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 4, 2024

melvin-bot bot assigned slafortune Dec 4, 2024

slafortune added the Needs Reproduction Reproducible steps needed label Dec 5, 2024

melvin-bot bot added the Overdue label Dec 9, 2024

melvin-bot bot removed the Overdue label Dec 12, 2024

slafortune added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Dec 12, 2024

melvin-bot bot changed the title ~~Android - LHN flickers when scrolled down and switching between Search and Inbox~~ [$250] Android - LHN flickers when scrolled down and switching between Search and Inbox Dec 12, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024

slafortune added this to [#whatsnext] #quality Dec 12, 2024

melvin-bot bot assigned hungvu193 Dec 12, 2024

slafortune moved this to LOW in [#whatsnext] #quality Dec 12, 2024

melvin-bot bot added the Overdue label Dec 16, 2024

melvin-bot bot removed the Overdue label Dec 16, 2024

slafortune assigned rezkiy37 Jan 15, 2025

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 15, 2025

melvin-bot bot added the Overdue label Jan 17, 2025

melvin-bot bot removed the Overdue label Jan 20, 2025

hungvu193 removed the status in [#whatsnext] #quality Jan 20, 2025

muttmuure moved this to MEDIUM in [#whatsnext] #quality Jan 20, 2025

rezkiy37 mentioned this issue Jan 20, 2025

Fix LHN flickers and scroll position restoring #55486

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 23, 2025

melvin-bot bot assigned puneetlath Jan 28, 2025

MarioExpensify mentioned this issue Feb 4, 2025

LHN - LHN scrolls to the top when navigating between tabs #56323

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$250] Android - LHN flickers when scrolled down and switching between Search and Inbox #53605

[$250] Android - LHN flickers when scrolled down and switching between Search and Inbox #53605

lanitochka17 commented Dec 4, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Dec 4, 2024

truph01 commented Dec 5, 2024 •

edited by github-actions bot

Loading

saifelance commented Dec 5, 2024

slafortune commented Dec 5, 2024 •

edited

Loading

MelvinBot commented Dec 5, 2024

truph01 commented Dec 9, 2024

melvin-bot bot commented Dec 9, 2024

melvin-bot bot commented Dec 11, 2024

slafortune commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 16, 2024

hungvu193 commented Dec 16, 2024

hungvu193 commented Dec 17, 2024

truph01 commented Dec 17, 2024

rezkiy37 commented Jan 15, 2025

rezkiy37 commented Jan 16, 2025

rezkiy37 commented Jan 17, 2025

rezkiy37 commented Jan 17, 2025

rezkiy37 commented Jan 17, 2025

truph01 commented Jan 17, 2025

huult commented Jan 18, 2025

hungvu193 commented Jan 20, 2025

truph01 commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025

hungvu193 commented Jan 22, 2025

rezkiy37 commented Jan 23, 2025

melvin-bot bot commented Jan 28, 2025

rezkiy37 commented Jan 28, 2025

rezkiy37 commented Feb 4, 2025

[$250] Android - LHN flickers when scrolled down and switching between Search and Inbox #53605

[$250] Android - LHN flickers when scrolled down and switching between Search and Inbox #53605

Comments

lanitochka17 commented Dec 4, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Dec 4, 2024

truph01 commented Dec 5, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Result

saifelance commented Dec 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Updates

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

slafortune commented Dec 5, 2024 • edited Loading

MelvinBot commented Dec 5, 2024

truph01 commented Dec 9, 2024

melvin-bot bot commented Dec 9, 2024

melvin-bot bot commented Dec 11, 2024

slafortune commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 16, 2024

hungvu193 commented Dec 16, 2024

hungvu193 commented Dec 17, 2024

truph01 commented Dec 17, 2024

rezkiy37 commented Jan 15, 2025

rezkiy37 commented Jan 16, 2025

rezkiy37 commented Jan 17, 2025

rezkiy37 commented Jan 17, 2025

rezkiy37 commented Jan 17, 2025

truph01 commented Jan 17, 2025

huult commented Jan 18, 2025

hungvu193 commented Jan 20, 2025

truph01 commented Jan 20, 2025

Proposal updated

rezkiy37 commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025

github-actions bot commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

hungvu193 commented Jan 22, 2025

rezkiy37 commented Jan 23, 2025

melvin-bot bot commented Jan 28, 2025

rezkiy37 commented Jan 28, 2025

rezkiy37 commented Feb 4, 2025

lanitochka17 commented Dec 4, 2024 •

edited by melvin-bot bot

Loading

truph01 commented Dec 5, 2024 •

edited by github-actions bot

Loading

slafortune commented Dec 5, 2024 •

edited

Loading