[HOLD for payment 2025-02-06] [HOLD for payment 2025-01-21] Add plan changes to Subscriptions

[garrettmknight]

Part of the Workspace Downgrades project

Main issue: https://github.com/Expensify/Expensify/issues/399936
Project: Workspace Downgrades

Feature Description

1. Update the Your plan section of the Subscriptions page to show both plan types with the current, highest plan type the account is an admin of highlighted/selected.
2. If the user selects the other plan type, we'll check whether they're an admin on one or more workspaces:

• If they're only an admin of one workspace we can just upgrade or downgrade that workspace from here we'll:
  • If the user is on Collect and selects Control, we'll launch the Upgrade RHP
  • If the user is on Control and selects Collect, we'll launch the Downgrade RHP
• If they're an admin on multiple workspaces, they'll need to upgrade or downgrade their workspaces individually:
  • If the user is on Collect and selects Control, we'll launch an RHP directing the user to workspaces to upgrade
  • If the user is on Control and selects Collect, we'll launch an RHP directing the user to workspaces to downgrade

Copy for options above in this Figma here

Manual Test Steps

Single Workspace Upgrade

1. Create a new account
2. Create a workspace
3. Navigate to subscriptions
4. Click on 'Control'
5. Confirm Upgrade RHP opens
6. Click 'Upgrade'
7. Confirm your workspace has been upgraded

Single Workspace Downgrade (follow Single Workspace Upgrade steps first)

1. Navigate to subscriptions
2. Click on 'Collect'
3. Confirm Downgrade RHP opens
4. Click 'Downgrade'
5. Confirm your workspace has been downgraded

Multi Workspace Upgrade (follow Single Workspace Upgrade + Downgrade steps first)

1. Create an additional workspace
2. Navigate to subscriptions
3. Click on 'Control'
4. Confirm Upgrade RHP opens for multi workspaces
5. Click 'Go to Workspaces'
6. Confirm you're sent to workspace page
7. Upgrade a workspace
8. Navigate back to Subscriptions and confirm 'Control' is selected

Multi Workspace Upgrade (follow Multi Workspace Upgrade steps first)

1. Navigate to subscriptions
2. Click on 'Collect'
3. Confirm Downgrade RHP opens for multi workspaces
4. Click 'Go to Workspaces'
5. Confirm you're sent to workspace page
6. Downgrade the Control workspace
7. Navigate back to Subscriptions and confirm 'Collect' is selected

Automated Tests

N/A

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[JmillsExpensify]

Still very excited for this one.

[garrettmknight]

Hoping to prioritize this week while things are quiet.

[garrettmknight]

Sweet - got a minute to work through some copy options for when the user is an admin on multiple workspaces here.

[garrettmknight]

Alright - OP is updated, now we're just waiting for the main issue to complete to open this one up.

[garrettmknight]

Quick clarification about the HOLD here:

• We already have the upgrade command in ND
• We're working on the downgrade command in https://github.com/Expensify/Expensify/issues/399936
• Once we have the downgrade command, we should be able to open this up externally since it's more of a FE change that just calls our BE command.

[carlosmiceli]

@jayeshmangwani Hey Jayesh, here's another issue we need to work on to really complete the full upgrades/downgrades project. Seems like a natural progression for you to take over this issue too, let me know if there are any questions.

I do have one question for you: we need to implement a check for whether the admin manages multiple workspaces or not. Do we have a way to check for that in the FE? Probably not, but thought I'd ask. If not, what kind of changes would you need from the BE (as in, what command or response would you like to see changed and how)?

[jayeshmangwani]

Seems like a natural progression for you to take over this issue too, let me know if there are any questions.

Yes, that sounds good. I will start working on this issue once we merge PR for the downgrade workspace UI and new downgrade API.

@carlosmiceli @garrettmknight I will also need access to Figma, as I cannot find this section in the design doc.

[jayeshmangwani]

@carlosmiceli For the multiple workspaces admin front-end check, I think we already have a function that can be used here. The getOwnedPaidPolicies function takes all policies and a user ID, then returns all the collect and control workspaces (paid workspaces) where the user is an admin.

App/src/libs/PolicyUtils.ts

Lines 391 to 393 in ec76adc

	function getOwnedPaidPolicies(policies: OnyxCollection<Policy> | null, currentUserAccountID: number): Policy[] {
	return Object.values(policies ?? {}).filter((policy): policy is Policy => isPolicyOwner(policy, currentUserAccountID ?? -1) && isPaidGroupPolicy(policy));
	}

[carlosmiceli]

Boom! Looks like we're good here @garrettmknight 💪
@jayeshmangwani great news, we're waiting for the final BE review and we're good to go, will report as soon as it's merged 👍

[jayeshmangwani]

will report as soon as it's merged 👍

Thanks 🙌

[carlosmiceli]

BE is merged 🙌

[carlosmiceli]

Small BE change requested by our contributors has both PRs in review, which should completely unblock @jayeshmangwani from completing the plan page work.

[carlosmiceli]

Both BE PRs have been merged.

[jayeshmangwani]

@garrettmknight, currently, we show the text Are you sure you want to downgrade and remove your configurations? **This cannot be undone**. above the 'Go to Workspaces' button. Should we hide it in the case of multiple workspaces and only show it for a single workspace, or should we remove this text altogether?

[garrettmknight]

I think we can remove the 'this cannot be undone' warning - they'll see it when they downgrade the workspaces individually.

Here's the upgrade copy:

Unlock our most powerful features, including:
- Advanced accounting connections (NetSuite, Sage Intacct, and more)
- Smart expense rules
- Multi-level approval workflows
- Enhanced security controls

The Control plan starts at $9 per active member per month. Learn more about our [plans and pricing](https://help.expensify.com/articles/new-expensify/billing-and-subscriptions/Plan-types-and-pricing).


To upgrade, click **Go to Workspaces**, select a workspace, and change the plan type to **Control**.

[jayeshmangwani]

Thanks for the copies

[melvin-bot]

@carlosmiceli, @garrettmknight, @jayeshmangwani Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[garrettmknight]

@jayeshmangwani let me know when you've got that PR up.

[jayeshmangwani]

@garrettmknight @DylanDylann Opened a PR to update the copies, but we still need confirmation for the Spanish version, which we raised on Slack.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Multi ws copies upgrade #55858

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[garrettmknight]

No BZ necessary, adding QA for the project.

[DylanDylann]

@garrettmknight @carlosmiceli If there are no tasks anymore. I think we are ready to handle the payment for this entire project.

cc @jayeshmangwani

[jayeshmangwani]

Agreed with Dylan—there are no pending tasks for this project.

[garrettmknight]

Yep! On my todo list. Do you two happen to have a list of issues you completed handy?

[DylanDylann]

We have 6 issues created for this feature and all are done by 4 PRs. Additionally we have some other regression/polish issues that not calculated here

1. [HOLD for payment 2024-11-11] Implement the route for Workspace Downgrades #51486
2. [HOLD for payment 2025-02-06] [HOLD for payment 2025-01-21] Add plan changes to Subscriptions  #52588
3. [HOLD for payment 2025-01-02] [HOLD for payment 2024-12-07] Create missing upgrade and RHP components  #51768
4. Create components for Workspace Downgrade #51494
5. Add upgrade and downgrade #admins messaging #51764
6. [HOLD for payment 2025-01-02] Hook up with the Downgrade Workspace API #51515