[HOLD for payment 2024-12-03] [hold] Web - Concierge - Take a 2-minute tour task not autocomplete after finishing tour

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.58.0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #51153
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in with a new account
2. On the onboarding modal select any option other than 'Something else"
3. Complete the onboarding flow
4. Navigate to the Concierge chat
5. Select the Take a 2-minute tour task
6. Click on the link and finish the tour

Expected Result:

The task is marked complete automatically upon finishing the tour like other Concierge tasks

Actual Result:

The "Take a 2-minute tour" task is not marked complete automatically

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6656089_1730861962528.Recording__917.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[c3024]

I don't think this needs to be a deploy blocker.

For all tasks, backend sets the task as completed after the action is complete like "Track an expense" task, "Meet your setup specialist" task etc. I think this should also be handled from backend.

To handle this on frontend, the task needs to be marked as complete on clicking the external link included in the text markdown. I think this is difficult.

cc: @mountiny

[c3024]

#51153 is related to this.

[lakchote]

I do agree that it's not a blocker and that it should be handled on the backend for the reasons mentioned above by @c3024.

Waiting for your input @mountiny too

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Concierge - Take a 2-minute tour task not autocomplete after finishing tour

What is the root cause of that problem?

BE not autocomplete the task on SelfTourViewed API call
and on the task description we directly open the self tour link so we can't call SelfTourViewed API

What changes do you think we should make in order to solve the problem?

BE need to be updated, when SelfTourViewed API call should set the task as completed, and return the onyx data

And for the FE fix: Create new route and new screen for self tour, which when opened will call the SelfTourViewed API and redirect user to the self tour link

function SelfTour() {
    const {environment} = useEnvironment();
    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED);

    useEffect(() => {
        Welcome.setSelfTourViewed();
        Link.openExternalLink(getNavatticURL(environment, introSelected?.choice));
        Navigation.goBack();
    }, []);

    return null;
}

And navigate to the new route on link click

App/src/libs/actions/Report.ts

Line 3490 in 7b9a0cd

navatticURL: getNavatticURL(environment, engagementChoice),

navatticURL: `${environmentURL}/${ROUTES.SELF_TOUR}`,

Might need to apply to other places as well if needed

App/src/pages/Search/EmptySearchView.tsx

Line 126 in 7b9a0cd

{buttonText: translate('emptySearchView.takeATour'), buttonAction: () => Link.openExternalLink(navatticURL)},

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 449 to 452 in 7b9a0cd

	onSelected: () => {
	Welcome.setSelfTourViewed();
	Link.openExternalLink(navatticURL);
	},

Navigation.navigate(ROUTES.SELF_TOUR);

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

IMO updating/fixing the BE alone won’t fix this issue, so I posted a proposal for the FE fix

[mountiny]

@c3024 @rushatgabhane should be assigned and we should mark this optimistically as completed and call the SelfTourViewed command and update the BE to mark the task as complete too

[melvin-bot]

@OfstadC, @lakchote, @rushatgabhane, @c3024 Eep! 4 days overdue now. Issues have feelings too...

[lakchote]

Didn't have time to focus on it internally as I'm focusing on a #stability issue.

@c3024 you can still raise a frontend PR to set this optimistically in the meantime (see @mountiny's comment above).

[rushatgabhane]

yes I'll raise a PR

[lakchote]

If you could do it today that'd be great @rushatgabhane

[c3024]

Raised a PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.66-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove links to the tour after it has been viewed from anywhere #52617

If no regressions arise, payment will be issued on 2024-12-03. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

@rushatgabhane / @c3024 @OfstadC @rushatgabhane / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[OfstadC]

@rushatgabhane @c3024 Please complete thee BZ checklist by EOD so we can issue payment tomorrow

[rushatgabhane]

1. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: New feature. Not a bug

2. If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

3. If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Test 1

1. Login with a new account.
2. Click on FAB > "Take a 2 minute tour".
3. Go back to the ND tab.
4. Verify that the task "Take a 2-minute tour" in Concierge is marked as complete.
5. Click on Search.
6. Verify that there is no "Take a tour" button in the search page.

Test 2

1. Login with a new account.
2. Click on Search > Click on the "Take a tour" button in the Search page.
3. Go back to the ND tab.
4. Click on "Inbox"
5. Verify that the task "Take a 2-minute tour" in Concierge is marked as complete.
6. Click on FAB
7. Verify that there is no "Take a 2 minute tour" link in FAB.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $250 via NewDot
• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@OfstadC)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[OfstadC]

@c3024 Offer sent here

[OfstadC]

Ooop didn't mean to close this. Still need @c3024 to accept Upwork Offer

[OfstadC]

@c3024 Could you please accept the offer so we can close this GH out? 😃 Thanks so much!

[c3024]

@OfstadC , sorry for the delayed response. This is part of a project and payment is handled here. No payment in this issue. Thanks!

[OfstadC]

Ah okay! Thanks for letting me know. I will not issue payment here then 😃