[HOLD for payment 2025-01-13] [GR Phase 3] Step 2 - navigation, default data, validation logic and API call to save it

[madmax330]

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.bos524lch8mt

[pasyukevich]

Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.

[pasyukevich]

Updates:
Finished with replacing mocks to the API call to get fields
Added one more missed screen - AccountHolderDetails
Updated the Navigation between substeps logic

Keep working on the API call for bank account creation

[pasyukevich]

Finished API integrations

Working on error handling for specific cases

[pasyukevich]

Today's update:

Covering edge cases, polishing the code

Waiting for the data to have a successful path with API

[pasyukevich]

Today's update:

Updated request with required parameters for the successful path with API

[pasyukevich]

Today's update:

Added error handling for the API create bank account request

Adding error handling for the get fields request

[pasyukevich]

Today's update:

All updates and polishing are done - preparing the videos

[pasyukevich]

Today's update:

Found the problem on the native side in case of error leads to inconsistent behavior
Preparing the fix

[pasyukevich]

Today's update:

Merged main

Found the root cause of the problem, changing the error handling approach for the failed API create bank account request

[hungvu193]

Any updates here?

[pasyukevich]

Sure, current updates:

• Changed Confirmation substep to the Form for better API request handling

• Facing the issue that we cannot handle the loading state with the same onyx key since it will trigger updates of the wrapper. Working now on this

[pasyukevich]

Today's update:

• Problem solved, error handling updated
• Faced with changes on BE, waiting for clarification for the updated contract

[pasyukevich]

Today's update:

• Adjusted request submitted with new props
• Waiting for BE fix to have the success path

[pasyukevich]

Waiting for API updates

[pasyukevich]

Applied updated to stabilize the flow

I started recording videos, now blocked by the API error that it was before

Waiting for API updates

[pasyukevich]

Ready for review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @madmax330, @hungvu193, @pasyukevich eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Update corpay fields logic, integrate API #52812

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @pasyukevich does not require payment (Contractor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @Christinadobrzyn you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Contributor: @pasyukevich is from an agency-contributor and not due payment

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Payment summary here - #50904 (comment)

@hungvu193 do we need a regression test for this?

[hungvu193]

Regression Test:

1. Change workspace currency to EUR, GBP, CAD or AUD.
2. Go to Workpsace, More feature page and Enable workflows for the workspace.
3. Open workflows.
4. Try to connect a bank account.
5. Go to the second step - a new component should be displayed.
6. The first substep validations and field lists will be received from the BE.
7. For the AUD currency we should have 3 substeps (on the second upload file step, for other currencies should be skipped)
8. Verify Upload picker validations (10 files limit, 5MB total, PDF/PNG/JPEG only)
9. Go to the third step
10. Repeat the steps and verify that the error is shown due to invalid data

Do we 👍 or 👎 ?

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/460902

Payment summary here - #50904 (comment)

I think this can be closed! @hungvu193 don't forget to request payment in ND!

[garrettmknight]

$250 approved for @hungvu193