[HOLD for payment 2024-12-17] Handle blocked copilot and Expensify card flows gracefully

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Similar to this issue, we need to prevent co-pilots from issuing new Expensify cards.

We should implement exact same solution for issue new Expensify card flow, additionally we need to check for company cards as well.

{ "code": 666, "jsonCode": 666, "type": "Expensify\\Libs\\Error\\ExpError", "UUID": "7D862FFF-854D-4AE0-B50B-6C8C96D37AB9", "message": "You must be a domain admin to create the virtual card.", "title": "", "data": [], "htmlMessage": "", "onyxData": [], "requestID": "8d2f62629dff8531-BOM" }

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

N/A

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021846678596552098944
• Upwork Job ID: 1846678596552098944
• Last Price Increase: 2024-10-16

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Julesssss]

Hey @jliexpensify we're going to hire @c3024 and @ChavdaSachin as discussed here.

[ChavdaSachin]

coming from here

[c3024]

Please assign me. Thanks!

[jliexpensify]

@Julesssss - just checking: are we paying $250 in this issue, or is Anu handling in the other one? Thanks!

[Julesssss]

Lets keep them seperate

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021846678596552098944

[melvin-bot]

Current assignee @c3024 is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

@ChavdaSachin @c3024 I think I hired the right people? 😅 Let me know if you didn't get an offer

[c3024]

I got the offer on Upwork!

[ChavdaSachin]

Got the offer ✅

[jliexpensify]

@Julesssss are we following the timeline in the other GH? If so, that's set to pay on the 24th.

[Julesssss]

@Julesssss are we following the timeline in the other GH? If so, that's set to pay on the 24th.

Yeah 👍

[Julesssss]

Wait, I have lost track of the PR now.

So could you raise an issue with same c+ here and I will raise a quick PR.
also could you please add my accounts to copilot beta

@ChavdaSachin I can't find the PR, can you share a link please?

[ChavdaSachin]

@Julesssss I haven't raised PR here yet, coz I am testing other scenarios where we might need same implementation.
Like - copilot is able to close owner's account.
So let me prepare a complete list so we can solve this issue for once and all.

[ChavdaSachin]

Will send you a list in a couple hrs, and after your confirmation will raise PR.

[Julesssss]

No worries, thanks for confirming. I'll remove the payment date

[ChavdaSachin]

@jliexpensify make sure to hold the payment,
The PR merged was just a supporting PR, The original PR is yet to be merged #52103

[melvin-bot]

@Julesssss, @jliexpensify, @ChavdaSachin, @c3024, @dubielzyk-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[ChavdaSachin]

@Julesssss could you give a thought to bounty amount here please?
@c3024 what you suggest?

[c3024]

I agree. This grew into a large PR with handling all cases meticulously and building the wrapper. Great job!

[Julesssss]

Yeah, I was going to suggest an increase here.

Over the last month you have handled many cases, testing, and the necessary Onyx changes. This work extended from the original PR, so I think a 3x multiplier for this issue seems fair. That would make a $750 bounty.

[jliexpensify]

@Julesssss is this what you're thinking?

• C: @ChavdaSachin $750 (to be paid via Upworks)
• C+: @c3024 $750 (to be paid via ND)

https://www.upwork.com/jobs/~021846678596552098944

[jliexpensify]

#52103 currently deployed to Staging

[c3024]

@jliexpensify , I think it should be the same for both.

cc: @Julesssss

@jliexpensify Btw, I am eligible for payments on NewDot too.

[jliexpensify]

Fixed, thanks!

[Julesssss]

Yeah, that looks good @jliexpensify

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Handle blocked copilot and Expensify card flows gracefully #52103

If no regressions arise, payment will be issued on 2024-12-17. 🎊

For reference, here are some details about the assignees on this issue:

• @ChavdaSachin requires payment (Needs manual offer from BZ)
• @c3024 requires payment through NewDot Manual Requests

[melvin-bot]

@c3024 @jliexpensify @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jliexpensify]

Bumping @c3024 for the checklist

[c3024]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This is related to design of copilot actions so specific PR can be held responsible.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: No discussion was started because this is not a bug that could be identified earlier.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Logged into ND as a copilot.

Test:

Tests 1 to 10 here in QA tests in this PR.

Do we agree 👍 or 👎

[jliexpensify]

Payment Summary

• C: @ChavdaSachin $750 (to be paid via Upworks)
• C+: @c3024 $750 (to be paid via ND)

https://www.upwork.com/jobs/~021846678596552098944

[jliexpensify]

@c3024 going to end the contract (but leave you positive feedback) so you can request on ND

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ChavdaSachin paid $(AMOUNT) via Upwork (LINK)
• Reviewer: @c3024 owed $250 via NewDot

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1846678596552098944/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

Paid and job closed!

[JmillsExpensify]

$750 approved for @c3024 based on this summary.