[HOLD for payment 2024-08-07] [$250] Room - Inviting new members to room shows duplicate contact briefly in members list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4751847
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Tap on a room chat -- header-- members -- invite
3. Add a new member by entering new address or phone contact

Expected Result:

Inviting new members to room must not show duplicate contact briefly in members list

Actual Result:

Inviting new members to room shows duplicate contact briefly in members list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6549202_1721641129832.ne.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c5c0ee049c0690eb
• Upwork Job ID: 1815530692990183389
• Last Price Increase: 2024-07-22
• Automatic offers:
• FitseTLT | Contributor | 103282594

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Inviting new members to room shows duplicate contact briefly in members list

What is the root cause of that problem?

For new personal details optimistic personal detail is created until the real details comes from the server

App/src/libs/actions/Report.ts

Lines 2815 to 2816 in b8b99d0

	optimisticData.push(...newPersonalDetailsOnyxData.optimisticData);

and when it comes the optimistic will be delted from onyx

App/src/libs/actions/Report.ts

Lines 2831 to 2832 in b8b99d0

	successData.push(...newPersonalDetailsOnyxData.finallyData);

but there is a time gap where both will be displayed until the optimistic data is deleted successfully

What changes do you think we should make in order to solve the problem?

In RoomMembers page, we can filter out isOptimisticPersonalDetail type personal detail if there is another detail with the same login by changing code here

App/src/pages/RoomMembersPage.tsx

Lines 177 to 180 in b8b99d0

	if (!details) {
	Log.hmmm(`[RoomMembersPage] no personal details found for room member with accountID: ${accountID}`);
	return;
	}

if (!details || (details.isOptimisticPersonalDetail && participants.some((accID) => accID !== accountID && details.login === personalDetails[accID]?.login))) {
                Log.hmmm(`[RoomMembersPage] no personal details found for room member with accountID: ${accountID}`);
                return;
            }

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c5c0ee049c0690eb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[sakluger]

@FitseTLT as far as you can tell, is this only broken for adding new members to a room, or would it also cause the issue when inviting someone to a workspace?

[FitseTLT]

@FitseTLT as far as you can tell, is this only broken for adding new members to a room, or would it also cause the issue when inviting someone to a workspace?

@sakluger No the issue doesn't occur for workspace's member invitation page.

[hungvu193]

I'll take a look today

[hungvu193]

@FitseTLT 's proposal here looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[FitseTLT]

bump @aldo-expensify for assignment

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Room - Inviting new members to room shows duplicate contact briefly in members list #46331

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
• [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hungvu193] Determine if we should create a regression test for this bug.
• [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Summarizing payment on this issue:

Contributor: @FitseTLT $250, paid via Upwork
Contributor+: @hungvu193 $250, please request on Newdot

@hungvu193 please also complete the BZ checklist.

[hungvu193]

• The PR that introduced the bug has been identified. Link to the PR: UI for room invitations/removals #27966
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27966/files#r1708527429
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

Regresstion tests:

1. Launch app
2. Tap on a room chat, click on Header --> choose Members --> select Invite.
3. Add a new member by entering the new email address or phone contact.
4. Verify that duplicate contact is not displayed in room members page.

Do we 👍 or 👎 ?

[sakluger]

Thanks!

[JmillsExpensify]

$250 approved for @hungvu193