[HOLD for payment 2024-08-09] [$250] Xero - Xero action modal appears below the button and overlaps with the composer

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.8-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44170

Action Performed:

Precondition:

• Workspace is connected to Xero
• Delayed submission is enabled in Workflows

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit an expense
4. In the main chat, click on the pay elsewhere dropdown.the composer.
5. Pay elsewhere the report
6. Click on the Xero action dropdown

Expected Result:

Xero action modal will appear above the button and does not overlap with the composer

Actual Result:

Xero action modal appears below the button and overlaps with the composer

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6544851_1721204888277.20240717_162450.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019da83e276a5e9487
• Upwork Job ID: 1813781422967508952
• Last Price Increase: 2024-07-18
• Automatic offers:
• nyomanjyotisa | Contributor | 103231671

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Xero action modal appears below the button and overlaps with the composer

What is the root cause of that problem?

On ExportWithDropdownMenu we always set the anchorAlignment to horizontal RIGHT and vertical TOP for both in MoneyReportHeader and ReportPreview

App/src/components/ReportActionItem/ExportWithDropdownMenu.tsx

Lines 94 to 97 in a129673

	anchorAlignment={{
	horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
	vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
	}}

What changes do you think we should make in order to solve the problem?

We should set the anchorAlignment to horizontal RIGHT and vertical BOTTOM if it used in ReportPreview

1. Add new props on ExportWithDropdownMenu called paymentMethodDropdownAnchorAlignment and set the default value to horizontal RIGHT and vertical TOP

type ExportWithDropdownMenuProps = {
    policy: OnyxEntry<Policy>;

    report: OnyxEntry<Report>;

    connectionName: ConnectionName;

    paymentMethodDropdownAnchorAlignment?: AnchorAlignment;
};

function ExportWithDropdownMenu({
    policy,
    report,
    connectionName,
    paymentMethodDropdownAnchorAlignment = {
        horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
        vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,
    },
}:

2. Use that new prop here

anchorAlignment={paymentMethodDropdownAnchorAlignment}

3. Pass the paymentMethodDropdownAnchorAlignment with horizontal RIGHT and vertical BOTTOM with here

<ExportWithDropdownMenu
      policy={policy}
      report={iouReport}
      connectionName={connectedIntegration}
      paymentMethodDropdownAnchorAlignment={{
          horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.RIGHT,
          vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM,
      }}
  />

RESULT

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal updated

[trjExpensify]

@arosiclair do you agree this isn't a blocker?

I agree the popover should be in the same place as the pay selector options, so let's fix it. Also, we should be using circle Xero avatars in the popover, not squares. Just like QBO:

[trjExpensify]

Certainly not a web blocker, removing that label minimally now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019da83e276a5e9487

[trjExpensify]

Cool, thanks! CC: @dannymcclain for vis just in case that intentionally changed somewhere.

[dannymcclain]

Nope, they're supposed to be circles. We just like to upload the assets to the repo as squares and then do the rounding with code (in case we ever want to change them from circles to rounded squares or adjust the border radius or something).

[trjExpensify]

Perf, thanks for confirming!

[nyomanjyotisa]

I wanted to suggest that we re-evaluate and consider increasing the bounty for this issue. Initially, the request was to ensure that the Xero action modal appears above the button and does not overlap with the composer. However, the PR ended up addressing three separate issues:

• Ensuring the modal appears above the button and does not overlap with the composer
• Making the icon circular
• Fixing the modal alignment with the button

Given the additional work involved, I believe it's reasonable to increase the bounty for this issue.

cc @shawnborton @trjExpensify

[trjExpensify]

I think we're splitting hairs on requesting a bounty increase for this issue. The position of the popover was wrong appearing over the composer, and we needed to put it back to where it should be. Switching XeroSquare for XeroCircle is also so incredibly minor. Overall, $250 is already a generous bounty for a +29 line PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix Xero action modal positioning and display circle icon instead #46127

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @nyomanjyotisa requires payment automatic offer (Contributor)
• @aimane-chnaif requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Payouts due:

• Contributor: $250 @nyomanjyotisa automatic offer
• Contributor+: $250 @aimane-chnaif via NewDot

Upwork job is here.

[kadiealexander]

@aimane-chnaif don't forget the checklist!

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: feature: add props isSplit to button with dropdown #40278
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40278/files#r1713195003
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

I don't think this is worth adding to regression test as minor style issue.

[kadiealexander]

Thanks @aimane-chnaif! Please apply via NewDot (summary here)

[aimane-chnaif]

@kadiealexander I am still using upwork. Can you please reopen and sort payment? Thanks