[HOLD for payment 2024-07-22] [$250] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] Workspace - Inconsistent delete modal display and brief error when deleting a user

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.3-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

issue found when executing PR #44008

Action Performed:

Precondition:
Create Control workspace in OldDot, make sure you can see it in NewDot
In OldDot, make sure the Control workspace has "Advanced Approvals" set up (on the workspace settings -> Members tab)
In OldDot, Add at least 2 other members (non-admin)
In OldDot, Set up 1 of the members (Member A) as the submitsTo of the other member (Member B)

in NewDot

1. Go to the control WS created above
2. Open member page
3. Select user A and click on remove
4. Verify that the confirm modal appears with the warning prompt [Selected member] is an approver in this workspace. When you unshare this workspace with them, we'll replace them in the approval workflow with the workspace owner, [Workspace Owner].
5. Open the member detail page of member A
6. Click on Remove from workspace button
7. Verify that the confirm modal appears with the same warning prompt in the step 4
8. Click on remove
9. Verify that the user is removed from the WS

Expected Result:

The delete modal should consistently display the same user identifier (either "Username" or "Email") on both the list member page and the detail page. No error should appear when deleting a user

Actual Result:

Inconsistent delete modal display and brief error when deleting a user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6527483_1719585222590.2024-06-28_17-35-23.mp4

Bug6527483_1719585222605.2024-06-28_17-22-15.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @greg-schroeder

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01be201c5b6d5fc51e
• Upwork Job ID: 1811099866306463912
• Last Price Increase: 2024-07-10

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Not a web-e blocker, looks like this is caused by #44008

[Beamanator]

@nkdengineer it looks like your PR #44008 isn't working perfectly in a few conditions, can you please take a look at this?

[nkdengineer]

It's fixed by @yuwenmemon

[Beamanator]

oh i should have looked at linked PRs 😅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Use policy owner details in employee removal confirmation modal #44654

If no regressions arise, payment will be issued on 2024-07-10. 🎊

[ikevin127]

I'm the only one requiring payment here for C+ review of PR: #44654 (comment).

@yuwenmemon When you get a chance, mind adding the Bug label to this issue for payment ?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Use policy owner details in employee removal confirmation modal #44654

If no regressions arise, payment will be issued on 2024-07-17. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@yuwenmemon] The PR that introduced the bug has been identified. Link to the PR: feat: Display warning prompt when removing an approver from a control policy #44008
• [@yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@yuwenmemon] Determine if we should create a regression test for this bug.
• [@yuwenmemon] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

@greg-schroeder Payment is due today (10th) as this was deployed to production manually in 9.0.3-7 (reference).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01be201c5b6d5fc51e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[greg-schroeder]

Sent you an offer @ikevin127

[ikevin127]

@greg-schroeder Accepted, thank you!

[greg-schroeder]

Paid

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Use policy owner details in employee removal confirmation modal #44654

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] The PR that introduced the bug has been identified. Link to the PR:
• [@hungvu193] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hungvu193] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hungvu193] Determine if we should create a regression test for this bug.
• [@hungvu193] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: