[PAUSED][$250] Web - Unable to create a split expense with a large number of room members #42562

lanitochka17 · 2024-05-23T21:04:57Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41077

Action Performed:

Log in with a new expensifail account
Create a workspace
Create a room
Invite 30 expensifail users
Navigate to the room
Create a manual split expense with a large number
Set the priority to "Most recent"
Open any of the created chats from the LHN

Expected Result:

I should be able to create the split expense without any errors

Actual Result:

Unable to create a split expense with a large number of room members with a new account. For the new chats I get "Unexpected error creating this chat, please try again later." error. For the split in the room, I get "Unexpected error submitting this expense. Please try again later." error
I also get a "Failed to load resource: the server responded with a status of 403 ()" console error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6489845_1716495220190.bandicam_2024-05-23_22-06-06-473.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cb679b7ebce4149e
Upwork Job ID: 1798422926054946284
Last Price Increase: 2024-07-31

Issue Owner

Current Issue Owner: @sobitneupane

melvin-bot · 2024-05-23T21:05:06Z

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-05-23T21:05:35Z

@slafortune I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-05-23T21:05:55Z

We think that this bug might be related to #vip-split

slafortune · 2024-05-23T22:07:29Z

on vacation until June 4th - reassigning this.

melvin-bot · 2024-05-23T22:07:50Z

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

slafortune · 2024-05-23T22:10:37Z

Sounds like I'll readd myself to this as well and take it back on the 4th. I didn't add myself back to any that have been assigned where I was unable to look at them at all.

Hey @slafortune , as an fyi for OOO re-assignments, you're supposed to add an additional assignee, but stay assigned so you can take the issue back over once you're back from OOO (assuming it's still open). Here's the relevant SO where the process is outlined.

I'm going to re-add you to the issue, but happy to tackle it while you're OOO!

nkdengineer · 2024-05-24T04:43:43Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to create a split expense with a large number of room members with a new account. For the new chats I get "Unexpected error creating this chat, please try again later." error. For the split in the room, I get "Unexpected error submitting this expense. Please try again later." error
I also get a "Failed to load resource: the server responded with a status of 403 ()" console error

What is the root cause of that problem?

When we invite new user to the room, report?. participants still contains optimistic accountID and then when we create a split expense, we set the participants incorrectly here which makes SplitBill API fails

App/src/libs/actions/IOU.ts

Lines 6511 to 6514 in 8375abe

    
           const chatReportOtherParticipants = Object.keys(chatReport?.participants ?? {}) 
        
               .map(Number) 
        
               .filter((accountID) => accountID !== currentUserAccountID); 
        
           participants = chatReportOtherParticipants.map((accountID) => ({accountID, selected: true}));

What changes do you think we should make in order to solve the problem?

We should use the same way as we do to get the member in RoomMembersPage here to get the correct participants of the report

const chatReportOtherParticipants = ReportUtils.getVisibleChatMemberAccountIDs(report?.reportID ?? '0').flatMap((accountID) => {
    const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString());
    return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : [];
});

App/src/libs/actions/IOU.ts

Lines 6511 to 6514 in 8375abe

    
           const chatReportOtherParticipants = Object.keys(chatReport?.participants ?? {}) 
        
               .map(Number) 
        
               .filter((accountID) => accountID !== currentUserAccountID); 
        
           participants = chatReportOtherParticipants.map((accountID) => ({accountID, selected: true}));

What alternative solutions did you explore? (Optional)

NA

melvin-bot · 2024-05-27T18:46:44Z

@slafortune, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2024-05-31T18:13:19Z

@slafortune, @zanyrenney Still overdue 6 days?! Let's take care of this!

melvin-bot · 2024-06-04T21:27:03Z

@slafortune, @zanyrenney 10 days overdue. Is anyone even seeing these? Hello?

slafortune · 2024-06-05T18:33:24Z

Looks like we were both out - sorry for the delay!

melvin-bot · 2024-06-05T18:33:35Z

Job added to Upwork: https://www.upwork.com/jobs/~01cb679b7ebce4149e

melvin-bot · 2024-06-05T18:33:39Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

melvin-bot · 2024-06-06T18:05:26Z

@slafortune @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

sobitneupane · 2024-06-07T08:24:34Z

Thanks for the proposal @nkdengineer

So, the issue arises if there is any new member(no previous interaction) in the room, right?

Actions Performed should be:

Log in
Create a workspace
Create a room
Invite a user with whom you have no previous interaction
Navigate to the room
Create a manual split expense
Open any of the created chats from the LHN

nkdengineer · 2024-06-07T08:33:50Z

@sobitneupane Yes, to easier to reproduce this bug we can offline when we invite the member to the room (or invite member quickly before we get the personal detail of user when we search to invite) and online to do the next step that you mentioned above.

sobitneupane · 2024-06-10T04:42:36Z

@saracouto @slafortune Should I hold the proposal review for now? The status of the issue is Paused and priority is monthly.

nkdengineer · 2024-06-12T09:14:27Z

@saracouto Why we add Monthly label here?

melvin-bot · 2024-06-12T16:00:13Z