[$500] Missing fields still shows error message even after selecting required fields

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @luacmartins
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705808628895589

Action Performed:

Precondition : Have some violation rules for the expenses in the OD

1. Create an expense report
2. Open the receipt to view the details
3. enter the required fields values (in this case category and tag fields)

Expected Result:

Error message should go away

Actual Result:

Error message still appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01724bf6068307f162
• Upwork Job ID: 1749663634886561792
• Last Price Increase: 2024-01-23

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01724bf6068307f162

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[wildan-m]

How can we add a violation rule in OD? This is how OD workspace setting looks in my account

[wildan-m]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Missing fields still shows error message even after selecting required fields

What is the root cause of that problem?

We are not adding category/tag value to the error props

What changes do you think we should make in order to solve the problem?

We can add corresponding value to error props:

                    {shouldShowCategories && (
                        <MenuItemWithTopDescription
                            shouldShowRightIcon={!props.isReadOnly}
                            title={props.iouCategory}
                            description={translate('common.category')}
                            numberOfLinesTitle={2}
                            onPress={() => {
                                if (props.isEditingSplitBill) {
                                    Navigation.navigate(ROUTES.EDIT_SPLIT_BILL.getRoute(props.reportID, props.reportActionID, CONST.EDIT_REQUEST_FIELD.CATEGORY));
                                    return;
                                }
                                Navigation.navigate(ROUTES.MONEY_REQUEST_CATEGORY.getRoute(props.iouType, props.reportID));
                            }}
                            style={[styles.moneyRequestMenuItem]}
                            titleStyle={styles.flex1}
                            disabled={didConfirm}
                            interactive={!props.isReadOnly}
                            rightLabel={canUseViolations && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''}
                            brickRoadIndicator={shouldDisplayFieldError && !props.iouCategory && canUseViolations && Boolean(props.policy.requiresCategory)? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}
                            error={(shouldDisplayFieldError && !props.iouCategory && canUseViolations && Boolean(props.policy.requiresCategory)) ? translate('common.error.fieldRequired') : ''}
                        />
                    )}
                    {shouldShowTags && (
                        <MenuItemWithTopDescription
                            shouldShowRightIcon={!props.isReadOnly}
                            title={props.iouTag}
                            description={policyTagListName}
                            numberOfLinesTitle={2}
                            onPress={() => {
                                if (props.isEditingSplitBill) {
                                    Navigation.navigate(ROUTES.EDIT_SPLIT_BILL.getRoute(props.reportID, props.reportActionID, CONST.EDIT_REQUEST_FIELD.TAG));
                                    return;
                                }
                                Navigation.navigate(ROUTES.MONEY_REQUEST_TAG.getRoute(props.iouType, props.reportID));
                            }}
                            style={[styles.moneyRequestMenuItem]}
                            disabled={didConfirm}
                            interactive={!props.isReadOnly}
                            rightLabel={canUseViolations && Boolean(props.policy.requiresTag) ? translate('common.required') : ''}
                            brickRoadIndicator={shouldDisplayFieldError && !props.iouTag && canUseViolations && Boolean(props.policy.requiresTag)? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}
                            error={(shouldDisplayFieldError && !props.iouTag && canUseViolations && Boolean(props.policy.requiresTag)) ? translate('common.error.fieldRequired') : ''}
                        />
                    )}

or PolicyUtils.getCleanedTagName(iouTag) for tag

Apply it for MoneyTemporaryForRefactorRequestConfirmationList and MoneyRequestConfirmationList files

What alternative solutions did you explore? (Optional)

[situchan]

cc: @cead22 as violation related

[wildan-m]

Proposal Updated

Mention the related files, add PolicyUtils.getCleanedTagName for tag

[wildan-m]

Proposal Updated

Fix props, not rightLabel, but error props

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message still appears

What is the root cause of that problem?

When we edit the category or tag field we don't clear the transaction violation for this field

What changes do you think we should make in order to solve the problem?

When we update any field we should clear the transaction violation message of this field in optimistic data and maybe BE also needs to update as well.

What alternative solutions did you explore? (Optional)

NA

[paultsimura]

This is basically a dupe of #34541, and if it is decided to be fixed Externally, my proposal is the first in the queue 👀

[luacmartins]

Thanks for pointing that out @paultsimura! I think we can close this issue in favor of #34541. Thanks for the proposals everyone!