[$500] IOU - Created IOU is not displayed on LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.27-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login as User A with expensify account
2. Navigate to User B conversation> Create Money request
3. Navigate to LHN

Expected Result:

Created IOU should be displayed on LHN

Actual Result:

Created IOU is not displayed on LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6346861_1705602506674.az_recorder_20240118_152241.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188517c573d780717
• Upwork Job ID: 1748067009116999680
• Last Price Increase: 2024-02-08

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188517c573d780717

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[lanitochka17]

#vip-vsb

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When creating a money request, IOU report isn't displayed in LHN

What is the root cause of that problem?

We hide the muted chats intentionally in this PR #22717
Later we hide the hidden chats in this PR #25618

When creating a money request, notificationPreference is set to hidden by backend

This is the root cause

What changes do you think we should make in order to solve the problem?

I'm not sure why we didn't show reports with notificationPreference = hidden. I think we should hide muted reports
Update

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 90 to 93 in 31b19ea

	const isHidden = optionItem.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;
	if (isHidden && !props.isFocused && !optionItem.isPinned) {
	return null;
	}

to

    const isMuted = optionItem.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE;
    if (isMuted && !props.isFocused && !optionItem.isPinned) {
        return null;
    }

This works as expected

Result

34757.mp4

What alternative solutions did you explore? (Optional)

Option 1
The backend doesn't set the notificationPreference to hidden

Option 2
We don't hide the hidden IOU report while hide the hidden report

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Created IOU is not displayed on LHN

What is the root cause of that problem?

The IOU report has notificationPreference is hidden when we build the optimistic data and BE also return it as hidden by default.

App/src/libs/ReportUtils.ts

Line 2720 in 991a4e2

notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,

App/src/libs/ReportUtils.ts

Line 2678 in 991a4e2

notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,

What changes do you think we should make in order to solve the problem?

Change the default notificationPreference of IOU report as CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS and BE should fix this as well.

I know that it's intentional before but I think we shouldn't hide the IOU report by default.

App/src/libs/ReportUtils.ts

Line 2720 in 991a4e2

notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,

App/src/libs/ReportUtils.ts

Line 2678 in 991a4e2

notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,

What alternative solutions did you explore? (Optional)

NA

[Santhosh-Sellavel]

@dukenv0307 proposal fixes the bug for the offline cases. Yeah, we need to fix this at BE as well.

Can you assign @kevinksullivan an internal label here to get the BE issue fixed?

Not sure whether we need an FE fix, will decide once BE gets fixed.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Santhosh-Sellavel]

bump @kevinksullivan

[melvin-bot]

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

[kevinksullivan]

We no longer auto-assign internal members of the team, but since this is an IOU issue I think it should go in the VIP split project. Getting clarity on this here

https://expensify.slack.com/archives/C05RECHFBEW/p1706308265886739

[youssef-lr]

I think this was fixed, I can't reproduce it.

[Santhosh-Sellavel]

I'm unavailable next week, Please assign a new C+ Issue here if required while I am away, thanks!

cc: @kevinksullivan

[dukenv0307]

@kevinksullivan I'm still able to reproduce this on the latest main.

Screen.Recording.2024-01-30.at.18.01.53.mov

[youssef-lr]

That's by design @dukenv0307 to reduce clutter in the LHN.

[dukenv0307]

Thanks for your response. Got it now.

[kbecciv]

issue is reproducible on build 1.4.34.0, reopening!

bandicam.2024-02-01.02-58-03-805.mp4

[melvin-bot]

@kevinksullivan @Santhosh-Sellavel this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@kevinksullivan, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

[Santhosh-Sellavel]

Waiting for internal user to pick

[dukenv0307]

@kbecciv I think we can close this, it's confirmed is expected design here #34757 (comment).

[melvin-bot]

@kevinksullivan @Santhosh-Sellavel this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@kevinksullivan, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@kevinksullivan, @Santhosh-Sellavel 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@kevinksullivan @Santhosh-Sellavel this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@kevinksullivan, @Santhosh-Sellavel 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@kevinksullivan, @Santhosh-Sellavel 12 days overdue now... This issue's end is nigh!