[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Title of cancelled expense report shows "Canceled" then back to "owes x"

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. [Member] Request money in the workspace chat.
2. [Member] Go to expense report.
3. [Admin] Pay the request.
4. [Admin] Cancel the payment.

Expected Result:

The expense report title shows "paid amount · Canceled" in LHN and report

Actual Result:

The expense report title shows "paid amount · Canceled" briefly then back to "owes amount" in LHN and report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345800_1705525332732.bandicam_2024-01-18_00-58-32-760.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

The expense report title shows "paid amount · Canceled" briefly then back to "owes amount" in LHN and report

Ok, I observed this while following the test steps. Not really sure if it's a blocker considering you'd have to catch this happening in realtime.

The app eventually lands in the correct state. Will check to see if there are any obvious PRs that could have caused this.

[marcaaron]

cc @Gonals this is the only PR obviously related to cancelling payments #33836

Still gonna remove the blocker, but maybe you will want to follow up here.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #33836 from Expensify/alberto-unpay2" #34697

If no regressions arise, payment will be issued on 2024-01-25. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #33836 from Expensify/alberto-unpay2" #34697

If no regressions arise, payment will be issued on 2024-01-26. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Hey, @marcaaron, do I need to process contributor payments here? There's no one assigned. Thanks!

[marcaaron]

Hmm I'm not really sure tbh. It looks like maybe the PR causing this was reverted. I'm just going to assume that there's no further action to take here and close this one for now.

[isabelastisser]

Thanks, Marc!