[HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] [$500] Create new command for Payment cancelling in "Paid Elsewhere" reports

[Gonals]

Problem
Currently, we have no way to revert an existing payment in NewDot. This is part of our core functionality and something we should be able to do.

Solution
Let's add that functionality as discussed here. We'll start by adding it for "Paid Elsewhere" reports, as it is simpler and will give us the core structure of the command and the UI, and move to "Paid in Expensify" reports in a follow-up issue.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0fd3da0a160792d
• Upwork Job ID: 1731661662582071296
• Last Price Increase: 2024-01-05

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0fd3da0a160792d

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

[michaelhaxhiu]

Seems @Gonals made a PR on HOLD to fix this GH here - #32674 (comment)

I'm guessing we want to proceed with internal handling and just wait a little on the fix.

[Gonals]

Seems @Gonals made a PR on HOLD to fix this GH here - #32674 (comment)

I'm guessing we want to proceed with internal handling and just wait a little on the fix.

Yep, this requires development from Auth to App 😁

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

The PR has caused numerous deploy blockers in App:

• [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - Message for cancelation is not copied and "owes" message is copied as "paid" #33507
• [$125] Cancel payment - "Cancel payment" in three-dot menu is not translated to Spanish #33513
• Cancel payment - "Auth CancelReimbursement" error shows up when cancelling payment with Expensify #33540
• Cancel payment - IOU preview and report title display "Canceled" when canceled payment is repaid #33508
• [HOLD for payment 2024-01-26] [HOLD for payment 2024-01-25] Cancel payment - IOU is still marked as paid when payment is canceled unless report is revisited #33509

Some might be considered as not a blockers but I think given the number of these and that the author is ooo I will revert the PR and we can just fix this in the second attempt

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Cancel Payment command (again) #33836

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[Gonals]

Man, this is being more of a pain than expected. Bringing some discussions to Slack

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.27-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create Cancel Payment command (again) #33836

If no regressions arise, payment will be issued on 2024-01-26. 🎊

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[zanyrenney]

@michaelhaxhiu please handle the payment when you get a chance!

[michaelhaxhiu]

There is no payment here! And no need for regression steps IMO (it's not a regression from a bug, it's a new feature).

[Ollyws]

@michaelhaxhiu I did review #33836, so payment is due there but there were regressions so the 50% penalty applies. Thanks!

[Ollyws]

Friendly bump on the above @michaelhaxhiu

[Ollyws]

Just been looking through some old notes and realized this one still hasn't been paid. @mallenexpensify Any chance you could help with this? Thanks!

[mallenexpensify]

@Ollyws sorry about that, glad you caught it!
can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01f578768b7177142d

[Ollyws]

@mallenexpensify I'll request via ND if that's alright, thanks!

[mallenexpensify]

@Ollyws you were asked to review in January so we need to pay via Upwork
#33836 (comment)

Please rescind your NewDot request. It's best practice to wait for the BZ payment summary before requesting funds via NewDot. Thx

[Ollyws]

@mallenexpensify Ahh no problem I didn't make a ND request yet. Accepted, thanks!

[mallenexpensify]

Contributor: @Ollyws paid $500 via Upwork

Apologies again for the lonnnnng delay here @Ollyws