[$500] Android – Request – “Next step” is partly visible in the WS with IOU if device font size is larger

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.21-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Make a device font size larger than the default
4. Navigate to the WS with IOU
5. Open IOU page

Expected Result:

“Next step” is fully visible in the WS with IOU if device font size larger than the default .

Actual Result:

“Next step” is partly visible in the WS with IOU if device font size larger than the default .

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332086_1704370958458.Next_steps.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cae7b1feabc7d940
• Upwork Job ID: 1742891222581362688
• Last Price Increase: 2024-01-18

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cae7b1feabc7d940

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When we increase device font size, the Next Step text is partially visible because it's really big.

What is the root cause of that problem?

In the Next Step font size dynamically increases as we increase the system font size. We actually use a textMicroBold style for the Next Step text and the max font size for it is 17.

App/src/components/MoneyReportHeaderStatusBar.tsx

Line 27 in d5f5856

<Text style={[styles.textLabel, styles.textMicroBold]}>{translate(nextStep.title === CONST.NEXT_STEP.FINISHED ? 'iou.finished' : 'iou.nextStep')}</Text>

App/src/styles/index.ts

Lines 375 to 379 in d5f5856

	textMicroBold: {
	color: theme.text,
	fontWeight: fontWeightBold,
	fontFamily: fontFamily.EXP_NEUE_BOLD,
	fontSize: variables.fontSizeSmall,

App/src/styles/variables.ts

Line 49 in d5f5856

fontSizeSmall: getValueUsingPixelRatio(11, 17),

But we use RN Text component to render the Next Step, not our custom Text. Our custom text disable the system font scaling and handle it manually.

What changes do you think we should make in order to solve the problem?

Replace RN Text with our custom Text component. However, it still can't find the width of the badge.

We can either create a static font size specifically for the Next Step or set a bigger max width and/or max height or dynamic width and height for the Next Step badge (using getValueUsingPixelRatio).

[melvin-bot]

@johncschuster, @c3024 Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

@c3024 can you review the proposal above? Is it sufficient, or should we keep an eye out for more?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[c3024]

Have issues with building Android app. Will review ASAP.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@johncschuster @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@johncschuster, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

@c3024 how's your android build coming along? Are you still having trouble with it?

[c3024]

@bernhardoj 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mkhutornyi]

Is this still reproducible? Seems fixed in #34325

[c3024]

Yes, it's fixed. I've not pulled the latest main when I reviewed it. Thanks.

The issue can be closed.