[HOLD for payment 2024-01-04] [$500] Distance - App crash on start finish change

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.12-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Click on plus and click on request money
3. Click on distance
4. Interchange 'Start' and 'Finish' by drag and observe that app crashes

Expected Result:

App should not crash on interchanging 'Start' and 'Finish' in distance

Actual Result:

App crashes on interchanging 'Start' and 'Finish' in distance

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6311484_1702465343159.windows_chrome_-_app_crash_start_finish_change.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01573f0c0196ba5533
• Upwork Job ID: 1734923373233876992
• Last Price Increase: 2023-12-13
• Automatic offers:
• 0xmiroslav | Reviewer | 28052012
• bernhardoj | Contributor | 28052013

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01573f0c0196ba5533

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when dragging waypoints list.

What is the root cause of that problem?

The crash is caused because the waypoint here is null.

App/src/components/DistanceRequest/DistanceRequestRenderItem.js

Lines 70 to 71 in 1fd0989

	const waypoint = lodashGet(waypoints, [`waypoint${index}`], {});
	const title = waypoint.name || waypoint.address;

The reason it's null is because after we drag the waypoints, it will update the waypoints.

App/src/pages/iou/request/step/IOURequestStepDistance.js

Lines 139 to 149 in 1fd0989

	const updateWaypoints = useCallback(
	({data}) => {
	if (_.isEqual(waypointsList, data)) {
	return;
	}
	const newWaypoints = {};
	_.each(data, (waypoint, index) => {
	const newWaypoint = lodashGet(waypoints, waypoint, {});
	newWaypoints[`waypoint${index}`] = _.isEmpty(newWaypoint) ? null : newWaypoint;
	});

And if you notice, if the waypoint is empty, we set it to null. So, if we drag an empty waypoint (without an address set), it will crash.

What changes do you think we should make in order to solve the problem?

In the old request money page, we didn't set it to null.

App/src/components/DistanceRequest/index.js

Lines 193 to 197 in 1fd0989

	const newWaypoints = {};
	_.each(data, (waypoint, index) => {
	newWaypoints[`waypoint${index}`] = lodashGet(waypoints, waypoint, {});
	});

So, we need to do the same.

[0xmiros]

@bernhardoj's proposal looks good to me. Should have been deploy blocker.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @0xmiroslav

[CortneyOfstad]

@0xmiroslav any updates on the PR? Thank you!

[0xmiros]

PR was merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.18-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix app crash after dragging waypoints #32981

If no regressions arise, payment will be issued on 2024-01-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue — @bernhardoj was paid $500 via Upwork
• Contributor+ that helped on the issue and/or PR — @0xmiroslav was paid $500 via Upwork

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @0xmiroslav requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

Payments have been completed!

Any update on the checklist @0xmiroslav? Thanks!

[0xmiros]

The regression came from huge money request refactor.
We can skip new regression test as this was caught by QA team.

[CortneyOfstad]

Sounds good! Closing!