[$500] Bank account - After adding VB account, tapping on card shows locked feature page for a second

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-condition : Must have a verified BA

1. Launch app
2. Tap profile icon
3. Tap Workspaces---Workspace
4. Tap Bank account and note added verified bank account
5. Tap back arrow in app
6. Tap card

Expected Result:

After adding Verified Bank account, tapping on card must not show locked feature page for a second also

Actual Result:

After adding Verified Bank account, tapping on card shows locked feature page for a second

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6302492_1701818517117.az_recorder_20231206_025125.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e3a966505364f4b0
• Upwork Job ID: 1732203633096806400
• Last Price Increase: 2023-12-06
• Automatic offers:
• shubham1206agra | Reviewer | 28033542
• dukenv0307 | Contributor | 28033543

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e3a966505364f4b0

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After adding Verified Bank account, tapping on card shows locked feature page for a second

What is the root cause of that problem?

We're not having loading status while we're loading the VBA here, so initially when coming to that page, it will show the WorkspaceCardNoVBAView because it uses the stale achState value.

After the data is fetched, the achState is up do date and it switch to the correct screen.

What changes do you think we should make in order to solve the problem?

Add loading status while we're loading the VBA. We can add in Onyx data, while the API call to fetch is ongoing, isLoading will be true and we'll show a loading screen. Only after the VBA state is successfully determined and hasVBA is still fase, we'll show the WorkspaceCardNoVBAView.

We already do the same for the ReimbursementAccountPage here.

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-12-06.at.14.55.06.mov

[shubham1206agra]

Thanks for the proposal @dukenv0307
Would you please add a video for the same?

[dukenv0307]

@shubham1206agra Updated.

[bernhardoj]

Just sharing some information, when we complete the BA setup, we should already have the achData, so visiting the cards page should show the unlocked feature list. However, we always clear the data when closing the BA page (step 5) (this is the same root cause as #31030).

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 281 to 283 in 5a0b7fd

	return () => {
	BankAccounts.clearReimbursementAccount();
	};

[shubham1206agra]

Just sharing some information, when we complete the BA setup, we should already have the achData, so visiting the cards page should show the unlocked feature list. However, we always clear the data when closing the BA page (step 5) (this is the same root cause as #31030).

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 281 to 283 in 5a0b7fd

	return () => {
	BankAccounts.clearReimbursementAccount();
	};

@bernhardoj Will #31030 fix this problem too?

[bernhardoj]

@shubham1206agra if my solution is picked in #31030, then yes

[shubham1206agra]

I have thought about this. Let us go for @dukenv0307's proposal as ReimbursementAccountPage also has loading spinner, and it will be nice to have the same here too.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

Awaiting final approval from @techievivek

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

Sorry for the delay, assigend the GH to @dukenv0307

[dukenv0307]

@shubham1206agra The PR is ready for review.

[melvin-bot]

This issue has not been updated in over 15 days. @michaelhaxhiu, @techievivek, @shubham1206agra, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dukenv0307]

@michaelhaxhiu I think Melvin was OOO for a while, this is ready for payment, it's deployed to production 3 weeks ago.

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[greg-schroeder]

Okay taking this from @michaelhaxhiu, lemme catch up

[greg-schroeder]

Looks like this wasn't paid but the Upwork job is closed. I'll create a payment issue to get that generated and pay you two out ASAP, apologies for the delay.

[greg-schroeder]

@dukenv0307 you already accepted your original offer so I just paid that. @shubham1206agra you can accept the new one and I'll pay that, then we're g2g. 👍