[DISTANCE] LOW: UpdateDistanceRequest 1:1:1 - UpdateMoneyRequestDescription - Split out into its own command

[tgolen]

There will be three pieces to this:

• Auth: Using the logic from EditMoneyRequest, create a new command called UpdateMoneyRequestDescription following the example in https://github.com/Expensify/Auth/pull/8986
• Web-E: Add a new API endpoint called UpdateMoneyRequestDescription following the example in https://github.com/Expensify/Web-Expensify/pull/39445
• App: Implement the new API command following the example in Implement new UpdateMoneyRequestDate API endpoint #30737

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0166ac586517ecf2dd
• Upwork Job ID: 1730346767459143680
• Last Price Increase: 2023-11-30

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0166ac586517ecf2dd

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

[chiragsalian]

Handing this over to @NikkiWines. I have an auth PR in draft and you can continue from it. it seems to work fine in my testing. I tested it via a test.php file having,

$params = [
    "authToken" => "<authToken>",
    "transactionID" => "2390656467468356405", // a transaction the user has access to
    "modifiedExpenseReportActionID" => 8299677307715651178, // a random reportActionID, with every test call increment this by 1.
    "comment" => "test one five",
];

Auth::updateMoneyRequestDescription($params); // create a simple auth updateMoneyRequestDescription method to call the auth endpoint.

and confirmed it updates the comment just fine.

sqlite> select comment from transactions where transactionID = 2390656467468356405;
comment
----------------------------------------------
{"comment":"test one five","test":"something"}

i added the test something to confirm other parts of the comment are not lost and just the comment bit is updated.
the report action looks fine on newDot too.

So things remaining

1. Auth tests
2. Web and newDot code to split it into its own command.

Hit me up on newDot if you have any questions.

[chiragsalian]

oh i just remembered another remaining item and i.e., to maybe return or send a push notification of commentJSON so that the client gets the changes.

[NikkiWines]

Planning on tackling this during the week

[NikkiWines]

Auth PR is ready for review, will follow up with Web-E and App PRs tomorrow

[NikkiWines]

Auth PRs been updated, Web-E and App PRs are WIPs!

[NikkiWines]

• Auth PR: https://github.com/Expensify/Auth/pull/9385
• Web PR: https://github.com/Expensify/Web-Expensify/pull/40392
• App PR: Add updateMoneyRequestDescription command #33997 in review

[NikkiWines]

Noting here that we'll need to remove this comment before this issue can be fully closed out. @tgolen since all of the UpdateMoneyRequest<X> commands will have this same comment, is there an issue that covers updating these instances so they don't stay as perpetual todos in our code?

[aldo-expensify]

is there an issue that covers updating these instances so they don't stay as perpetual todos in our code?

Maybe we should create a single issue to deal with all of them together later. I'm just guessing that after moving the logic needed from PHP to cpp for one, fixing the others will be trivial.

I would close all these individual separate GH issues after creating the proposed GH issue.

[tgolen]

Ah, that's a good point. I think that comment should be removed from the code and we should create a GH issue to move those updates to Auth at some point. I don't know when it will be valuable to move them.

I agree with Aldo that once the work is done to move the updates for one command, that will be 99% of the work.

[NikkiWines]

This is all done!