[HOLD for payment 2023-11-27] [$500] PDF preview - Eye icon to show password on password protected PDF file is not working

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Pre-requisite: user should be logged in and must have sent a password protected PDF to any chat.

1. Tap on the password protected PDF preview on the chat.
2. Tap on "enter the password".
3. Type some characters.
4. Tap on the eye icon to reveal the password.

Expected Result:

The password should be revealed and visible to the user.

Actual Result:

The eye icon is not responsive, does nothing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269631_1699514072739.Daso5632_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017fc5a55459d7aad0
• Upwork Job ID: 1722545035115692032
• Last Price Increase: 2023-11-09
• Automatic offers:
• tienifr | Contributor | 27592501

Issue Owner

Current Issue Owner: @peterdbarkerUK

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017fc5a55459d7aad0

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[izarutskaya]

Issue is not reproducible in production

20231109_150413.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

PDF preview - Eye icon to show password on password protected PDF file is not working

What is the root cause of that problem?

This issue is introduced by #24482 where pointerEvents="box-none" attribute in View compenent here is replaced with below style object

App/src/styles/pointerEventsBoxNone/index.ts

Lines 3 to 5 in 8c3e3bc

	const pointerEventsNone: PointerEventsBoxNone = {
	pointerEvents: 'box-none',
	};

But they are not exactly the same thing and we don't have box-none value for pointerEvents style attribute as documented here https://reactnative.dev/docs/view#pointerevents pointerEvents="box-none" is more like this:

.box-none {
     pointer-events: none;
}
.box-none * {
     pointer-events: auto;
}

What changes do you think we should make in order to solve the problem?

We should revert this change and just apply pointerEvents="box-none" for all the instances

What alternative solutions did you explore? (Optional)

[mananjadhav]

@alitoshmatov's proposal is correct. Not sure if this would be treated as a Deploy Blocker.

@danieldoglas let me know we're okay to proceed with the proposal or solve as a regression.

[alitoshmatov]

From https://github.com/necolas/react-native-web/releases/tag/0.19.0

[add] Add support for pointerEvents style.

...

[change] Deprecate pointerEvents prop. Use pointerEvents style.

But as we can see https://reactnative.dev/docs/view-style-props#pointerevents is not deprecated in react native itself, also pointerEvents style already exists, thus conflicting with each other. I think deprecating pointerEvents of View component in react-native-web was not a good idea. They should keep supporting any attribute that exists in react native.

[aimane-chnaif]

@getusha can you please check this?

[getusha]

There is a box-none value e.g. https://github.com/necolas/react-native-web/blob/a3ea2a0a4fd346a1b32e6cef527878c8e433eef8/packages/react-native-web/src/exports/AppRegistry/AppContainer.js#L53

https://github.com/necolas/react-native-web/blob/a3ea2a0a4fd346a1b32e6cef527878c8e433eef8/packages/react-native-web/src/modules/createDOMProps/index.js#L29-L42

I doubt they will add it if it doesn't exist.

[tienifr]

I'm available to raise a fix PR immediately if assigned, this is a pretty serious issue.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The eye icon is not responsive, does nothing.

This starts appearing after this PR is merged

What is the root cause of that problem?

There's a box-none value in RN web but currently it's implemented incorrectly. Currently the child elements of it 's implemented like parent > *: { pointer-events: auto } (see here) which only affects direct children. So the grand-children will still inherit the pointer-events: none, which makes the eye not responsive.

What changes do you think we should make in order to solve the problem?

Fix upstream in RN web, update to the pattern parent *: { pointer-events: auto } so it affects all children. That means updating the >* to * in this line

This is recommended in the RN doc as well https://reactnative.dev/docs/view#pointerevents.

In the meantime when the fix is not yet merged to upstream, we can create a fork/a patch-package change to apply it in our App code.

What alternative solutions did you explore? (Optional)

The box-only likely has the same issue here, we can fix for it as well.

[tienifr]

@mananjadhav please consider my proposal above as well, thanks!

[getusha]

I think we can fix this by simply adding styles.pointerEventsAuto to the Checkbox component in BaseTextInput

[tienifr]

I think we can fix this by simply adding styles.pointerEventsAuto to the Checkbox component in BaseTextInput

it will work but it's a workaround

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 31101 Eye icon to show password on password protected PDF file is not working #31176

If no regressions arise, payment will be issued on 2023-11-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR: Upgrade to react-native-web v0.19.9 #24482

• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Upgrade to react-native-web v0.19.9 #24482 (comment)

• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• [@mananjadhav] Determine if we should create a regression test for this bug. Y

• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

• Tap on the password protected PDF preview on the chat.

• Tap on "enter the password".

• Type some characters.

• Tap on the eye icon to reveal the password.

• The password should be revealed and visible to the user.

• Verify that no errors appear in the JS console

• [@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[peterdbarkerUK]

Payment summary:

• Contributor: $500 to @tienifr via UpWork (Job closed)

• Contributor+ @mananjadhav please request payment for $500 for the review.

@JmillsExpensify

[peterdbarkerUK]

@mananjadhav could you review the regression checklist? This feels like something we should add to TestRail

[mananjadhav]

I think we have the PR here as the offending PR.

Though I think this would've been difficult to detect considering it was an external package upgrade. I agree we should add a regression test for this one. The Test steps from the PR look good to me. wdyt @danieldoglas @peterdbarkerUK ?

[JmillsExpensify]

$500 payment approved for @mananjadhav based on this comment.

[danieldoglas]

Agreed we should make this a regression test @peterdbarkerUK

[peterdbarkerUK]

Agreed! Dashing out, will take care of it tomorrow

[melvin-bot]

@JmillsExpensify, @mananjadhav, @danieldoglas, @peterdbarkerUK, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[peterdbarkerUK]

I need to hard-prioritise something else today, so this will now be a Wednesday job.

[peterdbarkerUK]

Blackholing a star notification

[melvin-bot]

@JmillsExpensify, @mananjadhav, @danieldoglas, @peterdbarkerUK, @tienifr Eep! 4 days overdue now. Issues have feelings too...

[peterdbarkerUK]

Ooop, I had this all written out and never hit submit, I clearly got distracted end of last week. All done!