[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$250] Distance - App crashes when tapping on the receipt thumbnail while receipt is generating

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch New Expensify app
2. Go to + > Request money > Distance > Create a distance request
3. Go to distance request details page
4. Tap on the receipt thumbnail before the map image is generated

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6224575_1696421736016.Screen_Recording_20231004_034841_New_Expensify.mp4

log.txt

Production

Screen_Recording_20231004_214101_New.Expensify.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01812bc33ae4579c27
• Upwork Job ID: 1709571574970191872
• Last Price Increase: 2023-10-04
• Automatic offers:
• paultsimura | Contributor | 27024406

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01812bc33ae4579c27

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Upwork job price has been updated to $250

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the Distance request image is pending, opening the receipt image crashes the App.
Note: this is easier to reproduce if we simply switch to offline mode.

What is the root cause of that problem?

On native, the pending attachment uses a static image, and it has the source: 1 (that's a standard RN, see this), which is not a string so it breaks the Str.isPDF() and Str.isImage() checks.

What changes do you think we should make in order to solve the problem?

In AttachmentView, we need to make a couple of safety checks:

+ if ((_.isString(source) && Str.isPDF(source)) || (file && Str.isPDF(file.name || translate('attachmentView.unknownFilename')))) {
- if (Str.isPDF(source) || (file && Str.isPDF(file.name || translate('attachmentView.unknownFilename')))) {

+    const isImage = typeof source === 'number' || Str.isImage(source);
-    const isImage = Str.isImage(source);

This will be better fixed in this PR: #27204
But as a blocker fix, it should be good enough.

Result:

distance-offline.mp4

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Reviewer role ($250)

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Thanks @paultsimura can you raise a PR and make it ready for review please?

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sonialiap]

I'm OOO Oct 16-23. Adding leave buddy

Status: waiting on checklist completion and possibly need to submit a regression test request

[rushatgabhane]

created a manual request - https://staging.new.expensify.com/r/4428559888912375

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Show eReceipts for distance requests #27204

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/27204/files#r1383171883

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again -N.A.

[JmillsExpensify]

$375 payment approved for @rushatgabhane based on BZ summary.

[sonialiap]

back from OOO, @rushatgabhane how's that checklist coming along? 😁

[melvin-bot]

@paultsimura, @sonialiap, @rushatgabhane, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

@rushatgabhane bump

[sonialiap]

@rushatgabhane bump

[sonialiap]

I think he might be OOO 🤔 there was a post about a resort in bali today

[sonialiap]

@rushatgabhane bump, please complete so that we can close this out #28814 (comment)

[rushatgabhane]

@sonialiap completed the checklist 😅

[sonialiap]

Thanks!