[HOLD for payment 2023-11-06] [$1000] Web - Profile - Atachment clip icon is displayed instead of spinner when avatar is loading

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://26772.pr-testing.expensify.com/.
2. Go to Settings > Click on the avatar.
3. Upload an image for avatar using the image attached (any image will do actually).
4. Click on the avatar > View photo.

Expected Result:

When the avatar is loading, a spinner will be shown.

Actual Result:

When the avatar is loading, an attachment clip icon is displayed instead.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.72-9 PR:26772

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6210425_bandicam_2023-09-22_18-10-46-646.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01117548f1220d1a72
• Upwork Job ID: 1706703351401648128
• Last Price Increase: 2023-10-16
• Automatic offers:
• situchan | Reviewer | 27284678
• mkhutornyi | Contributor | 27284682

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[izarutskaya]

Issue found when testing this PR #26772

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

@izarutskaya can we verify that this bug is reproducible on staging? I don't think we should be blocking deploy on something that we haven't verified happens on staging.

[jasperhuangg]

Gonna remove the Deploy Blocker label until it's verified on staging.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01117548f1220d1a72

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[favourch]

Kindly assign this to me.

[melvin-bot]

📣 @favourch! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Payment Summary:

This issue is eligible for an urgency bonus. It was created before the announcement removing the urgency bonus on Oct 24.
PR created on Oct 20
PR approved on Oct 20

@mkhutornyi requires payment offer (Contributor) - $1500 - PAID
@situchan requires payment offer (Reviewer) - $1500 - PAID

[johncschuster]

@situchan, can you complete the BZ checklist when you get a moment? Thank you!

[johncschuster]

@situchan bump!

[situchan]

Finding offending PR. Will complete checklist by Monday

[melvin-bot]

@johncschuster, @jasperhuangg, @mkhutornyi, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

@situchan were you able to find the offending PR?

[melvin-bot]

@johncschuster, @jasperhuangg, @mkhutornyi, @situchan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@johncschuster, @jasperhuangg, @mkhutornyi, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Refactor AttachmentModal to function component #20365
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/20365/files#r1402017696
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This is minor glitch and doesn't affect user previewing attachment so no need regression test. Also this was caught by Applause team

[melvin-bot]

@johncschuster, @jasperhuangg, @mkhutornyi, @situchan Eep! 4 days overdue now. Issues have feelings too...

[johncschuster]

@situchan bump!

[situchan]

@johncschuster is there anything pending from me?

[situchan]

Here's checklist

[jasperhuangg]

I believe we're good to close this out then? Everyone has been paid out and the BugZero checklist has been completed