[$500] Request money - Text input isn't auto focused after screen transition ends

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #27294

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Press FAB >> Request money >> Distance
   Choose Start & End locations >> Next

Expected Result:

Verify that the text input is auto focused after screen transition ends

Actual Result:

Text input isn't auto focused after screen transition ends

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70-2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6200485_27294_Safari.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfadaee4d9a59119
• Upwork Job ID: 1702347116753686528
• Last Price Increase: 2023-09-14

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text input isn't auto focused after screen transition ends when creating / editing a waypoint in the distance request waypoint editor

What is the root cause of that problem?

The screen entry transition end event handler in WaypointEditor doesn't always fire except the screen is at the top of the navigation stack.

App/src/pages/iou/WaypointEditor.js

Line 163 in 95c9e47

onEntryTransitionEnd={() => textInput.current && textInput.current.focus()}

What changes do you think we should make in order to solve the problem?

We are now using a new approach to autofocus text inputs upon launching a screen according to https://expensify.slack.com/archives/C01GTK53T8Q/p1694660990479979

Implement these changes in the WaypointEditor component.

1. Add the timeout ref and the useFocusEffect hook.

const focusTimeoutRef = useRef(null);
useFocusEffect(useCallback(() => {
    focusTimeoutRef.current = setTimeout(() => textInput.current && textInput.current.focus(), CONST.ANIMATED_TRANSITION);
    return () => {
        if (!focusTimeoutRef.current) {
            return;
        }
        clearTimeout(focusTimeoutRef.current);
    };
}, []));

2. Remove the onEntryTransitionEnd prop from the root ScreenWrapper for cleanup.

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bfadaee4d9a59119

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[Inspired715]

This works well in my end.
What's wrong with you?
Thanks.

[melvin-bot]

📣 @dev3606! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text input isn't auto focused after screen transition ends

What is the root cause of that problem?

We are using onEntryTransitionEnd on ScreenWrapper component.

App/src/pages/iou/WaypointEditor.js

Line 163 in 95c9e47

onEntryTransitionEnd={() => textInput.current && textInput.current.focus()}

onEntryTransitionEnd is only fired for the top card in the stack, and therefore does not fire on the new top card when popping a card off the stack.

What changes do you think we should make in order to solve the problem?

We need to add useFocusEffect hook and remove onEntryTransitionEnd from ScreenWrapper in WaypointEditor component.

import { useFocusEffect } from '@react-navigation/native';

const focusTimeoutRef = useRef(null);
useFocusEffect(useCallback(() => {
    focusTimeoutRef.current = setTimeout(textInputRef.current.focus, CONST.ANIMATED_TRANSITION);
    return () => {
        if (!focusTimeoutRef.current) {
            return;
        }
        clearTimeout(focusTimeoutRef.current);
    };
}, []));

What alternative solutions did you explore? (Optional)

NA

[Inspired715]

Based on the provided code, it seems that the problem is related to the use of the useFocusEffect hook and the onEntryTransitionEnd function in the ScreenWrapper component of the WaypointEditor component. To solve this problem, the following changes should be made: Remove the onEntryTransitionEnd function from the ScreenWrapper component. This function is no longer needed if we're using the useFocusEffect hook. Import the useFocusEffect hook from the appropriate library or module. Add the useFocusEffect hook inside the WaypointEditor component and wrap it around the code that involves focusing on the textInputRef.current element. Thanks. Kevin

…

Message ID: ***@***.***>

[Inspired715]

But I don't want get pay via a upwork. So sorry. Kevin

…

On Thu, Sep 14, 2023 at 12:53 PM Dev 3606 ***@***.***> wrote: Based on the provided code, it seems that the problem is related to the use of the useFocusEffect hook and the onEntryTransitionEnd function in the ScreenWrapper component of the WaypointEditor component. To solve this problem, the following changes should be made: Remove the onEntryTransitionEnd function from the ScreenWrapper component. This function is no longer needed if we're using the useFocusEffect hook. Import the useFocusEffect hook from the appropriate library or module. Add the useFocusEffect hook inside the WaypointEditor component and wrap it around the code that involves focusing on the textInputRef.current element. Thanks. Kevin > Message ID: ***@***.***> >

[sakluger]

This is a duplicate of #27202.

[Inspired715]

Thanks a lot.

…

On Thu, Sep 14, 2023 at 1:22 PM Sasha Kluger ***@***.***> wrote: Closed #27450 <#27450> as completed. — Reply to this email directly, view it on GitHub <#27450 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2P3B7EELJGVYZ5XRWGTCKDX2M4O5ANCNFSM6AAAAAA4YIDVWU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[akinwale]

This is a duplicate of #27202.

@sakluger This deals with the screens for picking the waypoints, while #27202 deals with the screen for picking the target workspace, so I'd say they're different.