[WAITING ON AIMANE TO COMPLETE CHECKLIST] [HOLD for payment 2023-10-02] [$500] Request money - Unread indicator doesn't appear when marking as unread in offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on + -> Request money -> Scan -> Choose file -> Continue
2. Reach "Receipt scan in progress…" page
3. Go offline
4. Chang date time
5. Mark the message as unread

Expected Result:

Unread indicator should appear

Actual Result:

Unread indicator doesn't appear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.67-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-05.At.22.44.04.mp4

Recording.1496.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dukenv0307

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693928604694079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01065ccca935909edf
• Upwork Job ID: 1701251311952404480
• Last Price Increase: 2023-09-18
• Automatic offers:
• aimane-chnaif | Reviewer | 26746297
• dukenv0307 | Contributor | 26746298
• dukenv0307 | Reporter | 26746300

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01065ccca935909edf

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[dukenv0307]

@izarutskaya Please help me to post my proposal in Slack to here. Thanks.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unread indicator doesn't appear when marking as unread in offline

What is the root cause of that problem?

When we edit the money request, we don't set lastReadTime and lastVisibleActionCreated for the transaction report in optimisticData. So unread doesn't work as expected

App/src/libs/actions/IOU.js

Line 994 in edab657

const optimisticData = [

What changes do you think we should make in order to solve the problem?

We should add optimisticData for transaction report in editMoneyRequest function

const currentTime = DateUtils.getDBTime();
    const optimisticReport = {
        lastReadTime: currentTime,
        lastVisibleActionCreated: currentTime
    };
    const optimisticData = [
        ...
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${transactionThread.reportID}`,
            value: optimisticReport,
        },
    ];

App/src/libs/actions/IOU.js

Line 994 in edab657

const optimisticData = [

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-09-05.at.22.50.53.mov

[jliexpensify]

Not overdue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aimane-chnaif]

@dukenv0307's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Yep, looks good! Assigning.

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[dukenv0307]

@aimane-chnaif The PR is ready to review.

[melvin-bot]

🎯 ⚡️ Woah @aimane-chnaif / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-09-19 04:22:01 Z
• when the PR got merged: 2023-09-22 01:43:57 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix unread marker of modified messsage #27740

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment offer (Reviewer)
• @dukenv0307 requires payment offer (Contributor)
• @dukenv0307 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment summary:

• Bug Reporter / Contributor: @dukenv0307 $50 + $500 + $250 = $800
• C+: @aimane-chnaif $500 + $250 = $750

Upwork job

@aimane-chnaif please complete the checklist!

[jliexpensify]

Bump @aimane-chnaif to complete the checklist please

[aimane-chnaif]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR: Followup #23961: update IOU report total in optimistic data on edit money request #25498
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Followup #23961: update IOU report total in optimistic data on edit money request #25498 (comment)
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to any transaction thread report where items are editable (not paid yet)
2. Go offline
3. Change date
4. Mark the system message "changed the date to xxx" as unread
5. Verify that unread indicator shows

[jliexpensify]

Everyone's paid and job removed, cheers!