[$500] [Dstance] - distance request money allows to request 0 amount after it show route exceeds maximum limitation error

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click '+' FAB
2. Click on request money and go to distance tab
3. Give start and finish that are far away and click next
4. Choose workspace and request the money
5. You can see it has requested 0 amount

Expected Result:

The next button won't allow user to proceed

Actual Result:

The next button allows user to proceed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1,3,66,3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

max.distance.request.0.amount.mp4

Recording.4357.mp4

Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693900129869839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d2c09a29868a725
• Upwork Job ID: 1700775335250837504
• Last Price Increase: 2023-09-10

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[distance] - distance request money allows to request 0 amount after it show route exceeds maximum limitation error

What is the root cause of that problem?

We only disable the next button if we don't select two different waypoints.

App/src/components/DistanceRequest.js

Line 266 in 6b1a667

isDisabled={_.size(validatedWaypoints) < 2}

What changes do you think we should make in order to solve the problem?

We should also disable the next button if we have the route error

const transactionRouteError = ErrorUtils.getLatestErrorField(transaction, 'route');

<Button
    success
    style={[styles.w100, styles.mb4, styles.ph4, styles.flexShrink0]}
    onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
    isDisabled={_.size(validatedWaypoints) < 2 || !_.isEmpty(transactionRouteError)}
    text={translate('common.next')}
/>

App/src/components/DistanceRequest.js

Line 266 in 6b1a667

isDisabled={_.size(validatedWaypoints) < 2}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d2c09a29868a725

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @alexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The next button is active even if there is an error.

What is the root cause of that problem?

The button does not have a condition if there is an error.

What changes do you think we should make in order to solve the problem?

We can add a hasRouteError condition(that is used to display the error text) so that the button is disabled.

App/src/components/DistanceRequest.js

Lines 263 to 269 in b11bddc

	<Button
	success
	style={[styles.w100, styles.mb4, styles.ph4, styles.flexShrink0]}
	onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
	isDisabled={_.size(validatedWaypoints) < 2}
	text={translate('common.next')}
	/>

            <Button
                success
                style={[styles.w100, styles.mb4, styles.ph4, styles.flexShrink0]}
                onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
                isDisabled={_.size(validatedWaypoints) < 2 || hasRouteError}
                text={translate('common.next')}
            />

What alternative solutions did you explore? (Optional)

NA

[alexpensify]

It looks like Melvin assigned @sophiepintoraetz first, so I'm removing my assignment to avoid doubling up work.

[paultsimura]

Should have been fixed in the current main branch by this PR: #26705.

[allroundexperts]

That's correct. Let's close this!

[sophiepintoraetz]

Okay but I still need to pay @lidiyakelay the $50 reporting bonus. @lidiyakelay - please can you apply for the job here and let me know here once you have done so?

[lidiyakelay]

@sophiepintoraetz I have applied for the job