[HOLD for payment 2023-10-27] [WAITING ON #28899][$500] [ANDROID] Chat - Closing phone menu, opens keypad with focus on compose

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on a report
3. Tap on pin
4. Tap unpin
5. Tap phone icon and note phone options opened
6. Tap phone icon again

Expected Result:

When user taps pin and again unpin, no effect on keypad. Similarly , when user taps phone icon, it must open.When user taps phone icon again, it must get closed and keypad must not get opened and focus on compose must not be shown

Actual Result:

When user taps pin and again unpin, no effect on keypad. Similarly, user taps phone icon, it gets open.When user taps phone icon again, the phone option closed and along with it, keypad got opened and focus on compose is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188767_phone.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ishpaul777

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d03561e10ecc1b6d
• Upwork Job ID: 1699319143390973952
• Last Price Increase: 2023-09-20
• Automatic offers:
• ginsuma | Contributor | 26850988
• ishpaul777 | Reporter | 26850990

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Closing phone menu, opens keypad with focus on compose

What is the root cause of that problem?

That problem happens on small device widths because we use Modal here.
The main composer will re-focus depend on modal key in Onyx here.

What changes do you think we should make in order to solve the problem?

In BaseVideoChatButtonAndMenu, we add shouldSetModalVisibility={false} to Popover.

[ishpaul777]

I reported this while ago but it was not filed @jliexpensify - https://expensify.slack.com/archives/C049HHMV9SM/p1692371426492029

[jliexpensify]

Thanks @ishpaul777 - if this is a bug, then you'll get credit as the Bug Reporter.

[jliexpensify]

@ishpaul777 and @lanitochka17 I cannot reproduce this on Android (v63). Can you please try reproducing and share a video?

[ishpaul777]

Reproduced

production-
https://github.com/Expensify/App/assets/104348397/d2185be7-25e8-41c7-8d33-ab5bfe09a563

Staging-
https://github.com/Expensify/App/assets/104348397/d5e15cc6-a73c-4d03-82b9-4b7b400e2ec1

[jliexpensify]

Oh my mistake - I was trying to repro on the app, not Chrome. I can definitely see the issue on Chrome now. Thanks @ishpaul777 !

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d03561e10ecc1b6d

[melvin-bot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[jliexpensify]

Looks like this might be an Android only issue - a colleague could not repro on iOS.

[ArekChr]

@ginsuma After this change, Onyx will store the isVisible value to true of the modal, which is not true. It may introduce other regressions

[ginsuma]

What changes do you think we should make in order to solve the problem?

In BaseVideoChatButtonAndMenu, we add shouldSetModalVisibility={false} to Popover.

@ArekChr My suggestion is not to use the modal key.

[ArekChr]

@ginsuma I mean this code,

    const hideModal = useCallback(
        (callHideCallback = true) => {
            if (shouldSetModalVisibility) {
                Modal.setModalVisibility(false);
            }
            if (callHideCallback) {
                onModalHide();
            }
            Modal.onModalDidClose();
            if (!fullscreen) {
                ComposerFocusManager.setReadyToFocus();
            }
        },
        [shouldSetModalVisibility, onModalHide, fullscreen],
    );

The issue is that when shouldSetModalVisibility is false, the isModalVisible remains true. If I'm not mistaken, this behaviour is intended for scenarios where modals shouldn't interfere with the composer's ability to blur. This is particularly relevant for modals like EmojiPicker, ReportActionContextMenu, or ReactionList, especially when not dealing with a full-overlay modal. In this scenario, BaseVideoChatButtonAndMenu is a full-overlay modal.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
• [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ArekChr] Determine if we should create a regression test for this bug.
• [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary:

• Bug Reporter: @ishpaul777 $50
• Contributor: @ginsuma $250
• C+: @ArekChr $250 (invoiced payment)

Upwork job

@ArekChr bump to complete the checklist please!

[ginsuma]

@jliexpensify App changed the UI after the PR merged, so I made a new PR, which is still in review.
#28899

[jliexpensify]

Thanks, have adjusted this GH!

[jliexpensify]

No payment date yet

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @ginsuma got assigned: 2023-09-25 06:43:24 Z
• when the PR got merged: 2023-10-18 17:23:04 UTC
• days elapsed: 17

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• mWeb: Keep the focus state of the composer when closing three dots menu in report header #28899

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ginsuma requires payment offer (Contributor)
• @ArekChr does not require payment (Contractor)
• @ishpaul777 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr] The PR that introduced the bug has been identified. Link to the PR:
• [@ArekChr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ArekChr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ArekChr] Determine if we should create a regression test for this bug.
• [@ArekChr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ArekChr]

• Link to the PR: No bug identified.
• Link to comment: n/a
• Link to discussion: n/a
• Determine if we should create a regression test for this bug: We can create regression test.

Regression test proposal:

1. Open any report.
2. Check the status of the composer box to ensure it is not currently active. If it is active, click elsewhere on the screen to remove focus from the composer box.
3. Tap on three-dot icon in upper right corner.
4. Hide options modal.
5. Verify once again that the composer box remains unfocused.

Do we agree 👍 or 👎

[jliexpensify]

@pecanoro it looks like this PR was merged in 17 days. Normally, we'd cancel the contract and not issue payment for this length of time, but it looks like there was quite a bit of discussion in the PR. Should we penalise anyone or keep it at $500?

[pecanoro]

Yes, the PR took a bit since there was a bit of back and forth, but we should do the 50% penalty as those are our rules.

[ginsuma]

@jliexpensify App changed the UI after the PR merged, so I made a new PR, which is still in review. #28899

@jliexpensify Could you have a second thought about it?

[jliexpensify]

@ginsuma I think @pecanoro has taken into account #28899 - I just checked the dates and there's ~14 days between you being assigned the PR and it being merged by Rocio.

So essentially, the Contributor and C+ payout would be halved here.

Payment Summary

[ntdiary]

Hi, folks, coming from #30178 (comment).

Just a small note: ThreeDotsMenu is also used in MoneyRequestHeader. I have suggested tracking that issue under issue #15992.

test.mp4

[ginsuma]

Just a small note: ThreeDotsMenu is also used in MoneyRequestHeader. I have suggested tracking that issue under issue #15992.

Thank you.
To make it consistent, we can add shouldSetModalVisibility={false} to ThreeDotsMenu in MoneyRequestHeader like we did in the report header.
@ntdiary's approach looks promising.

[jliexpensify]

Paid and job closed.