[Hold for #25727][$500] Desktop - Recent chats disappeared from the LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Don't logged out with Account A for a while on Desktop
2. Be logged in mobile with the same account
3. Send message from Account B to Account A
4. Open the NewDot app in Desktop

Note: User have unread chat is from mobile notification, but chat is gone from the LHN completely in Desktop.

Expected Result:

Recent chats should be displayed in the LHN

Actual Result:

Recent chats disappeared from the LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692904986751459

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ad8b9a99977a1cd2
• Upwork Job ID: 1699301241160323072
• Last Price Increase: 2023-09-13

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kadiealexander]

I'm a bit stumped on repro'ing this one, have reached out to Rafe in Slack for some help with it.

[kadiealexander]

@rafecolton is going to try help with repro-ing this week.

[rafecolton]

Looks like @danieldoglas might have figured it out here

[kadiealexander]

Ah awesome, good catch!

[danieldoglas]

We still need someone to fix this, I think it can be external!

[kadiealexander]

Alright, proceeding even though I can't reproduce, trusting you guys! :D

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ad8b9a99977a1cd2

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[bernhardoj]

I think it's the same issue with this.

In #14523, we are hiding reports without visible report actions.

App/src/libs/ReportUtils.js

Lines 2846 to 2848 in 1bdc5ac

	// Hide chats between two users that haven't been commented on from the LNH
	if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report)) {
	return false;

The issue is, logging in will only load your report but not the report actions, so all 1:1 chat is hidden.

[melvin-bot]

@narefyev91, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@narefyev91, @kadiealexander Huh... This is 4 days overdue. Who can take care of this?

[danieldoglas]

@bernhardoj do you wanna do a proposal on that? I think the point is that we need to check the message property in the report itself too, not only the report actions. If we have a message on the report, then it should also be shown in the LHN

[bernhardoj]

@danieldoglas I'm not too sure if it's okay to check the report last message. Hiding an empty chat is coming from #14523 and based on this comment, we don't want to check the last message.

cc: @PauloGasparSv

[kadiealexander]

@danieldoglas any thoughts?

[danieldoglas]

From my understanding, that comment on the slack discussion that comment is referring to means:

• If lastMessage/lastMessageHtml is empty, then the only fallback possible is reportActionCount.

We can also do it differently:

• Check if reportActionCount is empty. If it's not, do what we do today
• if it is, check if the properties lastMessageHtml/lastMessage are empty. if they are, hide the chat.
• If not, show them.

Does that make sense @bernhardoj ?

[bernhardoj]

Check if reportActionCount is empty. If it's not, do what we do today

@danieldoglas reportActionCount does not exist, so it is always empty. I see the proposal from the issue you linked uses lastMessage from the report as the solution. I think we can see the result of it whether it raises another issue or not.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@narefyev91 @kadiealexander this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[danieldoglas]

The root cause for this is the same as #25727, which is older. We should HOLD this issue on that PR and test again after merging it.

[melvin-bot]

@narefyev91, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[peterdbarkerUK]

I experienced this too, though for web rather than desktop. Some screenshots:

This is disrupting communications without warning if it fails - let's treat with urgency :)

[kadiealexander]

Appreciate your screenshots, Peter! As Daniel said this is likely to be fixed with #25727 so it's on hold until that's done. 😊

[kadiealexander]

@peterdbarkerUK @rafecolton are you guys still experiencing this one? The related issue that should hopefully fix this is now done :)

[kadiealexander]

Closing for now, please reopen if this comes back!