[HOLD for payment 2023-08-24] Show chats in the LHN that have at least 1 ADDComment action, or 1 draft message

[JmillsExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Search for a user that you don't have any messages with, open the chat but don't send any message

Expected Result:

Chat should not show in the LHN as there is not at least 1 ADDComment action, or 1 draft message.

Actual Result:

Empty chat shows in the LHN and remains in the LHN after simply navigating to it.

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.58-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fbd874b8451c4608
• Upwork Job ID: 1618016837618089984
2023-01-24
• Automatic offers:
• | | 0

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fbd874b8451c4608

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[JmillsExpensify]

Pretty sure this is internal based on the this discussion, so I'm starting with that route first for now.

[JmillsExpensify]

Huh, I'm just seeing that now one internal was added to this issue. I'm not sure why that's the case. Trying to more labels to hopefully get it right.

[melvin-bot]

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[JmillsExpensify]

@PauloGasparSv Do you mind weighing in on this issue and whether we can open it up for external? Thank you!

[PauloGasparSv]

Hey @JmillsExpensify I'm pretty sure this can be an External change. I think we can add a filter in shouldReportBeInOptionList that filters out empty chats. That method is already called to filter out chats in LNH and the Search option (before you type anything)

But I'm not sure which fields to check so I created a thread on slack to discuss that

[JmillsExpensify]

Ok great! I'll add the external label in the meantime, looks like there is largely agreement in that thread.

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

[PauloGasparSv]

P.R. is under review!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Exclude empty chats (with no ADDCOMMENT actions or message drafts) from LNH #19321

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pac-guerreiro does not require payment (Contractor)
• @bernhardoj requires payment
• @thesahindia does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

Woo! It's live. Great work everyone getting this merged.

[JmillsExpensify]

@thesahindia Can you get the BZ checklist kicked off?

[thesahindia]

It's a new feature. We can add a test case if we don't have one

Empty chat shouldn't stay in LNH

1. Sign into newDot
2. Start a new chat with an account.
3. Make sure the new chat opens and is shown in the LNH
4. [WEB ONLY]: Copy the chat's reportID (last number in the chat's URL)
5. Open another existing chat (like concierge), make sure the chat disappears from the LNH
6. Start a chat again with that same account, make sure the account shows up in the Options list since you already had a chat with it before
7. Make sure the chat opens and has the same reportID (has the same URL)

Chat should stay in LNH if it has a Draft

1. In the same chat of used in the previous test, type some text into the composer but do not send the message
2. Open another existing chat (like concierge), make sure the chat stays in the LNH and shows the draft icon

Not-Empty chat should stay in LNH

1. Send a message in the same chat from the previous test.
2. Open another existing chat (like concierge), make sure the chat stays in the LNH.

Deleting messages and leaving chat empty should remove it from LNH

1. Open a chat that has a message sent inside it
2. Delete that message so the chat becomes empty
3. Open another existing chat (like concierge), make sure the chat disappears from the LNH.

Same tests w/ Group Chat

1. Start a new group chat with two accounts "B" and "C"
2. Make sure the new chat opens and is shown in the LNH
3. [WEB ONLY]: Copy the chat's reportID (last number in the chat's URL)
4. Open another existing chat (like concierge), make sure the chat disappears from the LNH
5. Start a group chat again with account B and C
6. Make sure the chat opens and has the same reportID (has the same URL)

Money request should stay in LNH

1. Start a new empty chat as userA with existing account userB
2. Sign in as userB and send a message back to userA so you become known
3. As userA, send new Money Request to userB inside the chat
4. As userB, delete the message sent in step 2 so the chat becomes empty
5. As userA, Open another existing chat (like concierge), make sure the reports don't disappear from the LNH
6. Make sure both the Money Request and the original report stay in the LNH

Workspace Chats should stay in LNH

1. Create a new Workspace in an account
2. Make sure the #admins, #announce and a workspace chats are created
3. Open another existing chat (like concierge), make sure none of the workspace related chats disappear from the LNH
4. Invite another user to the workspace, make sure another workspace chat is created for the invited user
5. Open another existing chat (like concierge), make sure none of the workspace related chats disappear from the LNH

[JmillsExpensify]

Thanks, sorry I missed your last response. I definitely think we need to add a regression test for every new feature. As for the payment summary, does the above issue technically count as a regression? Otherwise, I believe the payment summary is simply:

• Contributor: @bernhardoj $1,000
• Contributor+: @thesahindia $1,000 (via NewDot).

[bernhardoj]

@JmillsExpensify I didn't do the PR, so no payment for me.

[JmillsExpensify]

Ah thanks for your honesty! I'm not clear why you're assigned to this issue, though I'll update the payment summary in any case.

[JmillsExpensify]

Regression test has been created so I think we're all done here.

[JmillsExpensify]

$1,000 payment approved for @thesahindia based on BZ summary.