[HOLD for payment 2023-09-20] [$500] IOU - Inconsistent margin between green tick and amount on right and left

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open a 'paid' report OR use another user to request money to current user, pay the request and open 'paid' report
3. Inspect the margin between green tick and amount in line of Total, it is 4px and margin between green tick and amount for IOU messages below, it is 8px

Expected Result:

App should maintain consistent margin between amount and green tick irrespective of amount being on left or right of green tick

Actual Result:

App maintains 4px margin between amount and green tick for amount on right of green tick and 8px margin for amount on left of green tick

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-5

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

inconsistent.margin.between.green.tick.and.amount.mp4

Recording.1343.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692205502357469

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9f347b0a5be3236
• Upwork Job ID: 1699225416989421568
• Last Price Increase: 2023-09-06
• Automatic offers:
• dukenv0307 | Contributor | 26604851
• Dhanashree-Sawant | Reporter | 26604854

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent margin between green tick and amount on right and left

What is the root cause of that problem?

We use styles.defaultCheckmarkWrapper style that contains marginLeft: 8px in ReportPreview

App/src/components/ReportActionItem/ReportPreview.js

Line 186 in 79ea923

<View style={styles.defaultCheckmarkWrapper}>

While we use styles.mh1 in MoneyReportView

App/src/components/ReportActionItem/MoneyReportView.js

Line 53 in 79ea923

<View style={[styles.defaultCheckmarkWrapper, styles.mh1]}>

That is inconsistent.

What changes do you think we should make in order to solve the problem?

We should use styles.mh2 in MoneyReportView here to be consistent with the check mark in ReportPreview

App/src/components/ReportActionItem/MoneyReportView.js

Line 53 in 79ea923

<View style={[styles.defaultCheckmarkWrapper, styles.mh1]}>

OPTION: we also could be consistent the position of the checkmark

What alternative solutions did you explore? (Optional)

We can add styles.mh1 here

App/src/components/ReportActionItem/ReportPreview.js

Line 186 in 79ea923

<View style={styles.defaultCheckmarkWrapper}>

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent margin between green tick and amount on right and left

What is the root cause of that problem?

Here we are applying a horizontal margin of 4
https://github.com/Expensify/App/blob/74918db214c93349cdf77cd3236be36624c8bc5e/src/components/ReportActionItem/MoneyReportView.js#L53C78-L53C81

What changes do you think we should make in order to solve the problem?

We have two options here: we can either utilize a horizontal margin of 8 by switching this to styles.mh2, or we can modify it to employ styles.mr2 to apply margin exclusively on the right.

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Margin between the tick and number for the total is different from margin between tick and amount in IOU preview.

What is the root cause of that problem?

This is the style used for total

App/src/components/ReportActionItem/MoneyReportView.js

Line 53 in 03cf0b1

<View style={[styles.defaultCheckmarkWrapper, styles.mh1]}>

This defaultCheckmarkWrapper has only a left margin of 8 so the style.mh1 gives a margin of 4 to right.
For IOU preview,

App/src/components/ReportActionItem/IOUPreview.js

Line 213 in 03cf0b1

<View style={styles.defaultCheckmarkWrapper}>

the tick is to the right and the left margin in defaultCheckmarkWrapper keeps the margin between the tick and amount to 8. So these two appear inconsistent.

What changes do you think we should make in order to solve the problem?

We can change the marginLeft: 8 of defaultCheckmarkWrapper to marginHorizontal: 8 and remove the styles.mh1 in the total checkmark style. defaultCheckmarkWrapper is used only in IOUPreview, MoneyReportView, and ReportPreview so this change does not cause any new issues.

What alternative solutions did you explore? (Optional)

We can change the mh1 to mr2 in the total style and keep the defaultCheckmarkWrapper as it is.

Result

uniformMarginForTicks.mov

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[alphaboss1104]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent margin between green tick and amount on right and left

What is the root cause of that problem?

We use styles.defaultCheckmarkWrapper style that contains marginLeft: 8px in IOUPreview.js.

App/src/components/ReportActionItem/IOUPreview.js

Lines 213 to 218 in 03cf0b1

	<View style={styles.defaultCheckmarkWrapper}>
	<Icon
	src={Expensicons.Checkmark}
	fill={themeColors.iconSuccessFill}
	/>
	</View>

But we use styles.mh1 style that contains marginHorizontal: 4px in MoneyReportView.js.

App/src/components/ReportActionItem/MoneyReportView.js

Lines 53 to 58 in 03cf0b1

	<View style={[styles.defaultCheckmarkWrapper, styles.mh1]}>
	<Icon
	src={Expensicons.Checkmark}
	fill={styles.success}
	/>
	</View>

This is the root cause of this issue.

What changes do you think we should make in order to solve the problem?

We can modify the styles.defaultCheckmarkWrapper style like this:

    defaultCheckmarkWrapper: {
        marginHorizontal: 8,
        alignSelf: 'center',
    },

Then remove the styles.mh1 style from the MoneyReportView.js.

What alternative solutions did you explore? (Optional)

None.

[anmurali]

Will reproduce and slap the label on tomorrow

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Can reproduce but am not sure this is all that egregiously inconsistent

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c9f347b0a5be3236

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[melvin-bot]

@anmurali @ArekChr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ArekChr]

Proposal from @dukenv0307 Look good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@anmurali, @ArekChr Huh... This is 4 days overdue. Who can take care of this?

[ArekChr]

• Link to the PR: No bug identified.
• Link to comment: n/a
• Link to discussion: n/a
• Determine if we should create a regression test for this bug: I don’t think we need to add a regression test here.

[Julesssss]

Ready for payment

[melvin-bot]

@Julesssss, @anmurali, @ArekChr, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

I think this one is awaiting payment for:

• @dukenv0307 -- PR with urgency bonus
• @dhanashree-sawant -- bug report

[Julesssss]

Hi @anmurali, this issue is ready for payment

[Julesssss]

Hi @anmurali, this issue is ready for payment

Bumping for payment

[anmurali]

Paid contributor.
@dhanashree-sawant you need to accept this offer before I can pay

[dhanashree-sawant]

Hi @anmurali, the offer is for 50$ but the issue was raised on GH on 28 August, can you modify the offer to 250 for it?

[melvin-bot]

@Julesssss, @anmurali, @ArekChr, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

https://www.upwork.com/nx/wm/offer/27131727 @dhanashree-sawant

[dhanashree-sawant]

Thanks @anmurali, I have accepted the offer.

[Julesssss]

I think this can be closed, please someone comment or re-open if I am mistaken!

[dhanashree-sawant]

Hi @anmurali, can you approve the milestone on upwork once you are available?