[HOLD for payment 2023-09-08] [$1000] Web - The title of the details page for threads created in workspace rooms is not truncated.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the App
2. Open any workspace room ( #announce or #admin ).
3. Send a long message
4. Open this message in a thread and open this thread.
5. Click in the header of the thread room to open the details page.

Expected Result:

The title of the details page for threads created in workspace rooms should be truncated for the long message, like other threads in other rooms.

Actual Result:

The title of the details page for threads created in workspace rooms is not truncated for the long message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.56-21

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.From.11-08-23.04.49.16.mp4

Recording.1305.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Ahmed-Abdella

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691720994996269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013a07cbaf1626f8e4
• Upwork Job ID: 1695146256735473664
• Last Price Increase: 2023-08-25
• Automatic offers:
• dukenv0307 | Contributor | 26413756
• Ahmed-Abdella | Reporter | 26413758

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title of the details page for threads created in workspace rooms is not truncated.

What is the root cause of that problem?

We set numberOfLine for chat room as 0 to not truncated the name of the chat room. But the thread of the chat room is also a chat room. So the title of the detail page for threads is not truncated.

App/src/pages/ReportDetailsPage.js

Line 157 in dd0d98f

numberOfLines={isChatRoom ? 0 : 1}

What changes do you think we should make in order to solve the problem?

We should check here if the report is a chat room and not a thread, we will set numberOfLine.

numberOfLines={(isChatRoom && !isThread) ? 0 : 1}
textStyles={[styles.textHeadline, styles.textAlignCenter, (isChatRoom && !isThread) ? undefined : styles.pre]}

App/src/pages/ReportDetailsPage.js

Lines 157 to 158 in dd0d98f

	numberOfLines={isChatRoom ? 0 : 1}
	textStyles={[styles.textHeadline, styles.textAlignCenter, isChatRoom ? undefined : styles.pre]}

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.11-08-2023.16.36.56.webm

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title of the details page for threads created in workspace rooms is not truncated.

What is the root cause of that problem?

in this PR #23357 we don't truncate long room names in room details page.

App/src/pages/ReportDetailsPage.js

Line 157 in 9418b87

numberOfLines={isChatRoom ? 0 : 1}

so all threads in chat room don't truncate also

What changes do you think we should make in order to solve the problem?

we need to check if it not thread (isChatRoom && !isThread) instead of isChatRoom

// numberOfLines={isChatRoom ? 0 : 1}
// textStyles={[styles.textHeadline, styles.textAlignCenter, isChatRoom ? undefined : styles.pre]}

numberOfLines={(isChatRoom && !isThread) ? 0 : 1}
textStyles={[styles.textHeadline, styles.textAlignCenter, (isChatRoom && !isThread) ? undefined : styles.pre]}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013a07cbaf1626f8e4

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[studentofcoding]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The title of the details page for threads created in workspace rooms is not truncated.

What is the root cause of that problem?

We didn't include the condition to handle the thread of the chat room as it's also a chat room. So if the title of the Threads detail page is Very Long, is not truncated.

What changes do you think we should make in order to solve the problem?

• On ReportDetailsPage.js

1. We need to create a new variable called isAlsoChatRoom const isAlsoChatRoom = isChatRoom && !isThread; to manage Long Thread Title that's also a part of Chat Room (This way it'll be better for keeping the logic in one variable also)
2. Called isAlsoChatRoom into these props of DisplayNamesTooltipItem component (numberOfLines, textStyles & isEllipsisActive) like the below code (see that we called this inside isEllipsisActive so that we have an ellipsis at the end of the Long Title)

<DisplayNamesTooltipItem
     // Other props
     isEllipsisActive={isAlsoChatRoom} // add here
/>

@burczu @isabelastisser

Result

This way The Long title is always truncated & ellipsis like the example below

Long.Title.Truncated.and.Ellipsis.mov

What alternative solutions did you explore? (Optional)

None

[burczu]

All the proposals are pretty much the same and do the trick - @dukenv0307 was the first with his one, and I think we should proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @Ahmed-Abdella 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[dukenv0307]

@burczu The PR is ready to review.

[melvin-bot]

🎯 ⚡️ Woah @burczu / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-08-30 15:16:42 Z
• when the PR got merged: 2023-08-31 17:16:57 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix thread title is not truncated #26146

If no regressions arise, payment will be issued on 2023-09-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @dukenv0307 requires payment offer (Contributor)
• @Ahmed-Abdella requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR: Fix: Don't truncate long room names in room details page #23357
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix: Don't truncate long room names in room details page #23357 (comment)
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: no discussion yet
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[isabelastisser]

Payment summary:

@burczu does not require payment (Contractor)
@dukenv0307 (Contributor) $1000 review, $500 urgency bonus
@Ahmed-Abdella (Reporter) $250

[isabelastisser]

all set!