[HOLD for payment 2023-09-06] [$500] Dev : Splash logo is grayed out

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Launch the app

Expected Result:

Splash logo color is green

Actual Result:

Splash logo color is gray

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691776351462309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01118b202c69bb739e
• Upwork Job ID: 1694488036696375296
• Last Price Increase: 2023-08-24
• Automatic offers:
• c3024 | Contributor | 26331939
• situchan | Reporter | 26331942

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

@sakluger this is only reproducible on dev. Also confirmed by others - https://expensify.slack.com/archives/C049HHMV9SM/p1692173984147349

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev logo is grayed out and not green like staging

What is the root cause of that problem?

We are using a different color here

App/assets/images/new-expensify-dev.svg

Line 3 in 37ac252

.st2{fill:#002e22}

What changes do you think we should make in order to solve the problem?

We should add the same color of .st2 of stg

App/assets/images/new-expensify-stg.svg

Lines 5 to 10 in 37ac252

	<style type="text/css">
	.st0{clip-path:url(#SVGID_00000133515738354390477770000011007628954774516876_);}
	.st1{clip-path:url(#SVGID_00000101801061172099864470000010304357936332209807_);}
	.st2{fill:#03D47C;}
	.st3{fill:#008C59;}
	.st4{fill:#FFFFFF;}

if we like for dev as well
Note: Don't forget to restart the server to see the the effects of these changes.

What alternative solutions did you explore? (Optional)

Another bug we notice is the logo size is smaller in Dev compared to Stg and also the logo is clipped in mobile web splash screen in Dev. We may fix it separately or if we like to fix it here,
Cause for both is same that we are not using viewBox here

App/assets/images/new-expensify-dev.svg

Line 1 in 31e0377

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xml:space="preserve" id="Layer_1" width="80" height="80" x="0" y="0" style="enable-background:new 0 0 80 80" version="1.1">

which we are using in staging

App/assets/images/new-expensify-stg.svg

Line 4 in 31e0377

viewBox="0 0 80 81" style="enable-background:new 0 0 80 81;" xml:space="preserve">

We should add viewBox for dev logo as well.
We are using height and width 80, 80; 80, 81; 81, 81 for dev, stg, prod logos. This might be purposeful and this makes no noticeable difference. They might be retained as they are or changed if we would like to.

Result

[sakluger]

I'm not sure if this is actually a bug - I asked in the Slack thread if the differently styled logo would ever end up on staging or prod. If not, I don't know if it's something we need to fix.

[sakluger]

Seems like this was the PR where the logo was changed: #21551. Adding external label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01118b202c69bb739e

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[studentofcoding]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev logo is grayed out and not green like staging

What is the root cause of that problem?

We are using #002e22 instead of #03D47C on what we have on staging

What changes do you think we should make in order to solve the problem?

We have to edit the .st2 of to be using #03D47C instead

https://github.com/Expensify/App/blob/37ac2522440a671ec5f75e4e0685a22597db35a0/assets/images/new-expensify-dev.svg#L2C3-L4

What alternative solutions did you explore? (Optional)

None

Result

Dev.Splash.Logo.Fix.mov

cc: @mananjadhav @sakluger @kavimuru

[melvin-bot]

Upwork job price has been updated to $500

[sakluger]

Sorry for the late change here - after discussion with the team, this is a very small change and the bounty should be smaller.

[mananjadhav]

@c3024's proposal is good here.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @johnmlee101, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[situchan]

NOTE: #25643 was closed in favor of this one, so I believe this should be fixed as well here.

[c3024]

Thanks.
@johnmlee101 @sakluger @mananjadhav
Please confirm that we are fixing the clipped logo size (of mWeb) as well in this or do we fix it separately in #25643?

[c3024]

PR ready for review. I fixed the clipping of logo in mWeb as well. I will change it if necessary.

@mananjadhav

[melvin-bot]

🎯 ⚡️ Woah @mananjadhav / @c3024, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @c3024 got assigned: 2023-08-25 19:23:27 Z
• when the PR got merged: 2023-08-28 16:41:47 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• match Dev logo color to Staging and fix clipping of logo in smaller screens #25986

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests) - $750
• @c3024 requires payment offer (Contributor) - $750
• @situchan requires payment offer (Reporter) - $250

Payments above include efficiency bonus 🎉 🚀

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

I went ahead and paid out the reporter bounty to @situchan

@mananjadhav could you please complete the BZ checklist before tomorrow? That way we can approve your manual payment right away after the 7-day hold.

[sakluger]

Paid @c3024 via Upwork.

We're just waiting on the BZ checklist to be completed now.

[mananjadhav]

#21551 is the offending PR, and I've added a comment here.

I don't think we need any changes in the process, it's a miss considering we also had 122 other file changes. Moreover considering this is Dev only and logo, I don't think we need a regression test either.

@sakluger I've raised my request on NewDot.

[sakluger]

Thanks, I agree we don't need new regression tests since this only affected dev.

We're good to close out the issue!

[JmillsExpensify]

$750 approved for payment based on BZ summary.