[HOLD for payment 2023-08-28] [$1000] Offline mode: Crash after deleting Split Bill request

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Log in to any account.
2. Turn OFF the network connection to switch to OFFLINE mode.
3. Create a Split Bill request with two other users.
4. This will generate two sub-reports: report A and report B >> Click on report A to view its details.
5. Hover over the report and select the Delete option >> report A will be deleted.
6. Click on report B >> Observation: The app CRASHES.

Expected Result:

App should not crash

Actual Result:

App Crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.55-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

split-request-crash.mp4

Screen.Recording.20230817.183513.New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: @tranvantoan-qn

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692279822439699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e588feb8af6feae9
• Upwork Job ID: 1692566105949474816
• Last Price Increase: 2023-08-18
• Automatic offers:
• pradeepmdk | Contributor | 26243141
• tranvantoan-qn | Reporter | 26243145

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tranvantoan-qn]

FYI: This crash happens on ALL platforms, not only Android as specified in the issue Title

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Offline mode: Crash after deleting Split Bill request

What is the root cause of that problem?

in offline after deleting transaction its updated to null because its completed removed from onyx

App/src/libs/TransactionUtils.js

Line 196 in a068ca5

return _.filter(allTransactions, (transaction) => transaction.reportID === reportID);

App/src/libs/actions/IOU.js

Lines 1109 to 1113 in a068ca5

	const optimisticData = [
	{
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
	value: null,

here when offline mode optimisticData will execute so it's set as a null. when onyx null it will remove from local database

What changes do you think we should make in order to solve the problem?

1. we need to check its null or not

function getAllReportTransactions(reportID) {
    return _.filter(allTransactions, (transaction) => transaction && transaction.reportID === reportID);
}

And here we need update

App/src/components/ReportActionItem/MoneyRequestAction.js

Lines 133 to 136 in a068ca5

	props.network.isOffline
	) {
	shouldShowPendingConversionMessage = IOUUtils.isIOUReportPendingCurrencyConversion(props.reportActions, props.iouReport);
	}

to

IOUUtils.isIOUReportPendingCurrencyConversion(props.iouReport);

because this isIOUReportPendingCurrencyConversion is expecting the iouReport param only

App/src/libs/IOUUtils.js

Lines 77 to 79 in a068ca5

	function isIOUReportPendingCurrencyConversion(iouReport) {
	const reportTransactions = TransactionUtils.getAllReportTransactions(iouReport.reportID);
	const pendingRequestsInDifferentCurrency = _.filter(reportTransactions, (transaction) => transaction.pendingAction && TransactionUtils.getCurrency(transaction) !== iouReport.currency);

This Pr is modified the function
https://github.com/Expensify/App/pull/24345/files

result

Screen.Recording.2023-08-18.at.8.41.45.PM.mov

[MitchExpensify]

Having trouble reproducing this on a virtual device via Browserstack

[pradeepmdk]

@MitchExpensify you can verify on the web also. because its not a platform specfic

[MitchExpensify]

Ok awesome, trying that now @pradeepmdk !

[tranvantoan-qn]

On mobile, for the crash to occur, we will need to return to the LHN and then navigate to other reports, as demonstrated here:

Mobile.mp4

[MitchExpensify]

Reproduced!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e588feb8af6feae9

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[MitchExpensify]

Payment summary:

Reporting - $250 via Upwork to @tranvantoan-qn
Contributor - $1500 via Upwork to @pradeepmdk

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Offline mode: Crash after deleting Split Bill request - 25481 #25611

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @pradeepmdk requires payment offer (Contributor)
• @tranvantoan-qn requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@johnmlee101 / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
• [@johnmlee101 / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@johnmlee101 / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@pradeepmdk] Determine if we should create a regression test for this bug.
• [@pradeepmdk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[marcaaron]

is resulting in null being included in allTransactions here. I'd say that's the real root cause for this issue

Hmm actually - I think @roryabraham you are suggesting something like:

Given this setup:

• A subscriber to a collection key with waitForCollectionCallback: true

When this happens:

• A collection member key is set to null

We would expect this:

• The subscriber to get the new complete collection with any null values removed

If so, that makes sense to me and does sound like the real root cause. We should fix it in Onyx?

[pradeepmdk]

@marcaaron Yes, if we fixed it in Onyx that is the best solution here

[roryabraham]

Agree @marcaaron that's the real root cause and we should fix it in Onyx. Didn't do that today because I wanted to get the deploy out as quickly as possible, but I made a follow-up issue here: Expensify/react-native-onyx#310

[Pujan92]

• The subscriber to get the new complete collection with any null values removed

        if (_.isFunction(subscriber.callback)) {
            if (isCollectionKey(subscriber.key) && subscriber.waitForCollectionCallback) {
                const cachedCollection = getCachedCollection(subscriber.key);
                cachedCollection[key] = data;
                subscriber.callback(cachedCollection);
                continue;
            }

            subscriber.callback(data, key);
            continue;
        }

@marcaaron @roryabraham For non-collection also we are updating with a null value, so do we need to avoid that also?

[marcaaron]

No, we cannot do this. At least for now, it's the only way a subscriber can know that some data has been removed.

[MitchExpensify]

Paid and contracts ended #25481 (comment)

[MitchExpensify]

Bump BZ steps #25481 (comment)

[roryabraham]

I checked off my pieces in the BZ checklist. The main takeaway here is that the root cause was actually a bug in Onyx, and I'm working on fixing that in Expensify/react-native-onyx#311

[MitchExpensify]

Thanks @roryabraham! Looks like this can be closed in that case